From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3309C3DA59 for ; Mon, 15 Jul 2024 21:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PrFsaEY3YFVMERSSxHwPf6/7rkdQhgSWQ843FPXb6VM=; b=TWiqyEi6ZFxSazaA0ZQr2/fwiw pDZ3S4uZvC9e7bLwbF2IMMsHLt4+i+h6tQJ6mFHOHUHo/izpqk3LZSzhTH1WBGewphdDjFn+qe/0E 95l6WGHA4WWNNLm1rlbGjd1h4BcY4bRuj4lbiqNhWM63Wm0ZSFgBb1W1v+BIeg8b+Gy1KhcY2zgL+ xl69SkmkhFFimOkG+/hOZ09WmMeAmpzAFaEQoUtSdJ43VWDk2LKfMDT2qv6yK1a7QVVFGTt6Uff9Y QGjBQdR97/MpeyfLIBRbePUKnn42b3sC9N20lg9/UErDwz+Bun/PsWftmCvkWb079DfVecljUpqI8 IIugK6OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTT04-00000008Qah-0XLl; Mon, 15 Jul 2024 21:12:48 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTSze-00000008QP7-48jY for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 21:12:25 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 27A70FF803; Mon, 15 Jul 2024 21:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1721077937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PrFsaEY3YFVMERSSxHwPf6/7rkdQhgSWQ843FPXb6VM=; b=ZBKx2m7QZN1wibY9E26Du5teUQrGS6KveFuXrHhyhD5Pq/PNKteH13nR6Vm6Zyc0jFXUi1 Ac/u8zVk8E7U0h25euNwSPZKva97q6TrnO/87Wp5bxLf1xYuzdNyrvr33Sfrxc0Ua6jInH 0W49CA1vq/OeH7PRcgK9U9asubq8oTaq/4naZR/Wk1px6FIZpF+NgESEjCkXjoNeYNlWnA ZsnAZMEVSk0dOo3YTq2qDPWrzaI9vXy0nS+2JAZUzUscTH8ZbXJ9HBC6ZK84xi+WoHHqxt WQb4Lc2807kqw4QBnUD8jcD2x2VL2jBI/SPYMaC4kDA495T6XqUeuoxI4nsTmA== Date: Mon, 15 Jul 2024 23:12:16 +0200 From: Alexandre Belloni To: Valentin Caron Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Amelie Delaunay Subject: Re: [PATCH 0/4] rtc: stm32: add pinctrl interface to handle RTC outs Message-ID: <2024071521121650db391a@mail.local> References: <20240711140843.3201530-1-valentin.caron@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240711140843.3201530-1-valentin.caron@foss.st.com> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_141223_362941_18EA50DF X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 11/07/2024 16:08:39+0200, Valentin Caron wrote: > This series adds a pinctrl/pinmux interface to control STM32 RTC outputs. > > Theses two signals output are possible: > - LSCO (Low Speed Clock Output) that allow to output LSE clock on a pin. > On STM32MPU Discovery boards, this feature is used to generate a clock > to Wifi/Bluetooth module. > - Alarm out that allow to send a pulse on a pin when alarm A of the RTC > expires. > > First attempt [1] was based on 'st,' vendor properties, this one is based > on pinctrl and pinmux framework. > > As device-trees will be upstreamed separately, here is an example: > > stm32-pinctrl { > rtc_rsvd_pins_a: rtc-rsvd-0 { > pins { > pinmux = , /* OUT2 */ > ; /* OUT2_RMP */ > }; > }; > }; > > stm32-rtc { > pinctrl-0 = <&rtc_rsvd_pins_a &rtc_alarma_pins_a>; > > /* Enable by foo-device */ > rtc_lsco_pins_a: rtc-lsco-0 { > pins = "out2_rmp"; > function = "lsco"; > }; > > /* Enable by stm32-rtc hog */ > rtc_alarma_pins_a: rtc-alarma-0 { > pins = "out2"; > function = "alarm-a"; > }; > }; > > foo-device { > pinctrl-0 = <&rtc_lsco_pins_a>; > }; > This all seems good to me, I let you fix the various issues that have been reported. I was just wondering whether the LSCO clock was registered early enough to be used but I guess you tested that. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com