From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 644B6C3DA49 for ; Tue, 16 Jul 2024 08:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zyOpsaGpzP+QBRPn7diz7pq1SsPMwCpyOp0GZCKOw1Y=; b=Hqf4RVsyBczVP6/Q9Mxhp6wr5d X2Iw1lzQMJ0qJqnEJPEE6wQtAlb8eN/mnhpYHsyU2TR1s9qw4l6OAi60Nd/81OxlRyIcCkbUCWaQH VCqdOWFAQwRuUbV/MzfSXSLlLDgX4r8xqznO7Rb3dsia4qgdLLng/P8n4G8iamquZC1pQHNpwEIRQ HsL7+OSUBP+A428RyBXMMkl1t2bPyOO4dYeTNn1R4fDgx/wqfC++BJX0yWQztjRdTtQBxLL+m92tv EjjwItRhXIUorKDOUrKnUjN6bbO5l1oDu+YaKYwJj27V7Pvk7rwDPfCfqNXPTD7nNtIaU5FSU00b4 Cn8bLaRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTdMo-00000009hc5-3eF0; Tue, 16 Jul 2024 08:16:58 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTdMT-00000009hWm-3CZb for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 08:16:40 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 50031E000A; Tue, 16 Jul 2024 08:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1721117792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyOpsaGpzP+QBRPn7diz7pq1SsPMwCpyOp0GZCKOw1Y=; b=kGFX5YqqwwQT942zrMiy7EGFAsfNSOxtvM3CWzTO+SXuFq4SzIMCvm3SwzrcyYzOpBjfE7 6axOvP5S8n1yaXfrE5CEArnuTIWr1BRHADN1Ai1a6lEvtnkqNEKMS7acM6ay6O6im0Ld5C Q/r55q+QielUdAjSgzXnfN0cM+eq7P7wVlR60643f97lnQg8FBdu+lPXjHBnJGtB4V2lSk eJAPa0Nc61YT4RcXRwk6jzWnEfMbhV4GXH2MxpOFF3dpO/iu0osZPCUwRWVw7znMfLmbZf ubu2OiQ/C2gh14J2HH3mHaiRx7nTiSHLbvmWCJAyuzzG6hj1SgN32elcNdNtZg== Date: Tue, 16 Jul 2024 10:16:26 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Dan Carpenter , Romain Gantois Subject: Re: [PATCH net-next v17 00/14] Introduce PHY listing and link_topology tracking Message-ID: <20240716101626.3d54a95d@fedora-2.home> In-Reply-To: <20240715083106.479093a6@kernel.org> References: <20240709063039.2909536-1-maxime.chevallier@bootlin.com> <20240715083106.479093a6@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_011638_111185_F1313B6D X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Jakub, On Mon, 15 Jul 2024 08:31:06 -0700 Jakub Kicinski wrote: > On Tue, 9 Jul 2024 08:30:23 +0200 Maxime Chevallier wrote: > > This is V17 of the phy_link_topology series, aiming at improving support > > for multiple PHYs being attached to the same MAC. > > > > V17 is mostly a rebase of V16 on net-next, as the addition of new > > features in the PSE-PD command raised a conflict on the ethtool netlink > > spec, and patch 10 was updated : > > > > ("net: ethtool: pse-pd: Target the command to the requested PHY") > > > > The new code was updated to make use of the new helpers to retrieve the > > PHY from the ethnl request, and an error message was also updated to > > better reflect the fact that we don't only rely on the attached PHY for > > configuration. > > I lack the confidence to take this during the merge window, without > Russell's acks. So Deferred, sorry :( Understood. Is there anything I can make next time to make that series more digestable and easy to review ? I didn't want to split the netlink part from the core part, as just the phy_link_topology alone doesn't make much sense for now, but it that makes the lives of reviewers easier I could submit these separately. Thanks, Maxime