From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F7CC3DA59 for ; Tue, 16 Jul 2024 21:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4b0NYbQJuk2SR41bj/SYF23RGPkdLJhLHqB2cuiWoXs=; b=lug9OQjjPM0JNoKVi+FmyPoQML iIXZuYj8YDv8zobuffWeecwsNqVMvd2Z1nl4PneEGFtn4z6iFB/QZK9W2WISVg9EMmyHNHdCvmBSF 0kbsY7gXgLy5lPMNSp08ctEdRmntuus6C02urOqQMe4zzoiToYc+D3uGSOx3AOJ1Z/CINaCRdlcVc WQ340fir/PL5+aZpEmoj83MjPos4yFCjPIHhv5cK4BB6V33Jj11Z9wfuYmdWclS9sQZtIhyUIWO0o zCO0Q0MxdQXey9zJ05Njdj4Ep9EodDE/7VbY1hE1uomheotJ79afYNlsRZ9uhAk2RjOPMZxFQJ1GM axtRRKcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTpSY-0000000Bm8M-2OF5; Tue, 16 Jul 2024 21:11:42 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTpSD-0000000Bm3r-295y for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 21:11:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CED88CE1385; Tue, 16 Jul 2024 21:11:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC982C116B1; Tue, 16 Jul 2024 21:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721164279; bh=1jW0L9A3iRqmH7/WtH+jzNTYliriggcP44IDfWuj9xs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tghLh9jfOMBim3IX1QfM4yS2ofpN385lvpnXmFBp0BfF5oCxcniZ0tkKnocDQTqd/ c8XPw4rL2wdcmKF15SxMmzDfCWDFSSuUv2L0O0nkePDvp3igaULT1EO95aHbsMpR1K 0qGUejPBbh+Bx429UbcQtuozzegrutlE9LCl/l9XrudayzjyML9933cVEFWExtK5I/ 5NdKIUBZWOxxo+pGqZCueUAXxngGiwkDg2bgMaXznBMWoWZELO5Jqghqk6i0OQDsJQ aJgP89unBMxjg7/iCi/f+EyySFTuwbpjqq7NljneNSmUDix0HbUGYPfFn2ikM4zHyd 9qmwVfzEH77ng== Date: Tue, 16 Jul 2024 15:11:17 -0600 From: Rob Herring To: Frank Li Cc: Lee Jones , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/6] dt-bindings: mfd: Add i2c device adi5585 Message-ID: <20240716211117.GA387758-robh@kernel.org> References: <20240716-adi-v1-0-79c0122986e7@nxp.com> <20240716-adi-v1-1-79c0122986e7@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716-adi-v1-1-79c0122986e7@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_141121_944405_2B9645E9 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 03:28:24PM -0400, Frank Li wrote: > Add adi5585, which provide gpio, pwm and keypad controller. > > Signed-off-by: Frank Li > --- > .../devicetree/bindings/mfd/adi,adp5585.yaml | 83 ++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml b/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml > new file mode 100644 > index 0000000000000..03c4760242ddd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,adp5585.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADI adp5585 GPIO, PWM, keypad controller > + > +maintainers: > + - Frank Li > + > +description: > + adp5585 is a multifunctional device that can provide GPIO, PWM and keypad. > + > +properties: > + compatible: > + const: adi,adp5585 > + > + reg: > + items: > + description: I2C device address. > + > + gpio: > + type: object > + properties: > + compatible: > + const: adp5585-gpio > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + required: > + - compatible > + - gpio-controller > + - "#gpio-cells" > + > + additionalProperties: false > + > + pwm: > + $ref: /schemas/pwm/pwm.yaml > + properties: > + compatible: > + const: adp5585-pwm > + > + "#pwm-cells": > + const: 3 > + > + required: > + - compatible > + - "#pwm-cells" > + > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mfd@34 { > + compatible = "adi,adp5585"; > + reg = <0x34>; > + > + gpio { > + compatible = "adp5585-gpio"; Missing vendor prefix. However, ... > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + pwm { > + compatible = "adp5585-pwm"; > + #pwm-cells = <3>; > + }; There's no need for these child nodes. This can be just: mfd@34 { compatible = "adi,adp5585"; reg = <0x34>; gpio-controller; #gpio-cells = <2>; #pwm-cells = <3>; }; Rob