From: Hsiao Chien Sung via B4 Relay <devnull+shawn.sung.mediatek.com@kernel.org>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Hsiao Chien Sung <shawn.sung@mediatek.corp-partner.google.com>,
CK Hu <ck.hu@mediatek.com>,
Hsiao Chien Sung <shawn.sung@mediatek.com>
Subject: [PATCH v4 1/5] drm/mediatek: Support "None" blending in OVL
Date: Wed, 17 Jul 2024 13:24:41 +0800 [thread overview]
Message-ID: <20240717-alpha-blending-v4-1-4b1c806c0749@mediatek.com> (raw)
In-Reply-To: <20240717-alpha-blending-v4-0-4b1c806c0749@mediatek.com>
From: Hsiao Chien Sung <shawn.sung@mediatek.com>
Support "None" alpha blending mode on MediaTek's chips.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 9d6d9fd8342e..add671c38613 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -434,6 +434,7 @@ void mtk_ovl_layer_config(struct device *dev, unsigned int idx,
unsigned int fmt = pending->format;
unsigned int offset = (pending->y << 16) | pending->x;
unsigned int src_size = (pending->height << 16) | pending->width;
+ unsigned int blend_mode = state->base.pixel_blend_mode;
unsigned int ignore_pixel_alpha = 0;
unsigned int con;
bool is_afbc = pending->modifier != DRM_FORMAT_MOD_LINEAR;
@@ -463,7 +464,8 @@ void mtk_ovl_layer_config(struct device *dev, unsigned int idx,
* For RGB888 related formats, whether CONST_BLD is enabled or not won't
* affect the result. Therefore we use !has_alpha as the condition.
*/
- if (state->base.fb && !state->base.fb->format->has_alpha)
+ if ((state->base.fb && !state->base.fb->format->has_alpha) ||
+ blend_mode == DRM_MODE_BLEND_PIXEL_NONE)
ignore_pixel_alpha = OVL_CONST_BLEND;
if (pending->rotation & DRM_MODE_REFLECT_Y) {
--
2.43.0
next prev parent reply other threads:[~2024-07-17 5:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 5:24 [PATCH v4 0/5] Support alpha blending in MTK display driver Hsiao Chien Sung via B4 Relay
2024-07-17 5:24 ` Hsiao Chien Sung via B4 Relay [this message]
2024-07-17 13:49 ` [PATCH v4 1/5] drm/mediatek: Support "None" blending in OVL AngeloGioacchino Del Regno
2024-07-17 5:24 ` [PATCH v4 2/5] drm/mediatek: Support "None" blending in Mixer Hsiao Chien Sung via B4 Relay
2024-07-17 5:58 ` CK Hu (胡俊光)
2024-07-17 5:24 ` [PATCH v4 3/5] drm/mediatek: Support "Pre-multiplied" blending in OVL Hsiao Chien Sung via B4 Relay
2024-07-17 13:49 ` AngeloGioacchino Del Regno
2024-07-17 5:24 ` [PATCH v4 4/5] drm/mediatek: Support "Pre-multiplied" blending in Mixer Hsiao Chien Sung via B4 Relay
2024-07-17 6:05 ` CK Hu (胡俊光)
2024-07-17 5:24 ` [PATCH v4 5/5] drm/mediatek: Support alpha blending in display driver Hsiao Chien Sung via B4 Relay
2024-07-31 13:34 ` [PATCH v4 0/5] Support alpha blending in MTK " Chun-Kuang Hu
2024-08-02 1:25 ` Shawn Sung (宋孝謙)
2024-09-12 20:29 ` Alper Nebi Yasak
2024-09-13 1:25 ` CK Hu (胡俊光)
2024-09-13 2:56 ` Jason-JH Lin (林睿祥)
2024-09-13 5:40 ` Alper Nebi Yasak
2024-09-13 9:01 ` AngeloGioacchino Del Regno
2024-09-14 20:22 ` Jason-JH Lin (林睿祥)
2024-09-15 10:30 ` Shawn Sung (宋孝謙)
2024-09-13 2:56 ` Shawn Sung (宋孝謙)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717-alpha-blending-v4-1-4b1c806c0749@mediatek.com \
--to=devnull+shawn.sung.mediatek.com@kernel.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=shawn.sung@mediatek.com \
--cc=shawn.sung@mediatek.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).