From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE8D8C3DA5D for ; Thu, 18 Jul 2024 01:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CK59PJHvthhN1XqhU8dM7HWi+8LWSLWxbFsmB17zlH0=; b=g1g6cXZYmYRqXUzK3CdZmBBEP5 ELZXvM/4g1skxgq/KAGeNqmwQcUT0gRBdQOsmm/rU4wBPG1oBCpu1CgSDszu3ql4N51XEcSS7+Qo5 RxCews0oTdBdJMvfCWKVszAwzObwfGY1Xy3cNKaXUZp04W8rz3sb1vLbFJwUOvyOBG+QTE4c5CRfD iF8Im8tu9LsLlf+8n2qZehplRTfiOsl2Ff8nXf9E1ALdV80qXqCoi4BPuN7sQbp61ortMG/XzFot7 wIroZy9wId/us/bBoR4DM8vkZYlgxrIk84W5ufZMLT1mizQYLpY8uhhbNGyUznCz5+MwbHaPpINUx E06dEfSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUFdY-0000000FMaG-1xmx; Thu, 18 Jul 2024 01:08:48 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUFWZ-0000000FJsM-21rF for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2024 01:01:37 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-e0360f8d773so677544276.3 for ; Wed, 17 Jul 2024 18:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721264494; x=1721869294; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=CK59PJHvthhN1XqhU8dM7HWi+8LWSLWxbFsmB17zlH0=; b=32pOdaApVHDEi7Y8H+Uz9hnQCYV92/hZ92QsLIWTp5JmI4GQNJj/GTqrlIhsXL2Myb K/dR+LsPzP2FSI9pmXz6EWcP8y3MJ1lJNARMI0jACFYHlPUa2YL0hiSxpbzzhXco4lZt kQ6I9MR3fE/v3v4wsdnQDVx0ru4l78THOj+TOj7BYmcyhpjWSU0TRax0anPC05aS7JRI W/NSu7d4U4XvPE6pRoC67NHyNQt05ZsEpqrFhsY4gHrYhldE+htpgcm3O3yKtlkQy2+E PVbFLp8smJIQmCU/zzsOWqJccXnohVHLSKcMbzXJ34rnzBMD9CRr3U/bgowN2lz1uAuP ogcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721264494; x=1721869294; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CK59PJHvthhN1XqhU8dM7HWi+8LWSLWxbFsmB17zlH0=; b=jUPTdHT5hbcPQmbR4hSQ8TkZSceHTd1VuGgxp8jaoIwj7oYXJ2ITcP5DWkqX/GM4Vp cfE17a81tAcYd8JyQz6V6Hhn4Bxo2DoeDwTM8cKybP14GXrph47DoZR6NxdaNMwypemT dw8P+sbA4F6Hza1uBx9dkSA/6SRpmikQ5EjXz4cMt142nbLEhErlSjnWfN1p0sRt3Ti5 z+2plblBwSabhPmTMOhWr3EvAmgZWxzuelGDoSWqiEu3t2XuUiQsBJgJvEfjsyBoGdqT 6ohH4qa+qOnSUXrINKq3CoxYJGtr9wOWsFSLKzwW5E0EqKahgesJLTPhrH1zpwVPTpGQ Pnog== X-Forwarded-Encrypted: i=1; AJvYcCWndy1xdHRcz3f+vmxIv8sNpxIko5TqQQJhvbagdKD9coVTU47CLVCpodV3lmQXCifryDCIy/f3G9X1WNg4VZqeLlbXpSpb4ZKVw2iERQPkPDaWD98= X-Gm-Message-State: AOJu0YxZuWofBk/cyH9YwMD9o+wY70txdxeUxvmEhvaueFgUzIfwZZKR N1hls1HdHgcu7EzSRwnQ7lYZCtCfKdT0y5wpn1uZjwqrK7hL7OOhriZGQT48v3VF512o9Nnyi8J q6Qm33Q== X-Google-Smtp-Source: AGHT+IF0zgfiI7337Gx4Yjc5WQ+vYPQsx4H9UggbKoSxg5u9Xfw8UkV6hdUgp0OEYyULUUoe/l5TQODhg0kQ X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:940b:9044:fa83:4060]) (user=irogers job=sendgmr) by 2002:a5b:8c5:0:b0:e05:b006:9e12 with SMTP id 3f1490d57ef6-e05fed6ced8mr7959276.11.1721264494077; Wed, 17 Jul 2024 18:01:34 -0700 (PDT) Date: Wed, 17 Jul 2024 18:00:21 -0700 In-Reply-To: <20240718010023.1495687-1-irogers@google.com> Message-Id: <20240718010023.1495687-26-irogers@google.com> Mime-Version: 1.0 References: <20240718010023.1495687-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.1089.g2a221341d9-goog Subject: [PATCH v6 25/27] perf kwork: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_180135_552431_9C8E6087 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers Reviewed-by: Adrian Hunter --- tools/perf/builtin-kwork.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 8ffaa80a2d1d..6a4281b8fd10 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -2322,12 +2322,6 @@ int cmd_kwork(int argc, const char **argv) { static struct perf_kwork kwork = { .class_list = LIST_HEAD_INIT(kwork.class_list), - .tool = { - .mmap = perf_event__process_mmap, - .mmap2 = perf_event__process_mmap2, - .sample = perf_kwork__process_tracepoint_sample, - .ordered_events = true, - }, .atom_page_list = LIST_HEAD_INIT(kwork.atom_page_list), .sort_list = LIST_HEAD_INIT(kwork.sort_list), .cmp_id = LIST_HEAD_INIT(kwork.cmp_id), @@ -2462,6 +2456,11 @@ int cmd_kwork(int argc, const char **argv) "record", "report", "latency", "timehist", "top", NULL }; + perf_tool__init(&kwork.tool, /*ordered_events=*/true); + kwork.tool.mmap = perf_event__process_mmap; + kwork.tool.mmap2 = perf_event__process_mmap2; + kwork.tool.sample = perf_kwork__process_tracepoint_sample; + argc = parse_options_subcommand(argc, argv, kwork_options, kwork_subcommands, kwork_usage, PARSE_OPT_STOP_AT_NON_OPTION); -- 2.45.2.1089.g2a221341d9-goog