* [PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n
@ 2024-07-19 7:27 Arnd Bergmann
2024-07-19 7:51 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-07-19 7:27 UTC (permalink / raw)
To: Jeff Johnson, Bartosz Golaszewski
Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The new HAVE_PWRCTL option is defined in the PCI subsystem, so
selecting it unconditionally when PCI is disabled causes a harmless
warning:
WARNING: unmet direct dependencies detected for HAVE_PWRCTL
Depends on [n]: PCI [=n]
Selected by [y]:
- ARCH_QCOM [=y]
Add 'if PCI' in the qualcomm platform to hide the warning.
Fixes: ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/Kconfig.platforms | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 9b62c63781ec..6c6d11536b42 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -266,7 +266,7 @@ config ARCH_QCOM
bool "Qualcomm Platforms"
select GPIOLIB
select PINCTRL
- select HAVE_PWRCTL
+ select HAVE_PWRCTL if PCI
help
This enables support for the ARMv8 based Qualcomm chipsets.
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n
2024-07-19 7:27 [PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n Arnd Bergmann
@ 2024-07-19 7:51 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2024-07-19 7:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jeff Johnson, Bartosz Golaszewski, Arnd Bergmann,
linux-arm-kernel, linux-kernel
On Fri, Jul 19, 2024 at 9:28 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new HAVE_PWRCTL option is defined in the PCI subsystem, so
> selecting it unconditionally when PCI is disabled causes a harmless
> warning:
>
> WARNING: unmet direct dependencies detected for HAVE_PWRCTL
> Depends on [n]: PCI [=n]
> Selected by [y]:
> - ARCH_QCOM [=y]
>
> Add 'if PCI' in the qualcomm platform to hide the warning.
>
> Fixes: ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm64/Kconfig.platforms | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 9b62c63781ec..6c6d11536b42 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -266,7 +266,7 @@ config ARCH_QCOM
> bool "Qualcomm Platforms"
> select GPIOLIB
> select PINCTRL
> - select HAVE_PWRCTL
> + select HAVE_PWRCTL if PCI
> help
> This enables support for the ARMv8 based Qualcomm chipsets.
>
> --
> 2.39.2
>
>
I applied it manually. For some reason b4 cannot grab this from lore.
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-19 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-19 7:27 [PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n Arnd Bergmann
2024-07-19 7:51 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).