From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50A8EC3DA59 for ; Fri, 19 Jul 2024 07:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zHNmiSYfmrbUy3H9XMSQC9AlAhfz6iTU/kfDi3XwJ2c=; b=G04UpoG7HSG5ZauAGEWFQiCGO1 9NpXKzbD4JBkkxg1MkqALaWEIybhwfaNFCpLladVd2v5R1Rxls9jGUl+ex+HZ+8PrKRh2cagg8w/m orREp+8owgKunBtBykXHJm4QDgSBgQAdNjLEmD7SYh8KYDzeH2SQRv3MuGqECIR6WlTD3zYQrdEjC VNRNFQZvWtGOiG9GqTb1fxpZwcLGMkXPh530eOWVBpmL/He3iRhZvLN1OK/iMk+K8JD/miTBALVb1 BN3gMaaJQ/tQnjC/du4VLEHQzVEbmaHRw71zyV2+5b8Z0ExaNC1OEVFMh9mMosGPgjr4PjZAgedM0 2Mh6oFRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUiEQ-00000001wcu-2qqG; Fri, 19 Jul 2024 07:40:46 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUiE5-00000001waK-2ILr; Fri, 19 Jul 2024 07:40:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gGKYeYQassQqnMtNdGAvBXgguXGGyRMOn6GcTaBE/kUsSoemuk0mRnHztBx4LJUEiUArsZA5Jwihp8upq1CstpJVGSJtqDDsOwlzt8c/9xpRFFMdzFQmgqOIcjVDENh7rZF/9SOX4pmaGlTZvNXtGSwycVhRirhQbpBKm2gGaCiiJ3xpFAxzG77AwoklXWdpmnuCTqqACZ1IchDzOC5GxLALB3Q2xmrIH7CmQ7ZrMi9lpM7+kNkaKBX4+k04CDR/i5c6XYr82cGF9rFEpfLEqAxp9KE3zIRL9akTxwDnhD/NRoITGstipTlPa3PDE1wF7ohz9NHxHEDjeEnZnuv6IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zHNmiSYfmrbUy3H9XMSQC9AlAhfz6iTU/kfDi3XwJ2c=; b=pfHhacJjs+YoU//YqEWHQlbXGy3j8bs6QXCMNivWeUvqr0q15X9g0LBWi0FJTLEIcc9QJU1GmB3kJlKsehFF0Xlv+tnTsqxaDCXkTx7h7OklJUV37x1A/br4Kn+da6ZaPWnznzQquBEO5TRl8I2KHVsKbKI1yS7l5LLAfiyIFupq4XRhcSSTCkdojB9jCzCiV2GZOTO1c8r6auIEb2choQ9+vueeiXbOq8VY904U4rKr5AcVmsV/CzxYDJhzSvSg7Kogbr/K75MNverR7bOHNG4NIYCFRJJMj31LuLb6le/X1i92lft7jsiZb0UoDs+Y5F0cSiISsY9Vw0ZWJAriZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zHNmiSYfmrbUy3H9XMSQC9AlAhfz6iTU/kfDi3XwJ2c=; b=bCfowr+uv+bhN6v2eLqsyZKn821/OOktUU4omgLH3nMX9gh12+XoMxzrKxq6lFFtCZZ5ROr0XepjDgE3NSaHXjkP0L8Wdbkffxi03EqOQA/oVwqbsSOVDRCic9CH7Mx2NsyZKBxD9lPuzbRvxmFNJ5Y5HdIbXPALzcVR2z5LQ9g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAXPR04MB8365.eurprd04.prod.outlook.com (2603:10a6:102:1cf::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Fri, 19 Jul 2024 07:40:18 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%5]) with mapi id 15.20.7784.016; Fri, 19 Jul 2024 07:40:18 +0000 Date: Fri, 19 Jul 2024 15:37:52 +0800 From: Xu Yang To: Frank Li Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: Re: [PATCH 5/6] usb: phy: mxs: enable weak 1p1 regulator for imx6ul during suspend Message-ID: <20240719073752.x3fonxhfsdnhwheu@hippo> References: <20240718102637.3964232-1-xu.yang_2@nxp.com> <20240718102637.3964232-5-xu.yang_2@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SGAP274CA0009.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::21) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAXPR04MB8365:EE_ X-MS-Office365-Filtering-Correlation-Id: fc7e4553-c8fb-4e95-3fca-08dca7c607da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uOUhrcfeG5iXJcBja8N+CD2sGhEUWRdeaV2GmlyloIEE5yN3KlCBFn2P7Zef?= =?us-ascii?Q?c44Y8+See7wlH/qKhaZWF6VpaFNGmiRolGZOtlnHFnSpRQAxyBnMhHsB2hry?= =?us-ascii?Q?mJLLzQ+w6kyTGY2TtsondurDuIAO5QTtQ2nXmgH/+J53bJcPO1gQbuQFaY2l?= =?us-ascii?Q?ooAG3UXBWaWK6mF2gOwaiAsaRCVZhK8YqKYUm4w9dQugExDYLn1l1qVbZMXX?= =?us-ascii?Q?5R2Nnv/nZwDWYN62bZjcWqIBrrxJIiaGB75hBTruKoSHWYOSf5zkFQkdp0dn?= =?us-ascii?Q?CfEetWDHHWRKJufrltVtGUGIZ8HqdFrH+TmdEpHN6P0rTkqVoBwtERjSnnrz?= =?us-ascii?Q?i9jaj7b2/Ltc88uPFMlpVD1etPOdmcwHYTg1KTqhMZoo9NW6NZX+0RyLL4MU?= =?us-ascii?Q?oJ0+dFyOsZ28ERUx13Hy2yHuc4US3wQcbnNSZomAqa/b8gcm8w+ObhojT7WM?= =?us-ascii?Q?WmfsUeTP77ANniLxTUOEA6cks5TfP5tM1jWNVvm0vgN+AtcgrhB3J2ZJroFV?= =?us-ascii?Q?qMrn5tIS+AVZDGhYg7cpWl09xrQlVEu1ak+bLu7kfrnkKuy/iej7eHnLKjU0?= =?us-ascii?Q?/Om2eCskVi3Yp5auclcrDreZiqzzQFMrTLwEFwU1bnnlUxcotbyU2RmJYsqK?= =?us-ascii?Q?8/w/WANYHsn2M7bTAaogszqCNqLCMDUgVcxaFoGtl9zy3Ys611Gva6cnA2RK?= =?us-ascii?Q?KiX7+bRwnuE3n3vQ2LE2seEd7FTADXmCI9hRkSiqtXBu66sn8U0oGD9+aka+?= =?us-ascii?Q?LYyi1ce1jEwGHlmFhZXIoJ8VAuhWWgLY7GsWkYzQpGv4vKL5fzNMYUs1wDLU?= =?us-ascii?Q?F9bgXU9jMnZvnHzPtJi8susr67yc78PUdCxBP64tHz6qDVyCraILJnHkSUmk?= =?us-ascii?Q?KmQLRaR1rkqDgJWdlRJv1hAglNq/nEq8E3WDbQJ5dTfbmGkuLes1/izDPZN0?= =?us-ascii?Q?J1vX5wNmEESekCucXG1MCRkuLBLph7SJHtEeUO5acxdwMBRmxt0nq8rP9SKE?= =?us-ascii?Q?/UxV2AmsMJL1wmQi+LsdiUQWizIzf+M0ixXmd3J8B02VJ2SwezrBDW1Au9jI?= =?us-ascii?Q?uCs78gg1oyzcJBFlWjZKUCC6lL9PD+BgkDdHFgYV29QfAwpUWqIugb2ARE37?= =?us-ascii?Q?7LIyKttNRt1E6F9MLtsOw/lmawT4dI303sh5aE35xf/oeEVZyrbBS7f8u5r0?= =?us-ascii?Q?V84uMcfjSBoYCuwdFpVTrJXMvKqg8mvIphF/rCMKhMozJNYADNNjIm8KfhTb?= =?us-ascii?Q?adcg442FQunX/3uwotxVQ4gKyaAFTHGB3E0IohSepRCiatLgrh1jHvuSEQOU?= =?us-ascii?Q?3QLlJgIYe7bmhNQXl5Mw3J/yOV++/8TU5XRght05WYQ69Nrgf8dbDz0Jy/Yd?= =?us-ascii?Q?llsgHArDrlciCXxZmLRqC1AX6z6flLJfeDClXcciXFfgQKRAZQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YWCa0UFLaK4VZ8Lt2dTCdXDOq28BYugHGHuM2V1Epo8E5QBhzhhsjginV83w?= =?us-ascii?Q?HM/RJ1B0Yv/ky2efpAylu0NkecgMpWTiBtTH0KtEPuSx1gnOL/VxGOwCntPg?= =?us-ascii?Q?CKWJTtxvvAT24vSa0EY1WkpFlILk99q2ctevC4OB6qRU+IHMwFTIndiJYvez?= =?us-ascii?Q?u9GP9gLWeZQnhZcm24zSaIVdp3u6y0IbFT9xIs5fnMm1rBTS4J8Uv2qwQV9Z?= =?us-ascii?Q?fHYClgnc38X0JJlhEU01B2Y+s3MPQE6qdT/YGAZs7eRxBRgxmJTjYk1ZpmtB?= =?us-ascii?Q?bnn1zItxDSJKisGTvVNe1c5A/vj+hKUgLr2mSlfIMa1Dj2REyRmgHfGnEfog?= =?us-ascii?Q?X2G7beghc04WJQ3PeRSAY5ilrLCDckF/+J9wnMi/tCAODCPbbGf6DR5C7kQ9?= =?us-ascii?Q?4Zlt5iEGcSrLhGxHJuVXK3kE0y846cGmI5BojLSKCVn61QqOczKz/IOJ8TYn?= =?us-ascii?Q?UmSuK7Pw449CyogVfGoXhVW3ua5zzVrUDJuXy0Nlqa1x66AXputMtn6/QudN?= =?us-ascii?Q?mf05sLLnH1P91z4zzx5XkHO/6aCp7NwNaoguQIuF3Z73InlGC4MmOlJ9WqD8?= =?us-ascii?Q?2u0cQkuxBGwqZ9jwQJyZurHl3HjvP/NEbcbsUvIguzoymaNODfI/1YiJt0AY?= =?us-ascii?Q?FvJlzGY1VtvyWM/AYQ5lGcLx3s9Y05Rf4SrZVyNEqXX2z9p3RhpFsVbX9Ton?= =?us-ascii?Q?lq/jRgHpm9iIkWaA5RwdPt6U4p8a7N2u5X72JtG1LyTEixgQPQVvgYWUtxmq?= =?us-ascii?Q?0/v84HtsVptriDlYmMy1TvD/hyUN/Xb6MSpvYj86G7CxIEiuMl1AKS+5vGw0?= =?us-ascii?Q?KsCp/LsgR9URsu0gJP4wWpsEyJ98tSqTDDK6xqnbh3vxKrZcV+IeZGfNKMCX?= =?us-ascii?Q?IC7NYVcER02CMgVE0zcvw96iyHMg/p4gMzOCP/kxmkcTKbFlGrrbt27dxDxK?= =?us-ascii?Q?znRzpskTWoKZaMnoRU1mdPzHolPG4lAfCYb1qHSIobkiHMZzI8fRLEOTMuo9?= =?us-ascii?Q?7kTD8s8E7nTEdJ/NKs2T0xoWV9fXUAyAlHaQTKILTdCj9uwGTQX4bPdtgmFX?= =?us-ascii?Q?ifO4YFVoD8606qtsc9mjUFJwnfNkPohJ6XtbPOpkvmZ7T7r8xbbYCBkbIN4C?= =?us-ascii?Q?gK9Dvbckg7WyY56uGPE1Okdr8NmYx/HCy8aKslT2jSkyTirE6cAw94jLPTdG?= =?us-ascii?Q?VuQ+d2yfwpYWfjWeKmMQjso/B0NXQygjV1doG02TA6RJ+oT+EkNd5cgtDaEL?= =?us-ascii?Q?P+gSD4GYS48arHkGPOcS43YW0QZ+3olmp9gfytNNcmaOfBYq6JC9IzpC3LCm?= =?us-ascii?Q?llTL/XkP6x7wnQCeJQspvHDpYKs8mghVreHbmKZw4UM5eFPVLJ6Un/8XxoPt?= =?us-ascii?Q?rPrvAlLZGko/XCjpgXda3uKCUUb4c2JgWt7p0RJQhDVQamA7+Ai8Q39XGkMe?= =?us-ascii?Q?1G9WlQgvSS+ghYIAVBZL+1jJNb61TB2kQu5uc6DVVo2a+hmHMlC9PkFZFybG?= =?us-ascii?Q?c9vHviQ1Xzn1zzPXKj9V7ls+LHuthb1JvWtLayWWsakcGusSVlAwsGz0CWnU?= =?us-ascii?Q?GFCVVjVAgA9TYGXRJeTmZvrwsKYGT9XeVTs8eQCM?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc7e4553-c8fb-4e95-3fca-08dca7c607da X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2024 07:40:17.9243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S4gIj9bnZ74Dw+/2ycJZxRS3LupRPC7qPt+SQVT3Lz8ihHBbCdMr9jlIw9hbx0oo5TLCbQQuMyaFYsYAfEF2jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8365 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_004025_620851_3264CFED X-CRM114-Status: GOOD ( 33.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2024 at 11:12:56AM -0400, Frank Li wrote: > On Thu, Jul 18, 2024 at 06:26:36PM +0800, Xu Yang wrote: > > For imx6ul PHY, when the system enters suspend, its 1p1 is off by default, > > that may cause the PHY get inaccurate USB DP/DM value. If the USB wakeup > > is enabled at this time, the unexpected wakeup may occur when the system > > enters suspend. > > 1p1 is off when the system enters suspend at iMX6UL. It cause the PHY get > wrong USB DP/DM value, then unexpected wakeup may occur if USB wakeup > enabled. Will change. > > > > > In this patch, when the vbus is there, we enable weak 1p1 during the PHY > > suspend API, in that case, the USB DP/DM will be accurate for USB PHY, > > then unexpected usb wakeup will not be occurred, especially for the USB > > charger is connected scenario. The user needs to enable PHY wakeup for > > USB wakeup function using below setting. > > Avoid use word "this patch", "this commit." > > Enable weak 1p1 during PHY suspend if vbus exist. So USB DP/DM is correct > when system suspend. > > Reproduce step: > > > > echo enabled > /sys/devices/platform/soc/2000000.aips-bus/20c9000.usbphy > > /power/wakeup > > echo mem > /sys/power/state, > > > then some error happen. > > Or just remove it. Okay, will change. > > > > > Signed-off-by: Xu Yang > > --- > > drivers/usb/phy/phy-mxs-usb.c | 32 ++++++++++++++++++++++++++++---- > > 1 file changed, 28 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c > > index 627733a982d1..dcd032678814 100644 > > --- a/drivers/usb/phy/phy-mxs-usb.c > > +++ b/drivers/usb/phy/phy-mxs-usb.c > > @@ -71,6 +71,9 @@ > > #define BM_USBPHY_PLL_EN_USB_CLKS BIT(6) > > > > /* Anatop Registers */ > > +#define ANADIG_REG_1P1_SET 0x114 > > +#define ANADIG_REG_1P1_CLR 0x118 > > + > > #define ANADIG_ANA_MISC0 0x150 > > #define ANADIG_ANA_MISC0_SET 0x154 > > #define ANADIG_ANA_MISC0_CLR 0x158 > > @@ -123,6 +126,9 @@ > > > > #define USB_PHY_VLLS_WAKEUP_EN BIT(0) > > > > +#define BM_ANADIG_REG_1P1_ENABLE_WEAK_LINREG BIT(18) > > +#define BM_ANADIG_REG_1P1_TRACK_VDD_SOC_CAP BIT(19) > > + > > #define to_mxs_phy(p) container_of((p), struct mxs_phy, phy) > > > > /* Do disconnection between PHY and controller without vbus */ > > @@ -197,7 +203,8 @@ static const struct mxs_phy_data imx6sx_phy_data = { > > }; > > > > static const struct mxs_phy_data imx6ul_phy_data = { > > - .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS, > > + .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS | > > + MXS_PHY_HARDWARE_CONTROL_PHY2_CLK, > > }; > > > > static const struct mxs_phy_data imx7ulp_phy_data = { > > @@ -243,6 +250,11 @@ static inline bool is_imx7ulp_phy(struct mxs_phy *mxs_phy) > > return mxs_phy->data == &imx7ulp_phy_data; > > } > > > > +static inline bool is_imx6ul_phy(struct mxs_phy *mxs_phy) > > +{ > > + return mxs_phy->data == &imx6ul_phy_data; > > You'd better define, MXS_PHY_POWER_OFF_AT_SUSPEND. > > is_phy_power_off_at_suspend(). > > Actually, you just need know if phy power off instead if it is 6ul phy. > Yes, you are right, but is_imx6ul_phy() may be used in other place and only 6ul phy has this issue, so I'd prefer to keep this form. Thanks, Xu Yang > > +} > > + > > /* > > * PHY needs some 32K cycles to switch from 32K clock to > > * bus (such as AHB/AXI, etc) clock. > > @@ -891,18 +903,30 @@ static void mxs_phy_wakeup_enable(struct mxs_phy *mxs_phy, bool on) > > > > static void mxs_phy_enable_ldo_in_suspend(struct mxs_phy *mxs_phy, bool on) > > { > > - unsigned int reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; > > + unsigned int reg; > > + u32 value; > > > > /* If the SoCs don't have anatop, quit */ > > if (!mxs_phy->regmap_anatop) > > return; > > > > - if (is_imx6q_phy(mxs_phy)) > > + if (is_imx6q_phy(mxs_phy)) { > > + reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; > > regmap_write(mxs_phy->regmap_anatop, reg, > > BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG); > > - else if (is_imx6sl_phy(mxs_phy)) > > + } else if (is_imx6sl_phy(mxs_phy)) { > > + reg = on ? ANADIG_ANA_MISC0_SET : ANADIG_ANA_MISC0_CLR; > > regmap_write(mxs_phy->regmap_anatop, > > reg, BM_ANADIG_ANA_MISC0_STOP_MODE_CONFIG_SL); > > + } else if (is_imx6ul_phy(mxs_phy)) { > > + reg = on ? ANADIG_REG_1P1_SET : ANADIG_REG_1P1_CLR; > > + value = BM_ANADIG_REG_1P1_ENABLE_WEAK_LINREG | > > + BM_ANADIG_REG_1P1_TRACK_VDD_SOC_CAP; > > + if (mxs_phy_get_vbus_status(mxs_phy) && on) > > + regmap_write(mxs_phy->regmap_anatop, reg, value); > > + else if (!on) > > + regmap_write(mxs_phy->regmap_anatop, reg, value); > > + } > > } > > > > static int mxs_phy_system_suspend(struct device *dev) > > -- > > 2.34.1 > >