From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65802C3DA59 for ; Sat, 20 Jul 2024 14:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D9/ZmisjFQb7llTRHLkVQG+s2AZpaKfJrpwhL6UWt/I=; b=uB6SXsYGAobBtWQ0SNOeENJV3F tdADnMBIohcHfFDiOBO8pVHoaiaKqivDiTJ/Smwu3Ru28n1dtKFP9QZ+QKY+9vNNaqbFVAzXx98Sw errSwGdIA9eS/6aBUbVko52gFjZebCz5kgGneSqHvsnpWyWhLBw0lWBwVIOeLLhX2u13gBrlrY1/y X31ZqGdtqxB5+XJJOVR0LtmgR8PRGI69TiDQ7EKSNLlqh2VENRwVuHBO2Ir6tiotGjsl3TmHe70ah KdDYhdNlWVy64Ny1zNH4yYvMDxAbb6hGshNcXU2Rw9AGMPdO9ULIdlQJJpFHNt1eW288ihAm4jpdn rJJBbFuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVBDO-00000005Fzs-33j4; Sat, 20 Jul 2024 14:37:38 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVBD2-00000005Fvt-1TfG for linux-arm-kernel@lists.infradead.org; Sat, 20 Jul 2024 14:37:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 936D3CE062A; Sat, 20 Jul 2024 14:37:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A615EC2BD10; Sat, 20 Jul 2024 14:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721486231; bh=5sIkcmDX5LYVDTGFJMDu6mH7R+pN9/g/83qb26ctnf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nxb6BZotZJtLGvYqZFlOzeR9UgGEfVrs4fW3okuLrZOEjTrM1HtragxnivFlUMgLy yU99qb9QXrh8F9zPFWKO8mTZE1a3GUL4CdC2PK0h6wnZIZuJdIGd+Nxzb1WuVQgOiW WSzzRzPMjgJDBymGSq1SWOoOmzlcVsBcrhv9fujicxj5EOk6ufBExWoLsJXbVFVOHy xY2gcQbOJ2Wmk3jOL7aqoTtaG5x2JlZz54+8ooXdBroeQRlPEGMvz6xTT/OpeKiDX0 RKBuAeZ2ymJRpL3EJIhTmEsWS6wdg5g0XTXajuNrgoNYoU23OzCxEgLyrYSRk7UTva SHvQe+aQFBACg== Date: Sat, 20 Jul 2024 08:37:08 -0600 From: Rob Herring To: Harry Austen Cc: Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Michal Simek , Shubhrajyoti Datta , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/7] dt-bindings: clock: xilinx: add description of user monitor interrupt Message-ID: <20240720143708.GA239850-robh@kernel.org> References: <20240720120048.36758-1-hpausten@protonmail.com> <20240720120048.36758-5-hpausten@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240720120048.36758-5-hpausten@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240720_073716_592400_1CFDE0EB X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 20, 2024 at 12:01:48PM +0000, Harry Austen wrote: > This Xilinx clocking wizard IP core outputs this interrupt signal to > indicate when one of the four optional user clock inputs is either > stopped, overruns, underruns or glitches. > > This functionality was only added from version 6.0 onwards, so restrict > it to particular compatible strings. > > Signed-off-by: Harry Austen > --- > .../bindings/clock/xlnx,clocking-wizard.yaml | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > index 9d5324dc1027a..4609bb56b06b5 100644 > --- a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > @@ -62,17 +62,37 @@ required: > - xlnx,speed-grade > - xlnx,nr-outputs > > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - xlnx,clocking-wizard-v6.0 > + - xlnx,versal-clk-wizard > + then: > + properties: > + interrupts: > + items: > + - description: user clock monitor interrupt > + > + interrupt-names: > + items: > + - const: monitor Properties need to be defined at the top-level (outside the if/then schema), then restricted here. > + > additionalProperties: false > > examples: > - | > + #include > clock-controller@b0000000 { > - compatible = "xlnx,clocking-wizard"; > + compatible = "xlnx,clocking-wizard-v6.0"; > reg = <0xb0000000 0x10000>; > #clock-cells = <1>; > xlnx,speed-grade = <1>; > xlnx,nr-outputs = <6>; > clock-names = "clk_in1", "s_axi_aclk"; > clocks = <&clkc 15>, <&clkc 15>; > + interrupts-extended = <&intc 52 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "monitor"; > }; > ... > -- > 2.45.2 > >