From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37E9BC3DA5D for ; Sun, 21 Jul 2024 07:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N02rs0beU0+PCjKU6W+pNs3gEfWqOvtg3yl3XFcbS8U=; b=KDjLwYKbJUTlTsJ8bWWleZaZHR E80aGBO3I8jvu7UjljdVS9oDT+kjFOBTGTCk14M83MfLue7uZFPSCFCUQHJOhwkP1H2LtmmlP6pwy 9clQPIGY3MRuchQVUpEKd8+enXSepEizt1oC0YVJAx66QKaJieKQQiO3sEOVOd+st0eQCBEVEnoBS QI/II3V/jPLlegAcJ6pLZrD8Gox0ndcma5M3sNOP29St6TBRsqROqHVBGBnB1dZjBy3Ok9PhVkTgU VAUv1c6x1H1zzOtGgkblLTn7Qr0SuViBHnQ8qaxFch0CaETTvLwIsjPYV9r6nHExkJtD0vd5z1iSX 3ESDJSBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVRB4-00000006P99-2pzR; Sun, 21 Jul 2024 07:40:18 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVRAi-00000006P3Z-1RGy for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 07:39:57 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-6510c0c8e29so31056637b3.0 for ; Sun, 21 Jul 2024 00:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721547594; x=1722152394; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=N02rs0beU0+PCjKU6W+pNs3gEfWqOvtg3yl3XFcbS8U=; b=HS+YIFSJyYjq3k+89yPUiEXNEI5VQdjDfgsqzgsz85mTDldwJb92lXJ/hPMlt/+rbZ I8sJsZpN3JlEBHNDOlCG5AEtoT57jQGW5IHTor7TY2tR1m6VywL6Iy1aw47gLCL/k7Xg LesO494s6fj05JGAhTysRAMlbjY4qrQtL2C0rqNlyhyF9XJMsdp8loeB3YP6alpLJ2zL XlR9ZGbbRKZgWtFxVJ1RSK942/WgaS8tZ8iy5BRmNaWVvkxri4ztiQhBOg9BuVV0YPpk DK1Kz4tUtIEuZ74GqUkBBzpUPAvtg9TCNnecLxMndtEUnLUjM/D1TUKNpOVUHP0jWZ0Y xe9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721547594; x=1722152394; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N02rs0beU0+PCjKU6W+pNs3gEfWqOvtg3yl3XFcbS8U=; b=gX95OLmf+q40IZGJTiubOiJKJjbiG8abmXIi52X9D11yJ3imLSivnAqSe0risO5WOw QdWoT7FuclhXqbKfqR+eA1uevoE1nPBxJna7MRBg3zs4hjbk3Hb0XNG2/Yt2GuJy5168 5LN1TAlwMWdjQ4QmUrLwI2RXyDP+yicR2bxKkRBcXxr+h4o+yUjz+KI3MXuIIjWQFC9Y kliJcr67uCc7o7WpqY3lLqwIkZxNNQF6vWwRM5kVs/KjD0KjgtqrfpNZ9CVVBrmVaF+n nzUcu/0kQ0cP9zqd0A/7aGUOtcOxPZ1ra5MW7dfnwQ+rZeWzsUetwJsleMUwtKpMurfu yIsw== X-Forwarded-Encrypted: i=1; AJvYcCUf0XWsi6Rl/HJ2rIxcxOGeXdiDVO/2wA+7mxKnuhHPIQ7Xsk2X4If49TibsOTm+taeWvKYdVWyf08taeOPY7OimQFgDBdKjKA9FlzjTKEvljdcUD8= X-Gm-Message-State: AOJu0Yzuwx2RiuP0EbGZDfiOHxGYVXyxSAH8yKGy1BVd9ohQebOQqmd1 Hq9IOFOiQKs9eX91z6z2mN+LNkZ+O2gg16Zbdg0cLiadqCKU8/zVXb0FaCtrQQ== X-Google-Smtp-Source: AGHT+IFQYY74iAGQY5pOOJPCWv5JUZVONiqWh0swcBRClZ6YAaFDgYxDWJLm9Z5K35Wb0bbXsmVAGg== X-Received: by 2002:a05:690c:4441:b0:665:7184:fcd0 with SMTP id 00721157ae682-66ad8dc0d02mr32319017b3.23.1721547594246; Sun, 21 Jul 2024 00:39:54 -0700 (PDT) Received: from thinkpad ([120.56.206.118]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d2243d137sm439633b3a.31.2024.07.21.00.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 00:39:53 -0700 (PDT) Date: Sun, 21 Jul 2024 13:09:46 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Jason Liu Subject: Re: [PATCH v7 02/10] PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI Message-ID: <20240721073946.GB1908@thinkpad> References: <20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com> <20240708-pci2_upstream-v7-2-ac00b8174f89@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240708-pci2_upstream-v7-2-ac00b8174f89@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_003956_408605_768BF671 X-CRM114-Status: GOOD ( 19.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 08, 2024 at 01:08:06PM -0400, Frank Li wrote: > From: Richard Zhu > > Correct occasional MSI triggering failures in i.MX8MP PCIe EP by applying > the correct hardware outbound alignment requirement. > > The i.MX platform has a restriction about outbound address translation. The > pci-epc-mem uses page_size to manage it. Set the correct page_size for i.MX > platform to meet the hardware requirement, which is the same as inbound > address alignment. Align it with epc_features::align. > > Fixes: 1bd0d43dcf3b ("PCI: imx6: Clean up addr_space retrieval code") > Signed-off-by: Richard Zhu > Acked-by: Jason Liu > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-imx6.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 9a71b8aa09b3c..ca9a000c9a96d 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1118,6 +1118,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie, > if (imx6_check_flag(imx6_pcie, IMX6_PCIE_FLAG_SUPPORT_64BIT)) > dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); > > + ep->page_size = imx6_pcie->drvdata->epc_features->align; > + > ret = dw_pcie_ep_init(ep); > if (ret) { > dev_err(dev, "failed to initialize endpoint\n"); > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்