From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FFE2C3DA61 for ; Sun, 21 Jul 2024 07:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hyQz2Ns66mgvWpxSfqn/FqrN5K/JDuDi/DmSKkr9CpA=; b=h0hTdfpgbm2XkLyuhvQFHq/StX z2divbOwLG3wEkUHB4Vg7c8xR+yAd7kW3a+fgv2Z6vR3McaGzr9lc0ocD8xk8gyCB3goZ1zaJmrWt JtbD4ZiN/nEFeNtDegSY0/+Sech/G6GMx3/3yCq3SJb9bdY1VUS1K+NWV4TCObibn9z7IzRRncF9C UNEO6ptmJc0ITWlvFHHAQkHJT1GkGH9bWeml0k3PycbBiomODP5jVLthh5yqke/PK8z5vyS1c6+Fw RzrOmCAs0vSs1U9VcW2gArZKZ0uQtCvjrUy6AyhObk/HfTP4nbX+4CkqSFixETyiEuIIu79qtjQ9E t61TR4EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVRS1-00000006QeJ-3pZx; Sun, 21 Jul 2024 07:57:49 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVRRe-00000006QXW-0x3J for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 07:57:28 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1fc658b6b2eso23541225ad.0 for ; Sun, 21 Jul 2024 00:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721548644; x=1722153444; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hyQz2Ns66mgvWpxSfqn/FqrN5K/JDuDi/DmSKkr9CpA=; b=WBFxTLkYoSvunM7MUSyYEUl2Hi5qm1WlgkZkczzGLjmZ4qi188zggMhSkzl89P5R9H L27MK9wy/CSFtURFvXzRHshoy8dOGsOTGFTNx/xj84jsr0IDLYBuHcQc61LT6+6UXKSB m/+sY+fffO6QlYhntXakRZCOc0ZeJXU/k41EhTSCfz2kKFJd3gCH5xSxgQtBwgBF38VA Cweb2H38bcroxvkZymFiaZqGECMvfp46MoDty+IWyAG8KRB7KqGWD0wPvCYRWHOrPzeJ 9fynQ7RprJYxz/oz6h2SqMpfusVHSnV0ObX+tGG6qN+2YfDSTyW+GFz2sHklJ1yrGBKB xwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721548644; x=1722153444; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hyQz2Ns66mgvWpxSfqn/FqrN5K/JDuDi/DmSKkr9CpA=; b=GUf45eAmsHKLGmWCI/UcsgXpkLvshnZA2sLLE2GeEN8WobM4WUSQ6XgobwbfkxS4Na JOSCbwPrCWjq/mouP68OqaaHUreZJ+i2v/QIB+w8W+dHtzWfHCDr1mk8CZKZOSumsIaQ UAj3kVIu7TlDaMeGcigD7ciJuWpFZQYFZqXPkmpJ73eTsRLpdTBcrQA5zd6uDkgCxcph lpK36aTQF5Gq9ABRJy2f0M48pErQIZztStMQNsmSjPOt6EXxAFW19gbAdRKh4eWBUyRF vBqQjgTzzCUf5c/T4/3KSKpLBEy5H1nWnIj9ZjfXxtZyTqpF2PCuVL0eGp4y1EsOEiO3 P/ng== X-Forwarded-Encrypted: i=1; AJvYcCWhxie4RvZm0ZPMcS8isD93FBYKYCDfzHdmPYBftn2o3MPQriHkOIXzKNHKd6Zja5np+lJv3tQnz6+fPfmgIJGP0rPYjPuVlTMOZoNXwibqRaEJq1w= X-Gm-Message-State: AOJu0YzsGWu0xrKZH4NWKqLJ9HdTPoSR5E4pw2/HuuNOXZB3VoIy4OIf l6sfTS5E2f0nwR3TzSledixrif0T0A4MXjbfjkbl5I6PIKT6GdP3qSVCXeklLQ== X-Google-Smtp-Source: AGHT+IERUkgk9IVWEdkvqOOdRMakPjOZKnaunfxav2UdDTQ2WsxGK8Rz6HmUXynq1p6YcDsh3CF0RA== X-Received: by 2002:a17:902:d50e:b0:1fb:59e6:b0e1 with SMTP id d9443c01a7336-1fd7457e63cmr41518775ad.32.1721548644189; Sun, 21 Jul 2024 00:57:24 -0700 (PDT) Received: from thinkpad ([120.56.206.118]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f2a4801sm32369595ad.113.2024.07.21.00.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 00:57:23 -0700 (PDT) Date: Sun, 21 Jul 2024 13:27:17 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 06/10] PCI: imx6: Improve comment for workaround ERR010728 Message-ID: <20240721075717.GD1908@thinkpad> References: <20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com> <20240708-pci2_upstream-v7-6-ac00b8174f89@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240708-pci2_upstream-v7-6-ac00b8174f89@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_005726_640433_EDA18B2E X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 08, 2024 at 01:08:10PM -0400, Frank Li wrote: > Improve comment about workaround ERR010728 by using official errata > document content(https://www.nxp.com/webapp/Download?colCode=IMX7DS_2N09P). > > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-imx6.c | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 2c60858b74a09..2b95c41f8907e 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -714,9 +714,26 @@ static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) > return 0; > > /* > - * Workaround for ERR010728, failure of PCI-e PLL VCO to > - * oscillate, especially when cold. This turns off "Duty-cycle > - * Corrector" and other mysterious undocumented things. > + * Workaround for ERR010728 (IMX7DS_2N09P, Rev. 1.1, 4/2023): > + * > + * PCIe: PLL may fail to lock under corner conditions. > + * > + * Initial VCO oscillation may fail under corner conditions such as > + * cold temperature which will cause the PCIe PLL fail to lock in the > + * initialization phase. > + * > + * The Duty-cycle Corrector calibration must be disabled. > + * > + * 1. De-assert the G_RST signal by clearing > + * SRC_PCIEPHY_RCR[PCIEPHY_G_RST]. > + * 2. De-assert DCC_FB_EN by writing data “0x29” to the register > + * address 0x306d0014 (PCIE_PHY_CMN_REG4). > + * 3. Assert RX_EQS, RX_EQ_SEL by writing data “0x48” to the register > + * address 0x306d0090 (PCIE_PHY_CMN_REG24). > + * 4. Assert ATT_MODE by writing data “0xbc” to the register > + * address 0x306d0098 (PCIE_PHY_CMN_REG26). > + * 5. De-assert the CMN_RST signal by clearing register bit > + * SRC_PCIEPHY_RCR[PCIEPHY_BTN] > */ > > if (likely(imx_pcie->phy_base)) { > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்