From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06E1DC3DA5D for ; Mon, 22 Jul 2024 16:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uCuI6+/c3y3OSHovTMHK8cH0YPZL3fNkJlzML9AF7GQ=; b=Lv5bGDiG5SyBYBnYJ+ctJFsUY4 HBftzTCJ3yCJvZ6/7+0i/+cEHp6g+VrrkAIZWO2FMsPH2N/cZ76v+LQk9BtX9ULVYPYXrxxGZ9lX5 W4WpAVFhdO0TpHE4CLNJHc4kRijmOz52GAacDqm/FjaPkEz54LgSGOnTbifg+3+dG7gQrWxKBm6Vh Mhcw0ba93AKQoDve5yt0Qgsm0P0FFdbPwS3RwhsahDr3uWvacI0q73YveAjVDt0Gx6J3SOez5catO mtuynbBLEantyrn1523xkfSKIvZrMx1zAKyvqqw+QckDtEb8T32CMJC2fKR7WvEe8nCj0kNMmogp7 VbNDfjXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVw2h-0000000A62g-2bX7; Mon, 22 Jul 2024 16:37:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVw2K-0000000A5xc-1EoT for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 16:37:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 93AD560B33; Mon, 22 Jul 2024 16:37:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDA3FC116B1; Mon, 22 Jul 2024 16:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721666239; bh=r7wrzTEhZ4vHnTem3SM0inPLsOlVUJANiUV8d/psgLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NCt7bRqgrIJtorXDDgsI6aVgh2IyB/qT8wPQEcU4ritxCOg5W2l4bfnNPTpo0vnRa qXZOIcU7D/Y+y47Eb0F8p4FC0gACBAUSVYAdkpp4eU2DFNP74XRFgZcmUZOWu2x565 vgqaSTi0bLF6+fQEgrWPDomt3kCdf+HQBNZUoX4Xi+Q7AFVPXUsQekJu0wN9R6fOwS J24bebXY4t1ldyKxlhp0qRNcnl1zzvFEKCV/aHT2eEFDvm17R3KnFeGHV8uyhiF5oh EAd0xzza24suP4hsWn5fS9Y5dhZtDW823bb67/8S1NzVgaSF6m2qC6GSW2X+jVRheg 9/iBsMc0CKh3Q== Date: Mon, 22 Jul 2024 17:37:14 +0100 From: Conor Dooley To: Richard Zhu Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, l.stach@pengutronix.de, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v1 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint Message-ID: <20240722-displace-amusable-a884352e0ff9@spud> References: <1721634979-1726-1-git-send-email-hongxing.zhu@nxp.com> <1721634979-1726-2-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xyn3EpKJewT48NFm" Content-Disposition: inline In-Reply-To: <1721634979-1726-2-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_093720_398566_98AF46FE X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --xyn3EpKJewT48NFm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2024 at 03:56:16PM +0800, Richard Zhu wrote: > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint. >=20 > Signed-off-by: Richard Zhu > --- > .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml= b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > index a06f75df8458..309e8953dc91 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > @@ -65,11 +65,13 @@ allOf: > then: > properties: > reg: > - minItems: 2 > - maxItems: 2 > + minItems: 4 > + maxItems: 4 > reg-names: > items: > - const: dbi > + - const: dbi2 > + - const: atu New properties in the middle of the list is potentially an ABI break. Why not add them at the end? > - const: addr_space > =20 > - if: > @@ -129,8 +131,11 @@ examples: > =20 > pcie_ep: pcie-ep@33800000 { > compatible =3D "fsl,imx8mp-pcie-ep"; > - reg =3D <0x33800000 0x000400000>, <0x18000000 0x08000000>; > - reg-names =3D "dbi", "addr_space"; > + reg =3D <0x33800000 0x100000>, > + <0x33900000 0x100000>, > + <0x33b00000 0x100000>, > + <0x18000000 0x8000000>; > + reg-names =3D "dbi", "dbi2", "atu", "addr_space"; > clocks =3D <&clk IMX8MP_CLK_HSIO_ROOT>, > <&clk IMX8MP_CLK_HSIO_AXI>, > <&clk IMX8MP_CLK_PCIE_ROOT>; > --=20 > 2.37.1 >=20 --xyn3EpKJewT48NFm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZp6KugAKCRB4tDGHoIJi 0iZjAP9MWw8PkOtx8+vjhpvxv3uO7ors0U0S+LKqUtQKj1HO2wD/YM74SYCGKKyu CopteoUYR8rynNHrukYnXQJY+Zqavg8= =T1co -----END PGP SIGNATURE----- --xyn3EpKJewT48NFm--