From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D71D4C3DA59 for ; Mon, 22 Jul 2024 16:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZD6hygs9XHgw4XUSEFdZ+bNfBEbCAVz9zoP/lOjpNuE=; b=snt5u/vZvpF3+LTAJvQgsWQEOt 3tWWYxY7GHfHtnCX9pKZRTk5d2/J/KqHMBKgJK1QQfYoWr3BbF0Gpjkwj4QUhnVGL8/WGCfofohUQ a4MsTfkoXeBkUAuPJ5QfeSX4Yq31i+CH08rTvnlpvwzYZcz3NgIVde6kxh0uK2gU8MRDOuXyjIBoS IH/JUJ5KOtZCsFVpJRQY+h2tG+oHWuIHLdBqp+bxRLyNNMMtxC6BVBw4RR9PyqK9QC7oxCYSs5H1B 7/4ZCmNqXXhA7x35m3o+Jyp0Febippszz+MwcZj6Y1HXS/4X8T/nofVYYUOd+DuujrZSs9mrJKvku P546dj0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVwFU-0000000A7WT-11mX; Mon, 22 Jul 2024 16:50:56 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVwF5-0000000A7Qw-1m8t for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 16:50:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 85761CE0BAA; Mon, 22 Jul 2024 16:50:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D04DCC116B1; Mon, 22 Jul 2024 16:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721667028; bh=66t+9hIP68IAhD6QVB6l6ykYDYgg5yCXHj2vD1KEeC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HZdnvfcvywZmjx/4GCW4ffOgZMwSc6LrqwpgC81/5bGJmqrVexcqlmZcNLOVHI+AZ +0AtmEFhW9DvYm8o+uNN0Eca8u2W6QjJmCs25AikaTXpfHKQAe4FaSzV1OCcWrk5OA G+Pwk07KBkUYjU3kWljsFUBr0yPbEcbhbs6f8IJha/2ZiLcw05PH9SefUdrNcU9c5y eYrAsVLFtXu8l8ABy04bZgx3AEibJnu88xyKBEdoE/GVXmczYPPi2TZD5jUJmgHFd0 3zsEb0NO4+k9FmU7QRrzU2glc3NP3d5CW2GsRySdmMEjfwKZPtT2/EKfmOijhYTd6Q /WKB9fMquIvlw== Date: Mon, 22 Jul 2024 17:50:23 +0100 From: Conor Dooley To: Pankaj Gupta Cc: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw binding doc Message-ID: <20240722-popper-comfort-7538ea70c77b@spud> References: <20240722-imx-se-if-v6-0-ee26a87b824a@nxp.com> <20240722-imx-se-if-v6-2-ee26a87b824a@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iLD5d4oSUIlBzqiU" Content-Disposition: inline In-Reply-To: <20240722-imx-se-if-v6-2-ee26a87b824a@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_095031_868621_69D09118 X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --iLD5d4oSUIlBzqiU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc., > creates an embedded secure enclave within the SoC boundary to enable > features like: > - HSM > - SHE > - V2X >=20 > Secure-Enclave(s) communication interface are typically via message > unit, i.e., based on mailbox linux kernel driver. This driver enables > communication ensuring well defined message sequence protocol between > Application Core and enclave's firmware. >=20 > Driver configures multiple misc-device on the MU, for multiple > user-space applications, to be able to communicate over single MU. >=20 > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. >=20 > Signed-off-by: Pankaj Gupta > --- > .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 ++++++++++++++++= ++++++ > 1 file changed, 91 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b= /Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > new file mode 100644 > index 000000000000..7511d0e9cf98 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave > + > +maintainers: > + - Pankaj Gupta > + > +description: | > + NXP's SoC may contain one or multiple embedded secure-enclave HW > + IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s) > + enables features like > + - Hardware Security Module (HSM), > + - Security Hardware Extension (SHE), and > + - Vehicular to Anything (V2X) > + > + Communication interface to the secure-enclaves(se) is based on the > + messaging unit(s). > + > +properties: > + compatible: > + enum: > + - fsl,imx8ulp-se > + - fsl,imx93-se > + - fsl,imx95-se > + > + mboxes: > + items: > + - description: mailbox phandle to send message to se firmware > + - description: mailbox phandle to receive message from se firmware > + > + mbox-names: > + items: > + - const: tx > + - const: rx > + > + memory-region: > + maxItems: 1 > + > + sram: > + maxItems: 1 > + > +required: > + - compatible > + - mboxes > + - mbox-names > + > +allOf: > + # memory-region > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8ulp-se > + - fsl,imx93-se > + then: > + required: > + - memory-region > + else: > + properties: > + memory-region: false > + > + # sram > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8ulp-se > + then: > + required: > + - sram > + > + else: > + properties: > + sram: false > + > +additionalProperties: false > + > +examples: > + - | > + senclave-firmware { Last revision this was "firmware", but now you've got something that appears non-generic. Why did you change it? The normal differentiator for multiple nodes is -[0-9]*, why can't you use that, if you're worried about multiple nodes? > + compatible =3D "fsl,imx95-se"; > + mboxes =3D <&ele_mu0 0 0>, <&ele_mu0 1 0>; > + mbox-names =3D "tx", "rx"; > + }; > +... >=20 > --=20 > 2.34.1 >=20 --iLD5d4oSUIlBzqiU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZp6NzwAKCRB4tDGHoIJi 0mt9AP9uT5bF8Ef28A5zuCf5EZWLfCY/xWhJNXCln3owDgovygEAqM+oWbWX2nnG KKHdKE+HM2QM274P7GaHl3aqBtYhBAk= =B9e0 -----END PGP SIGNATURE----- --iLD5d4oSUIlBzqiU--