From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCA62C3DA59 for ; Mon, 22 Jul 2024 17:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3JVe84HQNfQoJJYALOawN//G5k5cnCmlBe6TrYbvpEY=; b=XG18owQzblfi84OmvX+62l/Pi0 1cUKxBDHJA4MFhaDcw/qigqOsivxtfgR/r9PQDRmosQomFaxIR3Stj+Pahod9WT+vHhf3ec2UNzga ovuVKy811eZUvTdnbT1WHGPQWNX2I9P0WB3ebfuY7um8RbVvtowX2A/KPjwUJDZrwQDeKf69PhYTm nSAsAghYaEwDddnkQ2ZVtnjTi3fo2Iz4V39PUicPLe8exI21bBfKvnzv+ambA+Go9AtRFbxnKCM29 Orc3QkQ3cN9x1u6j/IWonE+tjbQUu3ucbgDaXdXNqmTW8vp8xKuN/Npzf2Nk4AMfQ8wK2IgyR0gbs i8k2PhNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVwcH-0000000AA7j-2tbd; Mon, 22 Jul 2024 17:14:29 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVwbt-0000000AA2l-3yPt for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 17:14:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A23FECE0BA7; Mon, 22 Jul 2024 17:14:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F1E6C116B1; Mon, 22 Jul 2024 17:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721668442; bh=nqDbSeOEjrZww2bjW5Y5ACpg5VESlrarvu6Mf3utbgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pStLs1D6atjirFbXkduIYobr0Ct/Sgjn0QoIpO1lee7/CbPaKgr9SafXtwvsS9rR+ grD7yprXFyTh5Pj3ebz5U/dM9p2xvPwKIDWbpv8esG5k9yH0wnfOvqn9Yxx7H7h1ib acowwQN2rN5REX8JwQ0h4fAc9QfmWwSZTiBjA4I9FoGjBTcEv4bmu8GQXguEetAvg9 eCujm5Jd7f7HG7WrGi03Bfb3JEElL6IQIG4qZd4tucw5HYeUcn42N7BN/4DrrqMwd4 dbxA8RexnKPUsuDvsz2ccQfDgq2FbpN1Y97Ixv7HlgRn3IhbVgDMNS4TvIuR2pNAZ2 3jY/05/z+kRIA== Date: Mon, 22 Jul 2024 18:13:58 +0100 From: Conor Dooley To: Harry Austen Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michal Simek , Shubhrajyoti Datta , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/7] dt-bindings: clock: xilinx: describe whether dynamic reconfig is enabled Message-ID: <20240722-removal-grandma-92cfe99b8a88@spud> References: <20240720120048.36758-1-hpausten@protonmail.com> <20240720120048.36758-7-hpausten@protonmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dcnYdkiBJnjYH+Dp" Content-Disposition: inline In-Reply-To: <20240720120048.36758-7-hpausten@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_101406_364855_816CAF9C X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --dcnYdkiBJnjYH+Dp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 20, 2024 at 12:01:58PM +0000, Harry Austen wrote: > Xilinx clocking wizard IP core's dynamic reconfiguration support is > optionally enabled at build time. Add a devicetree boolean property to > describe whether the hardware supports this feature or not. >=20 > Signed-off-by: Harry Austen > --- > .../devicetree/bindings/clock/xlnx,clocking-wizard.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard= =2Eyaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > index 4609bb56b06b5..890aeebf6f375 100644 > --- a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > @@ -40,6 +40,12 @@ properties: > - const: s_axi_aclk > =20 > =20 > + xlnx,dynamic-reconfig: > + type: boolean The type here should be "flag" not boolean, boolean can be set to "false" and what you're likely doing is just checking for the property being present. "flag" doesn't allow false. > + description: > + Indicate whether the core has been configured with support for dyn= amic > + runtime reconfguration of the clocking primitive MMCM/PLL. > + > xlnx,speed-grade: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [1, 2, 3] > @@ -88,6 +94,7 @@ examples: > compatible =3D "xlnx,clocking-wizard-v6.0"; > reg =3D <0xb0000000 0x10000>; > #clock-cells =3D <1>; > + xlnx,dynamic-reconfig; > xlnx,speed-grade =3D <1>; > xlnx,nr-outputs =3D <6>; > clock-names =3D "clk_in1", "s_axi_aclk"; > --=20 > 2.45.2 >=20 >=20 --dcnYdkiBJnjYH+Dp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZp6TVQAKCRB4tDGHoIJi 0hdmAQCqOMXx2CK3Q8yzIIBHMuERHAWGGfcI5gzwiytnYyIP9wEA7lTXK19quiSI Lk3aVqOddEgJEmbgqX2t6/H6W4duVw4= =2Kf6 -----END PGP SIGNATURE----- --dcnYdkiBJnjYH+Dp--