From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F20DDC3DA5D for ; Mon, 22 Jul 2024 15:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GNWJixiNfMKPP/+R2gtTxW/9++NegMtyU7tjlc/G2LM=; b=eVNPrCPHk9gLgc/Y+v50Q4OZ32 qZWkK3hTNPwqQn9HVjMA9221KmLXsn5rQC9L4A97WX784UjSEgJvzmZAfR29PucqZCvQRlTRhr+CE vl3atUpgsYShJR6nyliR5nSyBR2CWdFThVZ6+AblLk1j2+S88XG6dttfUZELAdFDR+qrHt7h4PiYh oHLS0brA5wkD5Agnq4lSW1MVrHZFoH7rV4SEwuxXlWMV65f+bQ+3dLfN3uNt80aAx3lRFqzcOU1rQ 2rSpXf39ZtSSAdqw7SYqmgrqTwYhqcPFzj5QMr43OXalkyiF2e1H8V666wJaOTb58T26nCLA8v57A Tmxhb5OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVuh4-00000009tfl-1L3c; Mon, 22 Jul 2024 15:11:18 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVugh-00000009tZq-2e62 for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 15:10:57 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 642412B3; Mon, 22 Jul 2024 17:10:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1721661012; bh=dyxL6DyS/3Rsh17E03qLzwN1Qt1eKMwVSphTPdr/jA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pFmbNAqfG5sUAp/ndPD4KGsBJ3I19V0FwD4KAU+w3b+tq4ZjSRRB02UXcDlMm69rD ESm/nWhBZtGL6Y484wmNwDkFNS7GL5DNT7KS0rC/wBVgAWf5CL+QLzEzjShPoJkmpK AntskOkygaX8aoNc1FP22mpILKngecc8zlajn1Kw= Date: Mon, 22 Jul 2024 18:10:35 +0300 From: Laurent Pinchart To: Yuji Ishikawa Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Sakari Ailus , Nobuhiro Iwamatsu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/6] media: videodev2.h: add visconti viif meta buffer format Message-ID: <20240722151035.GA31490@pendragon.ideasonboard.com> References: <20240709000848.1108788-1-yuji2.ishikawa@toshiba.co.jp> <20240709000848.1108788-3-yuji2.ishikawa@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240709000848.1108788-3-yuji2.ishikawa@toshiba.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_081055_830073_F5F49597 X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ishikawa-san, Thank you for the patch. On Tue, Jul 09, 2024 at 09:08:44AM +0900, Yuji Ishikawa wrote: > Adds the Toshiba Visconti VIIF specific metadata format > > - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters > - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics > > Signed-off-by: Yuji Ishikawa This patch looks fine. Assuming the corresponding documentation patch is fine too, Reviewed-by: Laurent Pinchart > --- > Changelog v10: > - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS > - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS > > Changelog v11: > - no change > > include/uapi/linux/videodev2.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 4e91362da6..562038f144 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -858,6 +858,10 @@ struct v4l2_pix_format { > /* Vendor specific - used for RaspberryPi PiSP */ > #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */ > > +/* Vendor specific - used for Visconti VIIF sub-system */ > +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS v4l2_fourcc('V', 'I', 'F', 'P') /* ISP Params */ > +#define V4L2_META_FMT_VISCONTI_VIIF_STATS v4l2_fourcc('V', 'I', 'F', 'S') /* ISP Stats */ > + > #ifdef __KERNEL__ > /* > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when -- Regards, Laurent Pinchart