From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Scally <dan.scally@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
jacopo.mondi@ideasonboard.com, nayden.kanchev@arm.com,
robh+dt@kernel.org, mchehab@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jerome.forissier@linaro.org, kieran.bingham@ideasonboard.com,
sakari.ailus@iki.fi
Subject: Re: [PATCH v6 03/18] media: uapi: Add 20-bit bayer formats
Date: Tue, 23 Jul 2024 01:13:22 +0300 [thread overview]
Message-ID: <20240722221322.GA32300@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240709132906.3198927-4-dan.scally@ideasonboard.com>
Hi Dan,
Thank you for the patch.
On Tue, Jul 09, 2024 at 02:28:51PM +0100, Daniel Scally wrote:
> The Mali-C55 requires input data be in 20-bit format, MSB aligned.
> Add some new media bus format macros to represent that input format.
>
> Co-developed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes in v6:
>
> - Fixed the table formatting
>
> Changes in v5:
>
> - New patch
>
> .../media/v4l/subdev-formats.rst | 252 +++++++++++++++++-
> include/uapi/linux/media-bus-format.h | 6 +-
> 2 files changed, 255 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> index 5dbf8c9b18fb..ff328eb485e8 100644
> --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
> +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> @@ -2664,7 +2664,7 @@ organization is given as an example for the first pixel only.
> \tiny
> \setlength{\tabcolsep}{2pt}
>
> -.. tabularcolumns:: |p{6.0cm}|p{0.7cm}|p{0.3cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|
> +.. tabularcolumns:: |p{6.0cm}|p{0.7cm}|p{0.3cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|p{0.22cm}|
>
> .. _v4l2-mbus-pixelcode-bayer:
>
> @@ -2677,10 +2677,14 @@ organization is given as an example for the first pixel only.
> * - Identifier
> - Code
> -
> - - :cspan:`15` Data organization
> + - :cspan:`19` Data organization
> * -
> -
> - Bit
> + - 19
> + - 18
> + - 17
> + - 16
> - 15
> - 14
> - 13
> @@ -2710,6 +2714,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`7`
> - b\ :sub:`6`
> - b\ :sub:`5`
> @@ -2731,6 +2739,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`7`
> - g\ :sub:`6`
> - g\ :sub:`5`
> @@ -2752,6 +2764,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`7`
> - g\ :sub:`6`
> - g\ :sub:`5`
> @@ -2773,6 +2789,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - r\ :sub:`7`
> - r\ :sub:`6`
> - r\ :sub:`5`
> @@ -2794,6 +2814,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`7`
> - b\ :sub:`6`
> - b\ :sub:`5`
> @@ -2815,6 +2839,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`7`
> - g\ :sub:`6`
> - g\ :sub:`5`
> @@ -2836,6 +2864,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`7`
> - g\ :sub:`6`
> - g\ :sub:`5`
> @@ -2857,6 +2889,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - r\ :sub:`7`
> - r\ :sub:`6`
> - r\ :sub:`5`
> @@ -2878,6 +2914,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`7`
> - b\ :sub:`6`
> - b\ :sub:`5`
> @@ -2899,6 +2939,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`7`
> - g\ :sub:`6`
> - g\ :sub:`5`
> @@ -2920,6 +2964,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`7`
> - g\ :sub:`6`
> - g\ :sub:`5`
> @@ -2941,6 +2989,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - r\ :sub:`7`
> - r\ :sub:`6`
> - r\ :sub:`5`
> @@ -2962,6 +3014,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - 0
> - 0
> - 0
> @@ -2981,6 +3037,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`7`
> - b\ :sub:`6`
> - b\ :sub:`5`
> @@ -3002,6 +3062,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`7`
> - b\ :sub:`6`
> - b\ :sub:`5`
> @@ -3021,6 +3085,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - 0
> - 0
> - 0
> @@ -3042,6 +3110,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`9`
> - b\ :sub:`8`
> - b\ :sub:`7`
> @@ -3061,6 +3133,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`1`
> - b\ :sub:`0`
> - 0
> @@ -3082,6 +3158,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`1`
> - b\ :sub:`0`
> - 0
> @@ -3101,6 +3181,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`9`
> - b\ :sub:`8`
> - b\ :sub:`7`
> @@ -3120,6 +3204,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`9`
> - b\ :sub:`8`
> - b\ :sub:`7`
> @@ -3141,6 +3229,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`9`
> - g\ :sub:`8`
> - g\ :sub:`7`
> @@ -3162,6 +3254,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`9`
> - g\ :sub:`8`
> - g\ :sub:`7`
> @@ -3183,6 +3279,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - r\ :sub:`9`
> - r\ :sub:`8`
> - r\ :sub:`7`
> @@ -3202,6 +3302,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`11`
> - b\ :sub:`10`
> - b\ :sub:`9`
> @@ -3223,6 +3327,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`11`
> - g\ :sub:`10`
> - g\ :sub:`9`
> @@ -3244,6 +3352,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`11`
> - g\ :sub:`10`
> - g\ :sub:`9`
> @@ -3265,6 +3377,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - r\ :sub:`11`
> - r\ :sub:`10`
> - r\ :sub:`9`
> @@ -3284,6 +3400,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`13`
> - b\ :sub:`12`
> - b\ :sub:`11`
> @@ -3305,6 +3425,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`13`
> - g\ :sub:`12`
> - g\ :sub:`11`
> @@ -3326,6 +3450,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`13`
> - g\ :sub:`12`
> - g\ :sub:`11`
> @@ -3347,6 +3475,10 @@ organization is given as an example for the first pixel only.
> -
> -
> -
> + -
> + -
> + -
> + -
> - r\ :sub:`13`
> - r\ :sub:`12`
> - r\ :sub:`11`
> @@ -3366,6 +3498,10 @@ organization is given as an example for the first pixel only.
> - MEDIA_BUS_FMT_SBGGR16_1X16
> - 0x301d
> -
> + -
> + -
> + -
> + -
> - b\ :sub:`15`
> - b\ :sub:`14`
> - b\ :sub:`13`
> @@ -3387,6 +3523,10 @@ organization is given as an example for the first pixel only.
> - MEDIA_BUS_FMT_SGBRG16_1X16
> - 0x301e
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`15`
> - g\ :sub:`14`
> - g\ :sub:`13`
> @@ -3408,6 +3548,10 @@ organization is given as an example for the first pixel only.
> - MEDIA_BUS_FMT_SGRBG16_1X16
> - 0x301f
> -
> + -
> + -
> + -
> + -
> - g\ :sub:`15`
> - g\ :sub:`14`
> - g\ :sub:`13`
> @@ -3429,6 +3573,110 @@ organization is given as an example for the first pixel only.
> - MEDIA_BUS_FMT_SRGGB16_1X16
> - 0x3020
> -
> + -
> + -
> + -
> + -
> + - r\ :sub:`15`
> + - r\ :sub:`14`
> + - r\ :sub:`13`
> + - r\ :sub:`12`
> + - r\ :sub:`11`
> + - r\ :sub:`10`
> + - r\ :sub:`9`
> + - r\ :sub:`8`
> + - r\ :sub:`7`
> + - r\ :sub:`6`
> + - r\ :sub:`5`
> + - r\ :sub:`4`
> + - r\ :sub:`3`
> + - r\ :sub:`2`
> + - r\ :sub:`1`
> + - r\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-SBGGR20-1X20:
> +
> + - MEDIA_BUS_FMT_SBGGR20_1X20
> + - 0x3021
> + -
> + - b\ :sub:`19`
> + - b\ :sub:`18`
> + - b\ :sub:`17`
> + - b\ :sub:`16`
> + - b\ :sub:`15`
> + - b\ :sub:`14`
> + - b\ :sub:`13`
> + - b\ :sub:`12`
> + - b\ :sub:`11`
> + - b\ :sub:`10`
> + - b\ :sub:`9`
> + - b\ :sub:`8`
> + - b\ :sub:`7`
> + - b\ :sub:`6`
> + - b\ :sub:`5`
> + - b\ :sub:`4`
> + - b\ :sub:`3`
> + - b\ :sub:`2`
> + - b\ :sub:`1`
> + - b\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-SGBRG20-1X20:
> +
> + - MEDIA_BUS_FMT_SGBRG20_1X20
> + - 0x3022
> + -
> + - g\ :sub:`19`
> + - g\ :sub:`18`
> + - g\ :sub:`17`
> + - g\ :sub:`16`
> + - g\ :sub:`15`
> + - g\ :sub:`14`
> + - g\ :sub:`13`
> + - g\ :sub:`12`
> + - g\ :sub:`11`
> + - g\ :sub:`10`
> + - g\ :sub:`9`
> + - g\ :sub:`8`
> + - g\ :sub:`7`
> + - g\ :sub:`6`
> + - g\ :sub:`5`
> + - g\ :sub:`4`
> + - g\ :sub:`3`
> + - g\ :sub:`2`
> + - g\ :sub:`1`
> + - g\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-SGRBG20-1X20:
> +
> + - MEDIA_BUS_FMT_SGRBG20_1X20
> + - 0x3023
> + -
> + - g\ :sub:`19`
> + - g\ :sub:`18`
> + - g\ :sub:`17`
> + - g\ :sub:`16`
> + - g\ :sub:`15`
> + - g\ :sub:`14`
> + - g\ :sub:`13`
> + - g\ :sub:`12`
> + - g\ :sub:`11`
> + - g\ :sub:`10`
> + - g\ :sub:`9`
> + - g\ :sub:`8`
> + - g\ :sub:`7`
> + - g\ :sub:`6`
> + - g\ :sub:`5`
> + - g\ :sub:`4`
> + - g\ :sub:`3`
> + - g\ :sub:`2`
> + - g\ :sub:`1`
> + - g\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-SRGGB20-1X20:
> +
> + - MEDIA_BUS_FMT_SRGGB20_1X20
> + - 0x3024
> + -
> + - r\ :sub:`19`
> + - r\ :sub:`18`
> + - r\ :sub:`17`
> + - r\ :sub:`16`
> - r\ :sub:`15`
> - r\ :sub:`14`
> - r\ :sub:`13`
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 49be328d9a3b..b6acf8c8e383 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -122,7 +122,7 @@
> #define MEDIA_BUS_FMT_YUV16_1X48 0x202a
> #define MEDIA_BUS_FMT_UYYVYY16_0_5X48 0x202b
>
> -/* Bayer - next is 0x3021 */
> +/* Bayer - next is 0x3025 */
> #define MEDIA_BUS_FMT_SBGGR8_1X8 0x3001
> #define MEDIA_BUS_FMT_SGBRG8_1X8 0x3013
> #define MEDIA_BUS_FMT_SGRBG8_1X8 0x3002
> @@ -155,6 +155,10 @@
> #define MEDIA_BUS_FMT_SGBRG16_1X16 0x301e
> #define MEDIA_BUS_FMT_SGRBG16_1X16 0x301f
> #define MEDIA_BUS_FMT_SRGGB16_1X16 0x3020
> +#define MEDIA_BUS_FMT_SBGGR20_1X20 0x3021
> +#define MEDIA_BUS_FMT_SGBRG20_1X20 0x3022
> +#define MEDIA_BUS_FMT_SGRBG20_1X20 0x3023
> +#define MEDIA_BUS_FMT_SRGGB20_1X20 0x3024
>
> /* JPEG compressed formats - next is 0x4002 */
> #define MEDIA_BUS_FMT_JPEG_1X8 0x4001
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-07-22 22:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 13:28 [PATCH v6 00/18] Add Arm Mali-C55 Image Signal Processor Driver Daniel Scally
2024-07-09 13:28 ` [PATCH v6 01/18] media: mc-entity: Record number of video devices in a pipeline Daniel Scally
2024-07-30 15:09 ` Laurent Pinchart
2024-07-30 15:18 ` Dan Scally
2024-07-09 13:28 ` [PATCH v6 02/18] media: uapi: Add MEDIA_BUS_FMT_RGB202020_1X60 format code Daniel Scally
2024-07-09 13:28 ` [PATCH v6 03/18] media: uapi: Add 20-bit bayer formats Daniel Scally
2024-07-22 22:13 ` Laurent Pinchart [this message]
2024-07-09 13:28 ` [PATCH v6 04/18] media: v4l2-common: Add RAW16 format info Daniel Scally
2024-07-09 13:28 ` [PATCH v6 05/18] media: v4l2-common: Add RAW14 " Daniel Scally
2024-07-22 22:14 ` Laurent Pinchart
2024-07-09 13:28 ` [PATCH v6 06/18] dt-bindings: media: Add bindings for ARM mali-c55 Daniel Scally
2024-07-09 13:28 ` [PATCH v6 08/18] media: Documentation: Add Mali-C55 ISP Documentation Daniel Scally
2024-07-30 15:15 ` Laurent Pinchart
2024-07-09 13:28 ` [PATCH v6 09/18] MAINTAINERS: Add entry for mali-c55 driver Daniel Scally
2024-07-09 13:28 ` [PATCH v6 10/18] media: Add MALI_C55_3A_STATS meta format Daniel Scally
2024-07-09 13:28 ` [PATCH v6 11/18] media: uapi: Add 3a stats buffer for mali-c55 Daniel Scally
2024-07-09 13:29 ` [PATCH v6 12/18] media: platform: Add mali-c55 3a stats devnode Daniel Scally
2024-07-22 14:50 ` Laurent Pinchart
2024-07-22 22:55 ` Laurent Pinchart
2024-08-13 13:13 ` Dan Scally
2024-08-25 20:20 ` Laurent Pinchart
2024-07-29 10:53 ` Dan Scally
2024-08-13 13:51 ` Dan Scally
2024-07-09 13:29 ` [PATCH v6 13/18] media: platform: Fill stats buffer on ISP_START Daniel Scally
2024-07-30 21:46 ` Laurent Pinchart
2024-07-09 13:29 ` [PATCH v6 14/18] Documentation: mali-c55: Add Statistics documentation Daniel Scally
2024-07-09 13:29 ` [PATCH v6 15/18] media: mali-c55: Add image formats for Mali-C55 parameters buffer Daniel Scally
2024-07-09 13:29 ` [PATCH v6 16/18] media: uapi: Add parameters structs to mali-c55-config.h Daniel Scally
2024-07-22 23:48 ` Laurent Pinchart
2024-07-29 10:51 ` Dan Scally
2024-07-29 11:03 ` Laurent Pinchart
2024-07-09 13:29 ` [PATCH v6 17/18] media: platform: Add mali-c55 parameters video node Daniel Scally
2024-07-30 22:16 ` Laurent Pinchart
2024-07-31 6:53 ` Jacopo Mondi
2024-07-31 7:02 ` Laurent Pinchart
2024-07-31 15:12 ` Dan Scally
2024-08-02 15:03 ` Laurent Pinchart
2024-07-09 13:29 ` [PATCH v6 18/18] Documentation: mali-c55: Document the mali-c55 parameter setting Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722221322.GA32300@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jerome.forissier@linaro.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nayden.kanchev@arm.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).