From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87C04C3DA49 for ; Tue, 23 Jul 2024 14:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1dyyT2Be+ESNPuhzVp45YiEJqdBaqkb+RIqQHluNssU=; b=f5iXrPoHrCH34beiLxvRgV5V3L wNBZ6WRLmXcDG/K7THkZbXUW0nP7erQTrGi7PZ2FKff0vjHOCc5UUeUyZQH/QL/19IZtdB94ytMOe mfy5BhQEqFwkXKTnoWFIAf7VBwZ8dzByYbS/Mkx1chnu3cv6AN0hdyqNZzNoMvt9nHLh/wINKdgEa OWHhGWTLVoJm9giSQX7zeOgWzj7mA0z9b7v8SgGptlyqrfiMS/QpAC6xeajGz7uXpBD+lefURajTH oJzSMZxGnXKbLkwMo0sFWa/ejeWqXwuSW5bEjFMqgRFt6ajeVJK27e80tMPZ1/hYctjX3wolGCzPq t+Gx1XQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWGcB-0000000CjeJ-0tOF; Tue, 23 Jul 2024 14:35:43 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWGbn-0000000CjZR-0ar9 for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2024 14:35:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 79DEA61231; Tue, 23 Jul 2024 14:35:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BF67C4AF0A; Tue, 23 Jul 2024 14:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721745318; bh=SIEX4jZxPLkLEdwNUU9kodfaZkbypEBKoyUOHUf9f6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VtqKJGB7nMmm0EexSy9baNwYb9FRqmQC2CjMotyOTmjI5Vz+cjC14OC8ANYAItDM2 9Rgey3t6jQiUABW6WUGo8Wl/BOAPvHcqBmvJdKHTV/XmNUcYiihbPUKC2rWK9WcYrD s8Ryv/ccXoUCZpvpL1yImSx70kgqsIYYDeKCoIrZ6Q7HvPttc6TH/pFIiM8dRBQbpF zeMDSB6yludRCUhCvuMuBuagpkCnE50T/uhsL98aaS65GB39aQRrlNtqEecdZ4kVJJ 7hDPHWwYYogkq0uABp2OMK4HIqdqfMWe2gTI8/PCMiNFkbkoVK+YrvSYcj0Vysvxks gxKUQlf2fsdFg== Date: Tue, 23 Jul 2024 15:35:11 +0100 From: Conor Dooley To: Frank Li Cc: Richard Zhu , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, l.stach@pengutronix.de, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v1 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint Message-ID: <20240723-spinning-wikipedia-525130c48dcd@spud> References: <1721634979-1726-1-git-send-email-hongxing.zhu@nxp.com> <1721634979-1726-2-git-send-email-hongxing.zhu@nxp.com> <20240722-displace-amusable-a884352e0ff9@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f4Ml/B5fxYMPddxi" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_073519_339222_CA9E2BE1 X-CRM114-Status: GOOD ( 25.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --f4Ml/B5fxYMPddxi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2024 at 04:47:29PM -0400, Frank Li wrote: > On Mon, Jul 22, 2024 at 05:37:14PM +0100, Conor Dooley wrote: > > On Mon, Jul 22, 2024 at 03:56:16PM +0800, Richard Zhu wrote: > > > Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint. > > >=20 > > > Signed-off-by: Richard Zhu > > > --- > > > .../devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13 +++++++++--= -- > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.= yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > > index a06f75df8458..309e8953dc91 100644 > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > > @@ -65,11 +65,13 @@ allOf: > > > then: > > > properties: > > > reg: > > > - minItems: 2 > > > - maxItems: 2 > > > + minItems: 4 > > > + maxItems: 4 > > > reg-names: > > > items: > > > - const: dbi > > > + - const: dbi2 > > > + - const: atu > >=20 > > New properties in the middle of the list is potentially an ABI break. > > Why not add them at the end? >=20 > Because it ref to snps,dw-pcie-ep.yaml, which already defined the reg > name orders. Are you sure that it defines an order for reg? If it did, it would not allow what you already have in this binding. The order is actually defined in this file. > we using reg-names to get reg resource, I don't think it break > the ABI. Driver already auto detect both 'dbi2' or no 'dbi2' case. Linux's might, another might not. I don't see any point in breaking the ABI when you can just put the entries at the end of he list and have no problems at all. Thanks, Conor. > > > - const: addr_space > > > =20 > > > - if: > > > @@ -129,8 +131,11 @@ examples: > > > =20 > > > pcie_ep: pcie-ep@33800000 { > > > compatible =3D "fsl,imx8mp-pcie-ep"; > > > - reg =3D <0x33800000 0x000400000>, <0x18000000 0x08000000>; > > > - reg-names =3D "dbi", "addr_space"; > > > + reg =3D <0x33800000 0x100000>, > > > + <0x33900000 0x100000>, > > > + <0x33b00000 0x100000>, > > > + <0x18000000 0x8000000>; > > > + reg-names =3D "dbi", "dbi2", "atu", "addr_space"; > > > clocks =3D <&clk IMX8MP_CLK_HSIO_ROOT>, > > > <&clk IMX8MP_CLK_HSIO_AXI>, > > > <&clk IMX8MP_CLK_PCIE_ROOT>; > > > --=20 > > > 2.37.1 > > >=20 >=20 >=20 --f4Ml/B5fxYMPddxi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZp+/nwAKCRB4tDGHoIJi 0o1yAP9Ri4U2xMei9m2+GEfjZXiikHHGvpUwLmes7Zt8FfQGUgEAw+oENNzcQbGV qT0hibbBrevG9+0vEZBZvrBDpf4H0wI= =PIZD -----END PGP SIGNATURE----- --f4Ml/B5fxYMPddxi--