From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73840C3DA70 for ; Tue, 23 Jul 2024 02:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eq3jfsojh9Ic4o/rYB8PVZmJo3xHtf43jxl6QqNYd6Y=; b=MdrFrZyF8nafUH16b1XUmqIQmO 44NyPUYpAVVHZobQD1SLd8gzfYaA3bDUKX4gWQoOTTSdb/NkoqW70ZhYzY0E5/GB8DltbXLouvILy bnG8LeANWVs52q0fGmrW3zf++IlEZneYJttMr1cGWI9g7XOZTiSt1Tqorq/eL5CxuDuFukQzAoEuR qD6UuZbYA/kYjwqrwGgUyRTqMncAISE4d8Q6IctjTZLBxrRh93tf8kiGvP81FSj3QBZQGQ0pJvqe1 uQEh1w+FXGqy0gKhuPvClJLaI5VSUhVHDlEP709G56qhab3NQg5n4qBgU1rL0G/PGtUi+3wKte+eN +93Z4LQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sW55x-0000000B7dZ-0gaa; Tue, 23 Jul 2024 02:17:41 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sW55Z-0000000B7Zf-3vMK for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2024 02:17:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6814360B55; Tue, 23 Jul 2024 02:17:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C68D9C116B1; Tue, 23 Jul 2024 02:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721701036; bh=gnkOYbEfx9zPzHePEL/WxD5v0iNAO66aAz2aJlnJpSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RxOuDL3mrORghbGY9jTuWQjgd2SP7GcjAZPVyjp3hU2M1TmgBi6NwPp8D9X5eUY/s FaQ0XUpyCBoHtPyz3lY2HoOUMew0FAxFxtLotpL5EqZXj+D+Fx/HQ4YQQd+FejrfEI Q9QT3y/Rdoy31gJeM1kqGRz1biqv/Lxy7q8mNEGCSlS9sivsTwN7lOpkoywP1llddd jtiuFux3oh+090v6KBkgxvS0y1ou+qfNYv8hED6vpiWHbs4/qb2qD2g0XdbkiQZIDY tKBvRxCBrN9e+2vQJ540AT1JpCsHiO6dQfhmuFnYxhSRyTj+ouGuc9cVSOIatcKgwi UxvT5COn+7daQ== Date: Mon, 22 Jul 2024 20:17:13 -0600 From: Rob Herring To: Claudiu Cc: lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Claudiu Beznea Subject: Re: [PATCH v2 01/11] dt-bindings: mfd: renesas,r9a08g045-vbattb: Document VBATTB Message-ID: <20240723021713.GA40385-robh@kernel.org> References: <20240716103025.1198495-1-claudiu.beznea.uj@bp.renesas.com> <20240716103025.1198495-2-claudiu.beznea.uj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716103025.1198495-2-claudiu.beznea.uj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_191718_138296_3856564F X-CRM114-Status: GOOD ( 24.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 01:30:15PM +0300, Claudiu wrote: > From: Claudiu Beznea > > The VBATTB IP of the Renesas RZ/G3S SoC controls the clock for RTC, > the tamper detector and a small general usage memory of 128B. Add > documentation for it. > > Signed-off-by: Claudiu Beznea > --- > > Changes in v2: > - changed file name and compatible > - updated title, description sections > - added clock controller part documentation and drop dedicated file > for it included in v1 > - used items to describe interrupts, interrupt-names, clocks, clock-names, > resets > - dropped node labels and status > - updated clock-names for clock controller to cope with the new > logic on detecting the necessity to setup bypass > > .../mfd/renesas,r9a08g045-vbattb.yaml | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/renesas,r9a08g045-vbattb.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/renesas,r9a08g045-vbattb.yaml b/Documentation/devicetree/bindings/mfd/renesas,r9a08g045-vbattb.yaml > new file mode 100644 > index 000000000000..30e4da65e2f6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/renesas,r9a08g045-vbattb.yaml > @@ -0,0 +1,136 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/renesas,r9a08g045-vbattb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas Battery Backup Function (VBATTB) > + > +description: > + Renesas VBATTB is an always on powered module (backed by battery) which > + controls the RTC clock (VBATTCLK), tamper detection logic and a small > + general usage memory (128B). > + > +maintainers: > + - Claudiu Beznea > + > +properties: > + compatible: > + const: renesas,r9a08g045-vbattb > + > + reg: > + maxItems: 1 > + > + ranges: true > + > + interrupts: > + items: > + - description: tamper detector interrupt > + > + interrupt-names: > + items: > + - const: tampdi Don't really need -names with only 1 entry. > + > + clocks: > + items: > + - description: VBATTB module clock > + > + clock-names: > + items: > + - const: bclk > + > + power-domains: > + maxItems: 1 > + > + resets: > + items: > + - description: VBATTB module reset > + > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 2 > + > +patternProperties: > + "^clock-controller@1c+$": > + type: object > + description: VBATTCLK clock > + > + properties: > + compatible: > + const: renesas,r9a08g045-vbattb-clk > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: input clock for VBATTCLK > + > + clock-names: > + description: | > + Use xin if connected to an external crystal oscillator. > + Use clkin if connected to an external hardware device generating the > + clock. > + enum: > + - xin > + - clkin > + > + '#clock-cells': > + const: 0 > + > + renesas,vbattb-load-nanofarads: > + description: load capacitance of the on board xtal > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 4000, 7000, 9000, 12500 ] > + > + required: > + - compatible > + - reg > + - clocks > + - clock-names > + - '#clock-cells' > + - renesas,vbattb-load-nanofarads > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - power-domains > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + vbattb@1005c000 { > + compatible = "renesas,r9a08g045-vbattb"; > + reg = <0x1005c000 0x1000>; > + ranges = <0 0 0x1005c000 0 0x1000>; > + interrupts = ; > + interrupt-names = "tampdi"; > + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>; > + clock-names = "bclk"; > + power-domains = <&cpg>; > + resets = <&cpg R9A08G045_VBAT_BRESETN>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + clock-controller@1c { > + compatible = "renesas,r9a08g045-vbattb-clk"; > + reg = <0 0x1c 0 0x10>; > + clocks = <&vbattb_xtal>; > + clock-names = "xin"; > + #clock-cells = <0>; > + renesas,vbattb-load-nanofarads = <12500>; > + }; Is this really a separate device? Doesn't really look like it. This can all be moved to the parent node. Rob