From: James Minor <jminor1@opensource.cirrus.com>
To: <shubhrajyoti.datta@amd.com>, <gregkh@linuxfoundation.org>
Cc: <patches@opensource.cirrus.com>, <jirislaby@kernel.org>,
<michal.simek@amd.com>, <linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"James Minor" <jminor1@opensource.cirrus.com>
Subject: [RFC PATCH] tty: xilinx_uartps: Fix break detection
Date: Tue, 23 Jul 2024 14:28:58 +0000 [thread overview]
Message-ID: <20240723142858.2905083-1-jminor1@opensource.cirrus.com> (raw)
Commit b8a6c3b3d465 ("tty: xilinx_uartps: Fix the ignore_status")
used read_status_mask to mask the isrstatus, even though the
commit appears to be fixing the application of the
ignore_status_mask. This has a side effect of clearing any
pending CDNS_UART_IXR_FRAMING bit, which in turn means that
cdns_uart_handle_rx break detection will only process framing
errors when parity is enabled (INPCK set via
cdns_uart_set_termios).
Fix this by removing the extra isrstatus masking with
read_status_mask, which still allows the ignore_status_mask to be
applied.
Fixes: b8a6c3b3d465 ("tty: xilinx_uartps: Fix the ignore_status")
Signed-off-by: James Minor <jminor1@opensource.cirrus.com>
---
The other alternative to this would be a straight revert of
b8a6c3b3d465, since read_status_mask and ignore_status_mask are
both applied in cnds_uart_handle_rx anyway. Let me know the
preference here and I will change accordingly.
drivers/tty/serial/xilinx_uartps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 2acfcea403ce..e9165ae3c2e8 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -485,7 +485,6 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
isrstatus &= ~CDNS_UART_IXR_TXEMPTY;
}
- isrstatus &= port->read_status_mask;
isrstatus &= ~port->ignore_status_mask;
/*
* Skip RX processing if RX is disabled as RXEMPTY will never be set
--
2.34.1
next reply other threads:[~2024-07-23 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 14:28 James Minor [this message]
2024-07-23 18:11 ` [RFC PATCH] tty: xilinx_uartps: Fix break detection Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723142858.2905083-1-jminor1@opensource.cirrus.com \
--to=jminor1@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=patches@opensource.cirrus.com \
--cc=shubhrajyoti.datta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox