From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95A94C3DA61 for ; Wed, 24 Jul 2024 13:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SjlS3KeN9meLLfSQsSaPi/f/kHzcBW78TFSUcPryCjM=; b=qqxzDJz9S3q2EHxz48Yzbr3GAJ +wdzbHjA6gGlH2ihieH//erYhzMO6vAILLEE0dkyKifJVei+ENp2lA5C2hZbgNtGshENeIpfeSar4 8NLy8P9WdQsF7meMqoGDjKT770N8xKWwSOW8y+69zIIXzzXdadHqhKI/nwonPThTIgHAhdAhZPmDh JWO+JB28CCA51AMTMk6AiCrbZ/RO2k2VmIOwEOPv7DUyfDQcVuBQ92Rv/S2kBH6+/t2CoIaFzT+kj pSYoUH8100Md6h4OZ+nJUaeqdNAAQkq9oaFhe21m4mwV43r43qOTlFAG6ny3q8UfpYjfH9I+8Q3q9 wVIuX+Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcLX-0000000FUhO-2Spg; Wed, 24 Jul 2024 13:47:59 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcL9-0000000FUcz-0oWb for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 13:47:36 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1fc569440e1so17108395ad.3 for ; Wed, 24 Jul 2024 06:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721828854; x=1722433654; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SjlS3KeN9meLLfSQsSaPi/f/kHzcBW78TFSUcPryCjM=; b=ol3xxgdKNfItAkW97krY+DeieZe1jlUCJgaytS9t6O7NUwmRti4D+5NeWN+ivSEWPc N4XnvNrokhvLHNVPL09XcFdGsScYCRh9tFYHqxGhHRcQ9h4UVQ+a8kWNk7UmkMdwx1Wa BkYxmnRUM7G/jVRGEblyNIc5GLSs8SoaEQvDKA9BeuxFZSwrr1+Ru/c5yArfudoHesFE +wJopAIRJ0ZzcpKwugan5tTEv6wrjAuRNx0DEswIsNAjB5vR/+UAKuAOZaa5PjjDWe4o JZd0lkWpvrcNxeiOM+atqV2UdL8TnEZQrt7wttpJ988x0G5Pm6EY12QrzCc7SW06HMZy 99cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721828854; x=1722433654; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SjlS3KeN9meLLfSQsSaPi/f/kHzcBW78TFSUcPryCjM=; b=AHvGUSRi6BzuBMLUZoQT8LBQn6qPJ6IO0iCHe31J7Ui8dw6Hrhr6KMWrtJuOMEH9HQ Q6W98wTBoHdcugdFGhw1/wDe41opH7O+1bUmpJnI7p7FyCKqws4O3yt0ZKiyCPQTW8MD IZ1Gtv1Oa7sXi0doeRiXhmYgcLLvhbMwqjOo4oyJbRbxIwO5L0CrpqUC9QwfQNDtXWJm FbShDU6vlLO0IRnI/4J8/XDwuTuhSsn5ST6346xF9iVVEbEvpv2GXSPQKX5MWfNm/lo2 YVcYnbUtpuG/3gagTKzBx9IdpWKHxWk3JoLaEw9K43a+uzusiQAlkOZJG8vwMMRsSXWA lOZw== X-Forwarded-Encrypted: i=1; AJvYcCV86Y4BTi16MhXmdfv5QKqiDyGGIIyxy4oRQBwiyyJARF53vPE1nT8Unf+C/29fJG6Lowg2LrXcPQIqSkMDhhT4gq/AWQuo/dr/Dr6AmSFj/+0+l+4= X-Gm-Message-State: AOJu0YzeVK2Zrd92piVQxjUUH3uLcbippBkn39ysrF4SDQ0VJrHHFhp0 vMxO8IVrSp+D3mq/7zhWY2G2dDj5wxnDn12auiFCztlGTYwmx5kpp2F5rpUOrQ== X-Google-Smtp-Source: AGHT+IGQ1pRozmQ8WsiHI1I3zmEDTN6hvlFln3KcelbKxSnwPg41LAbjogxZsXYR2+UZUvCxUcYACA== X-Received: by 2002:a17:903:244a:b0:1fc:2ee3:d45a with SMTP id d9443c01a7336-1fdd54f46f3mr24825785ad.8.1721828853831; Wed, 24 Jul 2024 06:47:33 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f44f4c4sm94151845ad.224.2024.07.24.06.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 06:47:33 -0700 (PDT) Date: Wed, 24 Jul 2024 19:17:21 +0530 From: Manivannan Sadhasivam To: Marek Vasut Cc: linux-pci@vger.kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Pali =?iso-8859-1?Q?Roh=E1r?= , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Nirmal Patel , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 05/15] PCI: dwc: Silence set affinity failed warning Message-ID: <20240724134721.GC3349@thinkpad> References: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> <20240723132958.41320-6-marek.vasut+renesas@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240723132958.41320-6-marek.vasut+renesas@mailbox.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_064735_315586_A66A4A89 X-CRM114-Status: GOOD ( 21.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 23, 2024 at 03:27:05PM +0200, Marek Vasut wrote: > Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset > and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without > printing "IRQ...: set affinity failed(-22)" warning. > > Remove .irq_set_affinity implementation which only return -EINVAL from this > controller driver. > > Signed-off-by: Marek Vasut Reviewed-by: Manivannan Sadhasivam - Mani > --- > Cc: "Krzysztof Wilczyński" > Cc: "Pali Rohár" > Cc: "Uwe Kleine-König" > Cc: Aleksandr Mishin > Cc: Anna-Maria Behnsen > Cc: Anup Patel > Cc: Bjorn Helgaas > Cc: Broadcom internal kernel review list > Cc: Daire McNamara > Cc: Damien Le Moal > Cc: Florian Fainelli > Cc: Hou Zhiqiang > Cc: Jianjun Wang > Cc: Jim Quinlan > Cc: Jingoo Han > Cc: Jisheng Zhang > Cc: Jon Hunter > Cc: Jonathan Derrick > Cc: Jonathan Hunter > Cc: Joyce Ooi > Cc: Karthikeyan Mitran > Cc: Kishon Vijay Abraham I > Cc: Koichiro Den > Cc: Lorenzo Pieralisi > Cc: Manivannan Sadhasivam > Cc: Marc Zyngier > Cc: Michal Simek > Cc: Nicolas Saenz Julienne > Cc: Niklas Cassel > Cc: Nipun Gupta > Cc: Nirmal Patel > Cc: Rob Herring > Cc: Ryder Lee > Cc: Shivamurthy Shastri > Cc: Siddharth Vadapalli > Cc: Thierry Reding > Cc: Thomas Gleixner > Cc: Thomas Petazzoni > Cc: Yoshihiro Shimoda > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-pci@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > --- > V4: - New patch > --- > drivers/pci/controller/dwc/pci-keystone.c | 7 ------- > drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++--------- > 2 files changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > index 52c6420ae2003..ce9d9e0a52609 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -189,12 +189,6 @@ static void ks_pcie_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) > (int)data->hwirq, msg->address_hi, msg->address_lo); > } > > -static int ks_pcie_msi_set_affinity(struct irq_data *irq_data, > - const struct cpumask *mask, bool force) > -{ > - return -EINVAL; > -} > - > static void ks_pcie_msi_mask(struct irq_data *data) > { > struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(data); > @@ -247,7 +241,6 @@ static struct irq_chip ks_pcie_msi_irq_chip = { > .name = "KEYSTONE-PCI-MSI", > .irq_ack = ks_pcie_msi_irq_ack, > .irq_compose_msi_msg = ks_pcie_compose_msi_msg, > - .irq_set_affinity = ks_pcie_msi_set_affinity, > .irq_mask = ks_pcie_msi_mask, > .irq_unmask = ks_pcie_msi_unmask, > }; > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index a0822d5371bc5..3e41865c72904 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -48,8 +48,9 @@ static struct irq_chip dw_pcie_msi_irq_chip = { > }; > > static struct msi_domain_info dw_pcie_msi_domain_info = { > - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI), > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX | > + MSI_FLAG_MULTI_PCI_MSI, > .chip = &dw_pcie_msi_irq_chip, > }; > > @@ -116,12 +117,6 @@ static void dw_pci_setup_msi_msg(struct irq_data *d, struct msi_msg *msg) > (int)d->hwirq, msg->address_hi, msg->address_lo); > } > > -static int dw_pci_msi_set_affinity(struct irq_data *d, > - const struct cpumask *mask, bool force) > -{ > - return -EINVAL; > -} > - > static void dw_pci_bottom_mask(struct irq_data *d) > { > struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(d); > @@ -177,7 +172,6 @@ static struct irq_chip dw_pci_msi_bottom_irq_chip = { > .name = "DWPCI-MSI", > .irq_ack = dw_pci_bottom_ack, > .irq_compose_msi_msg = dw_pci_setup_msi_msg, > - .irq_set_affinity = dw_pci_msi_set_affinity, > .irq_mask = dw_pci_bottom_mask, > .irq_unmask = dw_pci_bottom_unmask, > }; > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம்