From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4354C3DA63 for ; Wed, 24 Jul 2024 16:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uk6VvkGCsbeQVal54C7Yzy20X2Egh4+UujE84uvAe84=; b=OvH+UO+C4wA5CC0zWX9jJR60US dEEL3HFFpoHD2dGQMHvvXKYpP9Lqk9nB4QH+QmspGaraTz3e5scf5XXA1nZFOSv/KLBgcH0pL+ixd oOpLfRkVSsVW0s/LwMnzGBdF83OC0DprqyxcTV/IG8CwvQRrT9usTxZ8TbNtm7SBRpnj26+zXEMZ7 667TEBEfL5KpPK0XMFIxOX0RRy7Hhx0mCnvUoHtdvHZPzH39VAPf5xrsUYc5Z/RAX9SYg8WZzDlnQ zE0LD2/YPVW6u4Jz1jK6I7XBJDa/juaAA7b3hTIqIM0dUlP7TVN2qb85p7RI5xfkCx3tvmjLBKoJ6 NQpQma1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWeiQ-0000000FuE2-1ERq; Wed, 24 Jul 2024 16:19:46 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWei2-0000000Fu8A-1pqK for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 16:19:23 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1fd640a6454so17859525ad.3 for ; Wed, 24 Jul 2024 09:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721837961; x=1722442761; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=uk6VvkGCsbeQVal54C7Yzy20X2Egh4+UujE84uvAe84=; b=JdwxFBchL77rwBdYkRKTj3X6SdaUz6GeIog2u+NpNs/+GFCttsnfVcOa2X9NTyCGu+ jyQjIQN8iiojFJjGirzcgjKyM1FoZPwrGijDOSY+uJorAHcM+eTYrQAScU6ZNfZ9mYkS 6fXLxYNHGzdeS9KMJzf3DsX1L3BvCtviJzBFT3yaqcb3D4cQnvGG1h1yF74fn7EwX8KR lKlNQ6y40bosDRE57lCGyVV5X9Zr5BWeRezADZYnMEZNKShAZewLoHkgVQ3VtEziHx+o 391Qg47QJqBBWi1nLkZwt82d3V4eh+y8AzuD1wWZyKSyplMCNq3zWeEWttKQN4TZufcx C17g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721837961; x=1722442761; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uk6VvkGCsbeQVal54C7Yzy20X2Egh4+UujE84uvAe84=; b=Nc3q6Mo0MMQ0Gh3bR1c22H87HEfDy1kA7DNTylB2etFqoDs1v6ITlEfRtWu4CMJzC+ /JZhNC+trekCF7C1/zu/qyum9jYx/QErOFelNGFZrkJ6B7tySE5i0fDDpQFtXQEdyLgY /8ynfBG8ABYSP7butn3ClEByvbSWsoSZ4ToHUMq31yzLFqZy1Et4iaGJfoQJbmEIbpye 53y2Z7UEt0StITKwNecVdd25bmikKeJNqORg2mAkyzTd3g0JrcEihhXLerVxpexw2xsA 2K8BJxHTXVpAj2PDa7/g67GLA25wWAnY3nD5DDat8P0GpEiZJh23hIDEeolKpBEfqL0p DzpA== X-Forwarded-Encrypted: i=1; AJvYcCXX0yBOpGyugqa+ZuKnnWwoBswX7qyXRC3pz/M8Q/0TIHabLtz2z0ltbya/fJsAY78/ZIIlF1DI7xjGIW14o07hfT2rkOjHWnROFzgtyDu32eeUVxA= X-Gm-Message-State: AOJu0Yyj37AtvBIxIOQbRyCy8Bn0Y5XQg1YS0KP66haWGlNbcTdrojHn tEsL/HbKCTDSRnH+X/v8CBVOxiuhuz2vQDGGuveT3ceyG3g1keyq30yBXy6m6Q== X-Google-Smtp-Source: AGHT+IHIrTkDS2WCnTKJAArgrlpe4xhHZbFrE+hRGnbRw/giY7CXM7xCg5WsJLXv0yC3yxVxg2OLJA== X-Received: by 2002:a17:903:228d:b0:1fb:719a:28e2 with SMTP id d9443c01a7336-1fed387086fmr850095ad.21.1721837961184; Wed, 24 Jul 2024 09:19:21 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fdd4c62d9dsm18029785ad.159.2024.07.24.09.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 09:19:20 -0700 (PDT) Date: Wed, 24 Jul 2024 21:49:16 +0530 From: Manivannan Sadhasivam To: Siddharth Vadapalli Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, vigneshr@ti.com, kishon@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, ahalaney@redhat.com, srk@ti.com Subject: Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL Message-ID: <20240724161916.GG3349@thinkpad> References: <20240724065048.285838-1-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240724065048.285838-1-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_091922_501603_063BF1E0 X-CRM114-Status: GOOD ( 23.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 24, 2024 at 12:20:48PM +0530, Siddharth Vadapalli wrote: > Since the configuration of Legacy Interrupts (INTx) is not supported, set > the .map_irq and .swizzle_irq callbacks to NULL. This fixes the error: > of_irq_parse_pci: failed with rc=-22 > due to the absence of Legacy Interrupts in the device-tree. > Do you really need to set 'swizzle_irq' to NULL? pci_assign_irq() will bail out if 'map_irq' is set to NULL. - Mani > Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver") > Reported-by: Andrew Halaney > Signed-off-by: Siddharth Vadapalli > --- > > Hello, > > This patch is based on commit > 786c8248dbd3 Merge tag 'perf-tools-fixes-for-v6.11-2024-07-23' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools > of Mainline Linux. > > Patch has been tested on J784S4-EVM and J721e-EVM, both of which have > the PCIe Controller configured by the pci-j721e.c driver. > > Regards, > Siddharth. > > drivers/pci/controller/cadence/pci-j721e.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c > index 85718246016b..5372218849a8 100644 > --- a/drivers/pci/controller/cadence/pci-j721e.c > +++ b/drivers/pci/controller/cadence/pci-j721e.c > @@ -417,6 +417,10 @@ static int j721e_pcie_probe(struct platform_device *pdev) > if (!bridge) > return -ENOMEM; > > + /* Legacy interrupts are not supported */ > + bridge->map_irq = NULL; > + bridge->swizzle_irq = NULL; > + > if (!data->byte_access_allowed) > bridge->ops = &cdns_ti_pcie_host_ops; > rc = pci_host_bridge_priv(bridge); > -- > 2.40.1 > > -- மணிவண்ணன் சதாசிவம்