From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, vigneshr@ti.com, kishon@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
ahalaney@redhat.com, srk@ti.com
Subject: Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL
Date: Thu, 25 Jul 2024 09:50:01 +0530 [thread overview]
Message-ID: <20240725042001.GC2317@thinkpad> (raw)
In-Reply-To: <20240724161916.GG3349@thinkpad>
On Wed, Jul 24, 2024 at 09:49:21PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Jul 24, 2024 at 12:20:48PM +0530, Siddharth Vadapalli wrote:
> > Since the configuration of Legacy Interrupts (INTx) is not supported, set
> > the .map_irq and .swizzle_irq callbacks to NULL. This fixes the error:
> > of_irq_parse_pci: failed with rc=-22
> > due to the absence of Legacy Interrupts in the device-tree.
> >
>
> Do you really need to set 'swizzle_irq' to NULL? pci_assign_irq() will bail out
> if 'map_irq' is set to NULL.
>
Hold on. The errono of of_irq_parse_pci() is not -ENOENT. So the INTx interrupts
are described in DT? Then why are they not supported?
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-07-25 4:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 6:50 [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL Siddharth Vadapalli
2024-07-24 16:19 ` Manivannan Sadhasivam
2024-07-25 4:20 ` Manivannan Sadhasivam [this message]
2024-07-25 8:20 ` Siddharth Vadapalli
2024-07-26 11:56 ` Manivannan Sadhasivam
2024-08-05 16:01 ` Rob Herring
2024-08-05 16:45 ` Manivannan Sadhasivam
2024-08-05 19:05 ` Rob Herring
2024-08-05 20:40 ` Rob Herring
2024-08-08 20:56 ` Andrew Halaney
2024-08-09 5:33 ` Manivannan Sadhasivam
2024-07-25 5:20 ` Siddharth Vadapalli
2024-07-25 7:47 ` Manivannan Sadhasivam
2024-07-25 8:31 ` Siddharth Vadapalli
2024-07-26 10:24 ` Siddharth Vadapalli
2024-07-26 11:30 ` Manivannan Sadhasivam
2024-07-26 12:06 ` Siddharth Vadapalli
2024-07-24 16:23 ` Bjorn Helgaas
2024-07-25 5:53 ` Siddharth Vadapalli
2024-07-25 21:19 ` Bjorn Helgaas
2024-07-25 22:21 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725042001.GC2317@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=ahalaney@redhat.com \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).