From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 738D4C3DA49 for ; Thu, 25 Jul 2024 04:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4DmP3fxtSOwdi96Nd0UuEVePAIBxvlXMyWHucrA0W0k=; b=ye3Vw5ELT61vcvdJ1yqPjQLFhJ J0CNiD35kw1+ssOPG/hE3ZJpQo8JKXhpvtL//lNKXSyWGyVrpFKSJmxiRPDC8Pf9VHLyiIwGIt/m0 4bkPktPRdJE3TlAQYGoTRymljo0WKJu+d7z2F7s2kQ5/qWhELixeYAGfJLfA3F85MCByFFucyHO2M Z6ejr3eP/GfxN7chZmwTuwUQXebZBfx1lWfXyMuWsVnn05hTGlKdY809QIV6TQCfemloVbZOripcV sdAPmgZE4hnK4fP6rUoGARstSmh2zVMSnGfQTFJdYhlUuajn4jm6gTjg3yrPG2j+0rv2f6PmExX3Q l96VSYpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWpxv-0000000HKVz-1jk4; Thu, 25 Jul 2024 04:20:31 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWpxX-0000000HKOu-18WY for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 04:20:08 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-7a103ac7be3so327648a12.3 for ; Wed, 24 Jul 2024 21:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721881206; x=1722486006; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4DmP3fxtSOwdi96Nd0UuEVePAIBxvlXMyWHucrA0W0k=; b=PpJkrKkpM0OBysg/3No8+f2AQ9ubhX2NYYugbQQCmrNeASrBz+PdlJak/qCiEJ1wl8 qX+lOLeSBtee4mx4G9oxfBj22wc8HBG7yHXz8wwRfuITY+Z6rvxJ1YNSl8qXnSfTagd6 XRwgJ2D+JKibRVmiuX1H/rHtQPWm2glIxj2TRK/7TTmCGwro26G7INTO/Aw/2RM76PQ7 cL2P8wSeoV4upWeF59CDm7yUTSQS2xLyuLYlQISh1EiP634YiKBaU6+yDK04Qi62JVTr Id0lnG+ABXzbacas8b7rP6dmGnGApAA/YuC3vgQEa6APa3sI1PCSDlDbfCjAEdUciFFL j/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721881206; x=1722486006; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4DmP3fxtSOwdi96Nd0UuEVePAIBxvlXMyWHucrA0W0k=; b=mR+qBm7RgZGtpqhRDgNXde3sqm0N40tzdZfs5B/0aNbcwpH0ujmC9b0VfUQ0kd1m5n a6Hkb5BCLOYwiYG4WcoWNE/n3djbfyOEXezHQ9g3veuEYnEV6zPRmF+MUXHxYRLj7fcy rO1eycMhITceKmBQQK5ZI+pVYygbH9GiyogNW4a5axXAlWlbBzI67dsBBLEpXvjHVn1p 3GEURB7KhJ0mfBiYe4HMEgNfJWCKyQbrrvBgsn5bhccmI+7D2PUfYzJoC4y0DivcgY0t kgMK8GCkZtb/zA8jaunCowLhEElMTYpAFD6dJCtFTpT36Gi6n2cQy1UO1h9nJtpI0nkD flYA== X-Forwarded-Encrypted: i=1; AJvYcCUz5ty5aWZKEU9AM+If/xAdAUhWJkpMO4ooUTq35mTn+E1dll3BjEbPNR9O9b2HbRkn6v2SGxQe1RYWkwF+SKAu5h9DAO/6H50/yNWRQRoKNfHc3J8= X-Gm-Message-State: AOJu0Yz3BUGMSPMm7Gn6/CFRV2+j1z7/9SQwbSPU+UFPre9gb0T9wRLX FJ49BKdKFSqnUauw8Q+RZyaz030ZnXJYvfVro6UnyzsHhwboONc5xENKXSoAgw== X-Google-Smtp-Source: AGHT+IF9TZsz6K8Hhe8vA7NOEy3c5xlX4b0C9eOnbb45IRWGE/FRIYwhph7kpZbJ0Q9QImNE3lbUMQ== X-Received: by 2002:a05:6a21:6b0b:b0:1c3:ff89:1fc5 with SMTP id adf61e73a8af0-1c47b1db237mr641329637.30.1721881206605; Wed, 24 Jul 2024 21:20:06 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7c7f66esm3964335ad.15.2024.07.24.21.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 21:20:06 -0700 (PDT) Date: Thu, 25 Jul 2024 09:50:01 +0530 From: Manivannan Sadhasivam To: Siddharth Vadapalli Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, vigneshr@ti.com, kishon@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, ahalaney@redhat.com, srk@ti.com Subject: Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL Message-ID: <20240725042001.GC2317@thinkpad> References: <20240724065048.285838-1-s-vadapalli@ti.com> <20240724161916.GG3349@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240724161916.GG3349@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_212007_333213_DC62A52C X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 24, 2024 at 09:49:21PM +0530, Manivannan Sadhasivam wrote: > On Wed, Jul 24, 2024 at 12:20:48PM +0530, Siddharth Vadapalli wrote: > > Since the configuration of Legacy Interrupts (INTx) is not supported, set > > the .map_irq and .swizzle_irq callbacks to NULL. This fixes the error: > > of_irq_parse_pci: failed with rc=-22 > > due to the absence of Legacy Interrupts in the device-tree. > > > > Do you really need to set 'swizzle_irq' to NULL? pci_assign_irq() will bail out > if 'map_irq' is set to NULL. > Hold on. The errono of of_irq_parse_pci() is not -ENOENT. So the INTx interrupts are described in DT? Then why are they not supported? - Mani -- மணிவண்ணன் சதாசிவம்