From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D963C3DA49 for ; Thu, 25 Jul 2024 04:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lps+7wjUqBAaMZzAE44Gt34uJV/0AS3Ks07X8dKNdcM=; b=ieHe97mQ/0/0sWizFTcGRY21x3 F3Y1WY/gAn76EzeqtB/WRqvrUevzvyANyO374LnhIWegzNZyJTiT12Qtp9V8nYbbEFZOS3PWyY64o hWGWXaLljDANbF2Lk5lFU1UcF6vVBQr7Qju3K5qxCPjkgoxSPnUOz3ANtUiW0OOLz2U6mPPJZOIKL UK5L+TMd8rdyvWdUEkTBO3cfZNbQfp9EBwOwpeFyLEdaNXQgV+r7/gopzeofs8MLzGGKM6nlo2sN2 C5mTMU2JgZ62NjRMGvRL0J5GD40rCEpguCKHglTE72TnZ8tslq5IWmp/iDgC4D0xTc91md1rehIwB naR1psow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqGt-0000000HMxW-1Ekz; Thu, 25 Jul 2024 04:40:07 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqGU-0000000HMrm-1ODB for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 04:39:44 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-7a115c427f1so377111a12.0 for ; Wed, 24 Jul 2024 21:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721882381; x=1722487181; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=lps+7wjUqBAaMZzAE44Gt34uJV/0AS3Ks07X8dKNdcM=; b=HNn4Efxie9LB7RmEgnIxfONLOaNyrjdOzn3NSBDSkV8T6xlSXU4f9mQ8LnyqWnL3ie QhZKrPeo0xjx0bcfeFR3z6wCf+4dV+sTF8XCHNmFzmbYRIJUs9zmAicY0P5SwXEtOHo5 UBN7fcMAcMZNlM0vA6FA+pQKJOszvebCuxBzicPX3b2y6JseNYkmkq5DG0j+vAlFHNCE 2kP0yNz2xcImvhTcNhx6FanyF9mIZDcls+2OzB6GnQlDiE21GIEthIoUU4HSsM88Wb0/ 3Myu7P/jaQk+pz4atF6NQabNHDFW+qfFspMBM4x7ywImi5JElum4oA4qbK8z1lhShNlC +ARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721882381; x=1722487181; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lps+7wjUqBAaMZzAE44Gt34uJV/0AS3Ks07X8dKNdcM=; b=GE9dz5l2D6JsW/HmQ5L5tgqOfN8Z9K0DN7NU8vE0RNKz9tfDfe14uOF3NPYq3QFvMn Vl4gsLrF4wcHVHxLe0VSRmMaovy3jee53s4FB4ucu0ObRBTIorOzczI6obEIAESkn26J vVu/wrdYHdPhD76aS1UW/WyFSu2ORvqanEJejrbUyC4LmZ0o4nAq2xH2W2dprWW454hV kH+YWg6bw6r7zQenbEy9qQmnrKvVL7iWhIerQ+SxYUVIMf80u8+L4W7M4ZsDxlhWBPO+ Q/KocE0mYUICCIehmK+i8s+MbIH+kFg+4pg6bo9zTMripwjykSvrvN/N2xRHA7h/4mAT nyWQ== X-Forwarded-Encrypted: i=1; AJvYcCVKKJ4mUWHkbkBchbsDC/0DcdSh8NK7MGj+qm4OkX/R0WxSEQMrzfdNk40jbQnvdd3/Z7lIlBmhU84Idq4muIacVU2oh2Y6HxtrcRuspi1NEXtp4mQ= X-Gm-Message-State: AOJu0Yy/xTM72KESfJGqOdespAeoxasBJm8f/FIvlTxKOiXkCmn9dAEh HWcDk+rF1jQTPHNMCM85cZjp7VxsLav/+n808e62mK5vsrdEg96IgaKvT0bHZQ== X-Google-Smtp-Source: AGHT+IF/Bf11cCC8S+v4gyIAsbPKbW0UOrREoDtXpS8Wmqb1pIm0kiPvC8oaIUSChmKJ/lBJ/PxGPQ== X-Received: by 2002:a05:6a20:7f87:b0:1c3:b2da:cdff with SMTP id adf61e73a8af0-1c47aca9b47mr829084637.0.1721882381242; Wed, 24 Jul 2024 21:39:41 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7fb1accsm4078215ad.261.2024.07.24.21.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 21:39:40 -0700 (PDT) Date: Thu, 25 Jul 2024 10:09:35 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 05/12] PCI: brcmstb: Use swinit reset if available Message-ID: <20240725043935.GF2317@thinkpad> References: <20240716213131.6036-1-james.quinlan@broadcom.com> <20240716213131.6036-6-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240716213131.6036-6-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_213942_415963_488C7642 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 05:31:20PM -0400, Jim Quinlan wrote: > The 7712 SOC adds a software init reset device for the PCIe HW. > If found in the DT node, use it. > > Signed-off-by: Jim Quinlan > Reviewed-by: Stanimir Varbanov > Reviewed-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 92816d8d215a..4dc2ff7f3167 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -266,6 +266,7 @@ struct brcm_pcie { > struct reset_control *rescal; > struct reset_control *perst_reset; > struct reset_control *bridge; > + struct reset_control *swinit; Same comment as previous patch. > int num_memc; > u64 memc_size[PCIE_BRCM_MAX_MEMC]; > u32 hw_rev; > @@ -1633,12 +1634,27 @@ static int brcm_pcie_probe(struct platform_device *pdev) > if (IS_ERR(pcie->bridge)) > return PTR_ERR(pcie->bridge); > > + pcie->swinit = devm_reset_control_get_optional_exclusive(&pdev->dev, "swinit"); > + if (IS_ERR(pcie->swinit)) > + return PTR_ERR(pcie->swinit); > + > ret = clk_prepare_enable(pcie->clk); > if (ret) { > dev_err(&pdev->dev, "could not enable clock\n"); > return ret; > } > > + ret = reset_control_assert(pcie->swinit); > + if (ret) { > + dev_err_probe(&pdev->dev, ret, "could not assert reset 'swinit'\n"); > + goto clk_out; > + } No delay required? - Mani -- மணிவண்ணன் சதாசிவம்