From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0847FC3DA5D for ; Thu, 25 Jul 2024 04:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fuLrTOMZXwDvrh3Gcss0q0VIdIl/tmC7R+/hGCD5mQk=; b=1xu75AACFazb+39l7Yl/ZLOuJ1 Lt4QVrNafHrj6hBTl4SoLpDmtQvyWtKfL4rXst2NK8vQr2VQgOIrERVbuwo7jzNnKBrLT4TxpK/kF vxnWpweeF8TijAcvzTGAZgDgs2xg1nYMWt5Ra0CE5g6IJ3lwobV6Kk6EOwmZP3hWGxEr2VFu+vPPT 8L787uuD6EVnzFF7h0E6kiBU9FkDYA6UGclVy/dcltG59AATfCQd4mW4PXyoEz1OmyV7QzNrJa3KW 2ZAkk5VdLRLxCTFf8Lksq6DxcD02pH4bp5qOGiNMLRzpaCtYaZsEdghmWPQEWoh4feywlStshaai5 25SAIB3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqPE-0000000HNue-39Mp; Thu, 25 Jul 2024 04:48:44 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqOq-0000000HNqm-1blq for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 04:48:22 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-70eae5896bcso173117b3a.2 for ; Wed, 24 Jul 2024 21:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721882899; x=1722487699; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fuLrTOMZXwDvrh3Gcss0q0VIdIl/tmC7R+/hGCD5mQk=; b=imfyu00PDiTiJh+MCquFoOPVGMR5e+JBLX8x8mW8LqHCu25f1roOyVUlnLU0tqBRLZ J1JQb0cCr+m7cqmXbBQCr6l5/ZZc6TuoY3xuhgGDA9LPAIkQjqms7Ik1oiHxdlGobbdr g0Q0eyb7mmQe1453g3YDj4zVOCnxk8k5XVHhgkYAm+YLeSS6yvQiXGcQv6wKk3O0mIpZ Pv83EL2Msi8n8BzeDqSouh0pwHFh99wVfePSou0CPD6vFaXQbX+g00XpXC8URkrzTu5H Ur7O4DUARI8W8q/5f8L3Ad6UbG93w9AS36caM/3erjYcLc+hMqyuC9qsTfXLJblUQS6j aqUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721882899; x=1722487699; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fuLrTOMZXwDvrh3Gcss0q0VIdIl/tmC7R+/hGCD5mQk=; b=UNpDv762LFxU+Nneo/VvJVl1gmQrhnXQBT5Yfyybm/0oVlIPDtOkOTRV1Ca9jla+1W VD75lwfJc4Wdj2pd7WGIlePux2xV0miX5pY+x8XVpR/veXPa3GcFJqg3wLoYk8yufzOo ZfJa5k/CI/IK6prdXu6d9PRdTwIEFvD0vIjFUUHxmuu725fg1SsRi3QgPHUDWvnuvSpr OWN6RvoUUd75GnMS6u17gapg7lVeU4roNqKa4viKvP5nSeiFW+E/M0qpNX5aer6VL6c4 43exsAZqqO2WnzAaE4ZQbOxv+QnCSWqQK4T8nbeyQwHFNLuEXbyhDVk87uX7GxjUQ2qJ qG7g== X-Forwarded-Encrypted: i=1; AJvYcCUp6p9hjkzO9Nd2KpFr+qkWo9ZY0Izlu8hTAk4vrnjbMMwmb3sZLeVAwmo4r7QjpzX/Gp1F5UYpZZ7iHR/vVDWUBsmxcsL21XT1xT73es52Zwvc6Zc= X-Gm-Message-State: AOJu0Yyo5x6g1fL0y6QXfFNaOEJudCQTWqDTAcG5gpjfM90gTOMnaXs5 4vPZCmoLQfVJ53WbbLlD7objpW85MZsiAu3cAXCLQDypk63PZTeAhNTkaOWBnw== X-Google-Smtp-Source: AGHT+IEWwStak5o3MjRefRdeyCr2slwkGT9/t8cXU3b6WSdv7rBu11QlEfyQkbgSO9bxXTIKVaFdDg== X-Received: by 2002:a05:6a20:72ac:b0:1c0:f594:198c with SMTP id adf61e73a8af0-1c4728035d3mr2753100637.11.1721882899113; Wed, 24 Jul 2024 21:48:19 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cf28e62e6fsm505267a91.57.2024.07.24.21.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 21:48:18 -0700 (PDT) Date: Thu, 25 Jul 2024 10:18:12 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 08/12] PCI: brcmstb: Don't conflate the reset rescal with phy ctrl Message-ID: <20240725044812.GI2317@thinkpad> References: <20240716213131.6036-1-james.quinlan@broadcom.com> <20240716213131.6036-9-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240716213131.6036-9-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_214820_447358_265CCDDF X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 05:31:23PM -0400, Jim Quinlan wrote: > We've been assuming that if an SOC has a "rescal" reset controller that we > should automatically invoke brcm_phy_cntl(...). This will not be true in > future SOCs, so we create a bool "has_phy" and adjust the cfg_data > appropriately (we need to give 7216 its own cfg_data structure instead of > sharing one). > In all commit messages, use imperative tone as per kernel documentation: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." > Signed-off-by: Jim Quinlan > Reviewed-by: Stanimir Varbanov > Reviewed-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index dfb404748ad8..8ab5a8ca05b4 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -222,6 +222,7 @@ enum pcie_type { > struct pcie_cfg_data { > const int *offsets; > const enum pcie_type type; > + const bool has_phy; 'has_phy' means the controller supports PHY and the new SoC doesn't have a PHY for the controller? - Mani -- மணிவண்ணன் சதாசிவம்