From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A771AC3DA5D for ; Thu, 25 Jul 2024 05:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A5dcA9JBHUbgUtUGlvPZ+d1i2R/fvuDGRFExDVQlZWo=; b=DwZWRiBcVbcTxN4mbQaQgYRdcY uzVGR+QjAw4dc8+4DVRX1lrvJds/Pndkhl543GEUJURlsqzv3IYbAZIdVEc1pij+zxpME9CAMCt9w W3GFgJW5YGuZw2HW1m3LZTh4fGb6GjQ4CCE9FaEXpH3A9DH1Jrg/PO+qJuHBY3RrPzAgtr5cEpI7Q s4yjdq4w78WBXATLH0vWOkM+HFkI/iMUX0jmWfhulEqJvZikGnxXIgt+zFtcTWz7sBNVB7RbpbX8P gbf18nQB9UbCYpRz0n6pKkRKtAfl6VTRtaiGv/IysZjWtAKGRzeuGKYRo+uhvvx469YQt6Lj7ZR6W B0YpE0Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqa9-0000000HPNu-3fAK; Thu, 25 Jul 2024 05:00:01 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqZi-0000000HPGo-3KOk for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 04:59:37 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7a0e8b76813so352899a12.3 for ; Wed, 24 Jul 2024 21:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721883574; x=1722488374; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=A5dcA9JBHUbgUtUGlvPZ+d1i2R/fvuDGRFExDVQlZWo=; b=sUH/4jaEvEUMMfhjusGeIyg6zyOvWGwSwhVDuQblNUgW7LTGOeRko8M+56vrM2VuU7 d2SLN1hR8g/VN90OkaFHgTo0sVfm0SyDOPa6FgB+lMQ8pHvd8WW+tUGstlXeQBXT5Z8K rZczvWPfM93mtVIVjOzsIGb19KKtpR8t3qPtw9k4llKsZCDtPnuz123QYqXFU9bj07AZ oAAqwKJ30GAKT9pVpYlKKEZnoB3EoX9Gcs50aKnXyMKVC3de7dCYXGEZfJm70YbWiwf4 nB1Dv+rJNQO7H0Ou6Xl1WFWUynm/fvHNryTQ/SEHM0/WxHf3RVkNvJTVGo63ue03Xon6 E7fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721883574; x=1722488374; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A5dcA9JBHUbgUtUGlvPZ+d1i2R/fvuDGRFExDVQlZWo=; b=K+rVbz4AOWZWIziuKHZ526QAKni25xqbGYpLQtzorDLFyHIK+KTeKmtQCelG66b8gg x6vXUzr5RS6eCXaItIHoEUOkt1nquaodtf/MCgXbryx0D8GTQ0T//KjddPVCLI5oOJWB GU/TChcvHOCx74ONFtAsFuf+PVrU1S4dU+DMv8itpRQoYs7JJl4atR1AOmcb9N7ADcEo 0Wa+3owNAPZe9m/DlHJxorslGcb9fkygDlTCl6FPGYr5BBdmDtoTBxoilyem4ZOChoTo tNIP1o/mWlrl33QQpwPW+5bp9U2/Z2VD70JnktblWGNFMCvQTCXUNOTWDywmqKFSn+Oi OfQQ== X-Forwarded-Encrypted: i=1; AJvYcCW5Tttq0HDQwMx6+OGzc3jgy1i0k16ZtRTrGelte3Pe61apyODg4erV39amRTdbkagnNOrvzaHt3129U+vWkCDN8OjQ6uqrDWLBrkpUVGnYclP++m0= X-Gm-Message-State: AOJu0Yw/1jsADllZzZntJKzhozahb1Cz8TZdyECOiWoIF9jS/gqHA/66 h0cJOyYm4bQiQhZZ1cLNMomuQbzKETc3cA/LZUjmumoBFdBvRrSvsXKekqhW7A== X-Google-Smtp-Source: AGHT+IGMEfl9npbHWomGeCCHNpA8vlU7101iyR/8qjyjEaFN2MiYxoZZQdRxZ22z7VT+wFZkyHbdoA== X-Received: by 2002:a17:903:2349:b0:1fb:8890:16b4 with SMTP id d9443c01a7336-1fed933a089mr8658505ad.48.1721883573726; Wed, 24 Jul 2024 21:59:33 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7f9e8fcsm4398215ad.249.2024.07.24.21.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 21:59:33 -0700 (PDT) Date: Thu, 25 Jul 2024 10:29:28 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 12/12] PCI: brcmstb: Enable 7712 SOCs Message-ID: <20240725045928.GL2317@thinkpad> References: <20240716213131.6036-1-james.quinlan@broadcom.com> <20240716213131.6036-13-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240716213131.6036-13-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_215934_884981_6122CA6B X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 05:31:27PM -0400, Jim Quinlan wrote: > The Broadcom STB 7712 is the sibling chip of the RPi 5 (2712). > Could you please add more info about this SoC? What PCIe Gen it supports, lanes, IP revision etc... - Mani > Signed-off-by: Jim Quinlan > Reviewed-by: Stanimir Varbanov > Reviewed-by: Florian Fainelli > Tested-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index fa5616a56383..7debb3599789 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -1193,6 +1193,10 @@ static void brcm_extend_rbus_timeout(struct brcm_pcie *pcie) > const unsigned int REG_OFFSET = PCIE_RGR1_SW_INIT_1(pcie) - 8; > u32 timeout_us = 4000000; /* 4 seconds, our setting for L1SS */ > > + /* 7712 does not have this (RGR1) timer */ > + if (pcie->model == BCM7712) > + return; > + > /* Each unit in timeout register is 1/216,000,000 seconds */ > writel(216 * timeout_us, pcie->base + REG_OFFSET); > } > @@ -1664,6 +1668,13 @@ static const int pcie_offsets_bmips_7425[] = { > [PCIE_INTR2_CPU_BASE] = 0x4300, > }; > > +static const int pcie_offset_bcm7712[] = { > + [EXT_CFG_INDEX] = 0x9000, > + [EXT_CFG_DATA] = 0x9004, > + [PCIE_HARD_DEBUG] = 0x4304, > + [PCIE_INTR2_CPU_BASE] = 0x4400, > +}; > + > static const struct pcie_cfg_data generic_cfg = { > .offsets = pcie_offsets, > .model = GENERIC, > @@ -1729,6 +1740,14 @@ static const struct pcie_cfg_data bcm7216_cfg = { > .num_inbound = 3, > }; > > +static const struct pcie_cfg_data bcm7712_cfg = { > + .offsets = pcie_offset_bcm7712, > + .perst_set = brcm_pcie_perst_set_7278, > + .bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic, > + .model = BCM7712, > + .num_inbound = 10, > +}; > + > static const struct of_device_id brcm_pcie_match[] = { > { .compatible = "brcm,bcm2711-pcie", .data = &bcm2711_cfg }, > { .compatible = "brcm,bcm4908-pcie", .data = &bcm4908_cfg }, > @@ -1738,6 +1757,7 @@ static const struct of_device_id brcm_pcie_match[] = { > { .compatible = "brcm,bcm7445-pcie", .data = &generic_cfg }, > { .compatible = "brcm,bcm7435-pcie", .data = &bcm7435_cfg }, > { .compatible = "brcm,bcm7425-pcie", .data = &bcm7425_cfg }, > + { .compatible = "brcm,bcm7712-pcie", .data = &bcm7712_cfg }, > {}, > }; > > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்