From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53597C3DA49 for ; Thu, 25 Jul 2024 05:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WSFwKnfVczR16WD5Y3nfX2f2/Inf3FOYKXgV2SNCco4=; b=Rb48dG/21QZLxMlN5stywUvo3X GsQ/rTBCdP8GfSpHdmVcFPqV8Vx5z+R0mM6FnC5Egf/tHK5ECIPDvltDG3Yy7uLcjL1wRDrlxqhNC J8ZMwk/6l6VFVUkWmK9cO+uRqeMJfD5T5Hx+OFgbL4UF8ID56nXn7rdkyx6IOMx5keWG71dXcmcWN jr3cYV3EifVTHXgrV5rcH4zH0YqmTDp2XHVdAMTkxHEB5evPM0ngXjcuxCYRg3CIj3ZTP7N+rn6ms r/AtjC8ZstfdFCm9mACRidF1ZeQQsWGPy9IC3XyC3nJnziH14bPSLEjtpJZFqwOIKB3z05V3u9kBc tR3JM5Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqdr-0000000HPvN-2LYB; Thu, 25 Jul 2024 05:03:51 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWqdR-0000000HPoq-3bNs for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 05:03:28 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-7a263f6439eso319686a12.3 for ; Wed, 24 Jul 2024 22:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721883805; x=1722488605; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WSFwKnfVczR16WD5Y3nfX2f2/Inf3FOYKXgV2SNCco4=; b=JYft1y/F5GiiDn9bzYbDyeVabgje2PxD5wvMr4vRKwjHndb/P21tztWg5C4rshIAGz xUU05mBGrnZG49VHlRltYvnKAuEH65AP0M5BH+ESQOpkQvpWnuB1SlHc08IwZ/ZHAzbY e3Np9PhJcq5IScMuyRVKPIJA7QbNFc5voCCi3mBTrtr51IPA+U4gAS1sioc5z2Zm5d2z 7GgsigmqAjiQuhzx89qHYuq+QZPoGpiiI9/J0MwXXQbLJzmtt8nkZyHLjt5D79DM+Qrd C6hgdAS00xEWwEE87wHXxeoUKgagAwgye4S635Bde2GiJ2qvwKwfYen+aWU/J73FK8sS lj6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721883805; x=1722488605; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WSFwKnfVczR16WD5Y3nfX2f2/Inf3FOYKXgV2SNCco4=; b=p9N+0AncZrfzCZa2ikQ4oej6IXeV1jnsrD7ElCg7KL16Basodj9x0OqQGy7B6yC/+p k7Tn7OXr5t9oaN40++XaqusKLtFYV0pLADxC5hR+uim0V2/XJQubRdVkWYe+4hnJ4ZzS Kjm/mpWQ7YJnYEpHfuEsJeRCvmmw/TGCCaUM/hDb+mPXsobByWRr4/z5t25Oqzigt+yF 1JxjxU8ZCzdMT6jbZbsnOQerHUFAGzl30s6xjMC+0ulWF+Kcz3Xdgn9ZyQBAoKrHnfz/ XCsPQlRUiGNwQbO5EcFukI2K2NnENuUEAUeHfzFMa/DvglDROcJwbTU9L9wX9OPGjHfM MQJQ== X-Forwarded-Encrypted: i=1; AJvYcCWQXVbMrkhOb7qomkqurlTc+ts5IMZnjgXznwaK/GoBwF5miK/yv+aYukwMzLdYb0uAQjSwP1/xYBCjQEC2rJpoMI5s8E0nPpmRvpD/T+woCemivj4= X-Gm-Message-State: AOJu0YwHwpHY0x8yUGxFeVAtQIK4UdkjpwhPYHw2UBInAiRJ0MlRjjEX HHsi1S8Wu5C+h744hIHBvskiHhcubw8lI6WMI/33CXuYhql7f+12qtfsqLP0jg== X-Google-Smtp-Source: AGHT+IHUkqheWrPFgpUPoQDkhuPNo5ceh34Gz+2v4tjh+WIsehsAtjMWtZX+TlgSdAsBTKwMuQC1JQ== X-Received: by 2002:a05:6a20:b292:b0:1c0:e69f:f237 with SMTP id adf61e73a8af0-1c47b25a048mr559272637.21.1721883804913; Wed, 24 Jul 2024 22:03:24 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cf28c7fe33sm551503a91.13.2024.07.24.22.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 22:03:24 -0700 (PDT) Date: Thu, 25 Jul 2024 10:33:19 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring Subject: Re: [PATCH v4 00/12] PCI: brcnstb: Enable STB 7712 SOC Message-ID: <20240725050319.GM2317@thinkpad> References: <20240716213131.6036-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240716213131.6036-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_220325_973070_B61F1926 X-CRM114-Status: GOOD ( 29.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 05:31:15PM -0400, Jim Quinlan wrote: > V4 Changes: > o Commit "Check return value of all reset_control_xxx calls" > -- Blank line before "return" (Stan) > o Commit "Use common error handling code in brcmstb_probe()" > -- Drop the "Fixes" tag (Stan) > o Commit "dt-bindings: PCI ..." > -- Separate the main commit into two: cleanup and adding the > 7712 SoC (Krzysztof) > -- Fold maintainer change commit into cleanup change (Krzysztof) > -- Use minItems/maxItems where appropriate (Krzysztof) > -- Consistent order of resets/reset-names in decl and usage > (Krzysztof) > Rpi mailing list owners: Could you please make the list 'unmoderated'? I haven't subscribe to this list, so I just keep getting the 'Your message to linux-rpi-kernel awaits moderator approval' for every review comment I post, which is a spam to me. Also I won't subscribe to this list unless I work on Rpi. So using moderated list in LKML is just spamming the reviewers. - Mani > V3 Changes: > o Commit "Enable 7712 SOCs" > -- Move "model" check from outside to inside func (Stan) > o Commit "Check return value of all reset_control_xxx calls" > -- Propagate errors up the chain instead of ignoring them (Stan) > o Commit "Refactor for chips with many regular inbound BARs" > -- Nine suggestions given, nine implemented (Stan) > o Commit "Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific" > -- Drop tab, add parens around macro params in expression (Stan) > o Commit "Use swinit reset if available" > -- Treat swinit the same as other reset controllers (Stan) > Stan suggested to use dev_err_probe() for getting resources > but I will defer that to future series (if that's okay). > o Commit "Get resource before we start asserting resets" > -- Squash this with previous commit (Stan) > o Commit "Use "clk_out" error path label" > -- Move clk_prepare_enable() after getting resouurces (Stan) > -- Change subject to "Use more common error handling code in > brcm_pcie_probe()" (Markus) > -- Use imperative commit description (Markus) > -- "Fixes:" tag added for missing error return. (Markus) > o Commit "dt-bindings: PCI ..." > -- Split off maintainer change in separate commit. > -- Tried to accomodate Krzysztof's requests, I'm not sure I > have succeeded. Krzysztof, please see [1] below. > > [1] Wrt the YAML of brcmstb PCIe resets, here is what I am trying > to describe: > > CHIP NUM_RESETS NAMES > ==== ========== ===== > 4908 1 perst > 7216 1 rescal > 7712 3 rescal, bridge, swinit > Others 0 - > > > V2 Changes (note: four new commits): > o Commit "dt-bindings: PCI ..." > -- s/Adds/Add/, fix spelling error (Bjorn) > -- Order compatible strings alphabetically (Krzysztof) > -- Give definitions first then rules (Krzysztof) > -- Add reason for change in maintainer (Krzysztof) > o Commit "Use swinit reset if available" > -- no need for "else" clause (Philipp) > -- fix improper use of dev_err_probe() (Philipp) > o Commit "Use "clk_out" error path label" > -- Improve commit message (Bjorn) > o Commit "PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific" > -- Improve commit subject line (Bjorn) > o Commit (NEW) -- Change field name from 'type' to 'model' > -- Added as requested (Stanimir) > o Commit (NEW) -- Check return value of all reset_control_xxx calls > -- Added as requested (Stanimir) > o Commit (NEW) "Get resource before we start asserting reset controllers" > -- Added as requested (Stanimir) > o Commit (NEW) -- "Remove two unused constants from driver" > > > V1: > This submission is for the Broadcom STB 7712, sibling SOC of the RPi5 chip. > Stanimir has already submitted a patch "Add PCIe support for bcm2712" for > the RPi version of the SOC. It is hoped that Stanimir will allow us to > submit this series first and subsequently rebase his patch(es). > > The largest commit, "Refactor for chips with many regular inbound BARs" > affects both the STB and RPi SOCs. It allows for multiple inbound ranges > where previously only one was effectively used. This feature will also > be present in future STB chips, as well as Broadcom's Cable Modem group. > > Jim Quinlan (12): > dt-bindings: PCI: Cleanup of brcmstb YAML and add 7712 SoC > dt-bindings: PCI: brcmstb: Add 7712 SoC description > PCI: brcmstb: Use common error handling code in brcm_pcie_probe() > PCI: brcmstb: Use bridge reset if available > PCI: brcmstb: Use swinit reset if available > PCI: brcmstb: PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets > SoC-specific > PCI: brcmstb: Remove two unused constants from driver > PCI: brcmstb: Don't conflate the reset rescal with phy ctrl > PCI: brcmstb: Refactor for chips with many regular inbound BARs > PCI: brcmstb: Check return value of all reset_control_xxx calls > PCI: brcmstb: Change field name from 'type' to 'model' > PCI: brcmstb: Enable 7712 SOCs > > .../bindings/pci/brcm,stb-pcie.yaml | 50 +- > drivers/pci/controller/pcie-brcmstb.c | 485 +++++++++++++----- > 2 files changed, 400 insertions(+), 135 deletions(-) > > > base-commit: 55027e689933ba2e64f3d245fb1ff185b3e7fc81 > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்