From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F375CC3DA5D for ; Thu, 25 Jul 2024 21:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=3RRdHLudqgV69CtMB2lGqSNV4cTYgxV43P/TXHlYQvw=; b=qdVBoxcZUwTUDj ZW41VsSvDekAnEZu0N40bLJBD/+G3nZAMHbIqd3y+2/6vw2q1Wmoww4n6weYbfJFti/2JFiIkT3fb UnbdWLt40iJnOp1bWRyv3rZMOFmAOzuEkAQ7rb2KZ7BLDa9s621nV9dLbyf89exvYGhNgJZFo5xT9 x4qMwsfAW/Qo3Tky/ecLIWLYvW06ori61VmRRxlUJ1mhYDhKSBv5+y4smVXKMRD7uSjgOget+LGqG xvaE8Wohm0lsiJPw/Azu+Ezu4jK6S/NNpbadGywVSlSpvFpXP8NY+xd9mtOfdv10uCuOy8AyYRSJy tbvxxeShH6XBgqvbNmfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sX5sh-000000029zR-0baV; Thu, 25 Jul 2024 21:20:11 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sX5sI-000000029tc-0EB9 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 21:19:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 33AF3CE1685; Thu, 25 Jul 2024 21:19:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FE71C116B1; Thu, 25 Jul 2024 21:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721942383; bh=4sRlyc9TAiWNwMx8udh+t85YIZuWizvHF8I605Y+otI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=cQNdFat81C9R5idXilDUFZOWeYcVwSyKi+bUw0J8nnfSw1rrKYKTfv3TQHc3o1r2U vXp8RK8jKbeAK55GkBIgW0CGDDz/nWDNRQh7QOMRI5EGO16vfDAh+41gcIfzPbM7L5 pwHShrOOquJ/A9zx5Da0yCNJVZ4e1Xkl6ZG4qPJPix1EOiuv/8JwmubEcILicZ0Wb3 C3DaGtfdV4HUaxxZt5JZ3WV98h3jKp4dG0edTrqMJMr6CKgPHXcP5L8XOZyxCRabi+ XvGqyumrTP6W6NGqZFvgPLTQ1FQio+LeK19jsgdVCmGvwBqMn6w/oxS3tcir61kz/y gKWb1kRIQAYcQ== Date: Thu, 25 Jul 2024 16:19:41 -0500 From: Bjorn Helgaas To: Siddharth Vadapalli Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, vigneshr@ti.com, kishon@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, ahalaney@redhat.com, srk@ti.com Subject: Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL Message-ID: <20240725211941.GA860190@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240725_141946_290315_CF0A7FD1 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 25, 2024 at 11:23:43AM +0530, Siddharth Vadapalli wrote: > On Wed, Jul 24, 2024 at 11:23:04AM -0500, Bjorn Helgaas wrote: > > Subject should say something about why this change is needed, not just > > translate the C code to English. > > My intent was to summarize the change to make it easy for anyone to find > out what's being done. The commit message below explains in detail as to > why they are set to NULL. As an alternative, I could change the $subject > to: > PCI: j721e: Disable INTx mapping and swizzling > where the "Disable" is equivalent to NULL. Kindly let me know if this is > acceptable or needs to be improved further. Sounds fine to me.