From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 800CCC3DA49 for ; Fri, 26 Jul 2024 11:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5pMo9hnCsfCWC5yCW0LsA7qSwE8GBkpBYaL6nIMUWJw=; b=NvSSfAJ0aqCo4jojaNB0CS9Y5N clo1RZIl8SpDKz95gE1xPq7/NkT18FvhICRIJiAeKhBAeIrb1AuGnXBOHzq9DX40i7H6QYOjGLyVH nJ/mSqWzSdB/CONcbWUm4145YL7KDuUeyD1mqDo3/g5D2ebl9Uh7TSoxwsyPo3IdMRW1i6xs9Vtfn S+NrNe7+jyilbheOGJbjO4p4az+aBhIWX219GpuCSYgoaCIDt2t7yLxwWSUdoOsSespUmoejCHola aZY9Z3kR3Itd0jmjEWvbWPAoBO8JdAsYE5NhYoA/Gq+NpCG+iVMNzTgpFwZQ8mGoq+ge9vmN3zl/e aYGeftJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXJ8o-00000003iqQ-3AQR; Fri, 26 Jul 2024 11:29:42 +0000 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXJ8P-00000003ihd-0m5z for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 11:29:18 +0000 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-260e8c98cc2so610493fac.0 for ; Fri, 26 Jul 2024 04:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721993356; x=1722598156; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5pMo9hnCsfCWC5yCW0LsA7qSwE8GBkpBYaL6nIMUWJw=; b=Onq7uW2mWDxlQ2Inkeo8UtHy+3oM5yzv+attytxtnALFdoz0wP3WOju18uX0a5STPu MbbPe+cUbDGEsKm/OfoBdsR6irhUmkloQXeYQZ8N0fvtM7I93H+lxtU96kDn7BNsyMxY 9VZP1FBfOf3Drk17aEOknsb17uYUHmUb7v7AeGvxKImyDSLJPziWPKlK7oCo/zNk7cNT 6rm7eWYkkRfsvtI2cvf9WR3a5PtdaycRvFmtcTz5EVckC1efuOv2s1lHXJMFd0oKfIf4 k8fMjlxsFy7JxkqvIRB7RpIf1WB672jFNp5OmhMbT9305ALQ0vpo28nkAkASygpyubJ+ tsPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721993356; x=1722598156; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5pMo9hnCsfCWC5yCW0LsA7qSwE8GBkpBYaL6nIMUWJw=; b=tGOEeNkLRRgwRprh3ruA+f4rlJBu9Z9qeLZP4kTAqxm+d2pklzn3cdGcU+xUQJjQ4o qqvYPpx3lmsvd697Xy6JG8T2Ov1ALGiGaTZlh+cA+klCkXB4RdxMzmATtScTxM2lDMOz yYTP8AOnde0z9/dwStA0BEZm903e1nRTVs9G0S9Dq1fHh0n24SdZfeHoNl2LcrurzrQ4 kFi6aPoUI7KJCIuXr0rUNJ0hx2AcTzxIPvx8ganPQ/QksEkot4crvCLuLPsKmfRqvnVI Qj2h5Evb0JNpF7p/lg6H6PzQiQC2VjjGUzyNRn8IRXkhVKu0/S9L51m+1PVrvcP6WJdh CQcQ== X-Forwarded-Encrypted: i=1; AJvYcCVtjPoCU1ZplUU1qcrv8FH8XLtaoueJVrvcNt8ZzDvtxVKiiK09kqxtH7PmELa9MZ2GbWxdbR7pAjylFhuhnjUMemFL5ghw0rDKTRg9WH0RiEgUKts= X-Gm-Message-State: AOJu0YwTT/RHusZ9P5rlzEtbJ6VG0VmfvuBRghw8VVpkKu9mwXgnd57O fV5Iey6W1dJS/KUcatbTIhelDoE7+01q11ct7cCYEHL/7fRcUt5amF6px7QABQ== X-Google-Smtp-Source: AGHT+IHlT3OKls4LvpPPy8CgLAdDtpss7juy+jjswU+eANQFxUOYsClbebRinrzw6khsoRCjIBzBOA== X-Received: by 2002:a05:6870:71d2:b0:261:17e7:59b3 with SMTP id 586e51a60fabf-266cc2e479cmr6205616fac.3.1721993355965; Fri, 26 Jul 2024 04:29:15 -0700 (PDT) Received: from thinkpad ([2409:40f4:201d:928a:9e8:14a5:7572:42b6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm2581413b3a.178.2024.07.26.04.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 04:29:15 -0700 (PDT) Date: Fri, 26 Jul 2024 16:59:07 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 11/12] PCI: brcmstb: Change field name from 'type' to 'model' Message-ID: <20240726112907.GD2628@thinkpad> References: <20240716213131.6036-1-james.quinlan@broadcom.com> <20240716213131.6036-12-james.quinlan@broadcom.com> <20240725045810.GK2317@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_042917_231299_B8F9A44C X-CRM114-Status: GOOD ( 23.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 25, 2024 at 04:38:12PM -0400, Jim Quinlan wrote: > On Thu, Jul 25, 2024 at 12:58 AM Manivannan Sadhasivam > wrote: > > > > On Tue, Jul 16, 2024 at 05:31:26PM -0400, Jim Quinlan wrote: > > > The 'type' field used in the driver to discern SoC differences is confusing > > > so change it to the more apt 'model'. We considered using 'family' but > > > this conflicts with Broadcom's conception of a family; for example, 7216a0 > > > and 7216b0 chips are both considered separate families as each has multiple > > > derivative product chips based on the original design. > > > > > > > TBH, 'model' is also confusing :) Why can't you just use 'soc' as you are > > referrring to the SoC name. > > Hello, > > Well, the "model" we assign is not necessarily the same as the SoC. > If a new SoC has the same characteristics as a previous "model", we > will not create a new model but rather use the existing one. For example, > the bcm7216_cfg structure, which is for the 7216 SoC uses the model "BCM7278". > > I agree that this is not crystal clear but using SoC could be > considered misleading. > Ok, thanks for clarifying. Still I think you can use 'soc' prefix. For naming, how about 'soc_base'? This specifies the SoC baseline used by *this* Soc. - Mani -- மணிவண்ணன் சதாசிவம்