From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEE30C3DA4A for ; Fri, 26 Jul 2024 13:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jga0bcOBHnO3aeHr699McPj2Z8f4UdLGZUMJlsQl6NI=; b=icCGq3MD5fh1ZfX/nAeZ5WVBZn Hq/UB2ktd/09J7bLeQMVQp18SLksPyMZd492HvlrwxqFpM7dbo4WKMFNUyVr+2gDk0iYIcongGuqF qc3qtPB52C8D27WE5wHfpwr7OPegT7nSt1BcEh9qzXgPS8nQ3FeVFZfLHOwEpq1xvVxhczIfYNOj/ aN9sj6X15o2uIBxCFtcNbF6jh9Z/wT9DJjst9xTC2VXuH94Rb598BCI6+hU+q/dSgXo2ofCLhOoYW M1Jvhqyt8ybAarO+JuCTVXdbCE73LmpWqJzqmGwRYuZ1JAu/AgpAqcF9qY4Vn4+PXzciZ+5NQz29H 6MWTYUgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXLNY-0000000444h-3Yv5; Fri, 26 Jul 2024 13:53:04 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXLN9-00000004405-2HEI for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 13:52:40 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 46QDqWGK050842; Fri, 26 Jul 2024 08:52:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1722001952; bh=jga0bcOBHnO3aeHr699McPj2Z8f4UdLGZUMJlsQl6NI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=vrHiqUMz1RKAZkeMfI7b+WwuZrEP+HMmCFtVM0nu5vYJu7PZf36kUsWwovmz+Wntt SHHrWkssKug1JGdGdU5DgeA+uXmsSmhNMWRSvwytDTz7KNBRkJ6+BDhVL0BakPHlEC 4RqqWtT8YKiZ5+RLJGCFpmsXk96p/UyCGcPaKWUc= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 46QDqWua068323 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 26 Jul 2024 08:52:32 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 26 Jul 2024 08:52:32 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 26 Jul 2024 08:52:32 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 46QDqVxW024066; Fri, 26 Jul 2024 08:52:32 -0500 Date: Fri, 26 Jul 2024 19:22:31 +0530 From: Dhruva Gole To: "Peng Fan (OSS)" CC: , , , , , , , , Peng Fan Subject: Re: [PATCH V2] clk: scmi: add is_prepared hook Message-ID: <20240726135231.hhzp3dqgx64e6kiw@dhruva> References: <20240726131007.1651996-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240726131007.1651996-1-peng.fan@oss.nxp.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_065239_647949_0E858C67 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Jul 26, 2024 at 21:10:07 +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Some clks maybe default enabled by hardware, so add is_prepared hook > for non-atomic clk_ops to get the status of the clk. Then when disabling > unused clks, those unused clks but default hardware on clks could be > in off state to save power. Just a nit - reword the commit message as: Then when disabling the unused clocks, they can be simply turned OFF to save power. Also if you can make it still verbose, explain when you expect this disabling of unused clks to take place exactly? During boot? Driver probe sequence? or By some user commands? > > Signed-off-by: Peng Fan > --- > > V2: > Provider helper __scmi_clk_is_enabled for atomic and non-atomic usage > Move is_prepared hook out of SCMI_CLK_STATE_CTRL_SUPPORTED [...] -- Best regards, Dhruva Gole