linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: linux-pci@vger.kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Aleksandr Mishin" <amishin@t-argos.ru>,
	"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
	"Anup Patel" <apatel@ventanamicro.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Hou Zhiqiang" <Zhiqiang.Hou@nxp.com>,
	"Jianjun Wang" <jianjun.wang@mediatek.com>,
	"Jim Quinlan" <jim2101024@gmail.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
	"Jon Hunter" <jonathanh@nvidia.com>,
	"Jonathan Derrick" <jonathan.derrick@linux.dev>,
	"Joyce Ooi" <joyce.ooi@intel.com>,
	"Karthikeyan Mitran" <m.karthikeyan@mobiveil.co.in>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Koichiro Den" <den@valinux.co.jp>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Marc Zyngier" <maz@kernel.org>,
	"Michal Simek" <michal.simek@amd.com>,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Niklas Cassel" <cassel@kernel.org>,
	"Nipun Gupta" <nipun.gupta@amd.com>,
	"Nirmal Patel" <nirmal.patel@linux.intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Ryder Lee" <ryder.lee@mediatek.com>,
	"Shivamurthy Shastri" <shivamurthy.shastri@linutronix.de>,
	"Siddharth Vadapalli" <s-vadapalli@ti.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 00/15] genirq/msi: Silence set affinity failed warning
Date: Fri, 26 Jul 2024 13:57:09 -0500	[thread overview]
Message-ID: <20240726185709.GA915987@bhelgaas> (raw)
In-Reply-To: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org>

On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote:
> Various PCIe controllers that mux MSIs onto single IRQ line produce these
> "IRQ%d: set affinity failed" warnings when entering suspend. Remove the
> .irq_set_affinity callbacks and make sure they are NULL in all affected
> controllers, so this warning in kernel/irq/msi.c is not triggered.
> 
> This has been compile-tested only on all but the R-Car PCI controller.
> 
> The clean ups are done per-driver so they can be easily reverted in case
> they break something.
> 
> Marek Vasut (15):
>   genirq/msi: Silence set affinity failed warning
>   PCI: aardvark: Silence set affinity failed warning
>   PCI: altera-msi: Silence set affinity failed warning
>   PCI: brcmstb: Silence set affinity failed warning
>   PCI: dwc: Silence set affinity failed warning
>   PCI: mediatek-gen3: Silence set affinity failed warning
>   PCI: mediatek: Silence set affinity failed warning
>   PCI: mobiveil: Silence set affinity failed warning
>   PCI: plda: Silence set affinity failed warning
>   PCI: rcar-host: Silence set affinity failed warning
>   PCI: tegra: Silence set affinity failed warning
>   PCI: vmd: Silence set affinity failed warning
>   PCI: xilinx-nwl: Silence set affinity failed warning
>   PCI: xilinx-xdma: Silence set affinity failed warning
>   PCI: xilinx: Silence set affinity failed warning
> 
>  drivers/pci/controller/dwc/pci-keystone.c           |  7 -------
>  drivers/pci/controller/dwc/pcie-designware-host.c   | 12 +++---------
>  .../pci/controller/mobiveil/pcie-mobiveil-host.c    | 11 ++---------
>  drivers/pci/controller/pci-aardvark.c               | 10 ++--------
>  drivers/pci/controller/pci-tegra.c                  | 10 ++--------
>  drivers/pci/controller/pcie-altera-msi.c            | 11 ++---------
>  drivers/pci/controller/pcie-brcmstb.c               | 11 ++---------
>  drivers/pci/controller/pcie-mediatek-gen3.c         | 13 +++----------
>  drivers/pci/controller/pcie-mediatek.c              | 11 ++---------
>  drivers/pci/controller/pcie-rcar-host.c             | 10 ++--------
>  drivers/pci/controller/pcie-xilinx-dma-pl.c         | 11 ++---------
>  drivers/pci/controller/pcie-xilinx-nwl.c            | 11 ++---------
>  drivers/pci/controller/pcie-xilinx.c                |  9 ++-------
>  drivers/pci/controller/plda/pcie-plda-host.c        | 11 ++---------
>  drivers/pci/controller/vmd.c                        | 13 +------------
>  include/linux/msi.h                                 |  2 ++
>  kernel/irq/msi.c                                    |  2 +-
>  17 files changed, 32 insertions(+), 133 deletions(-)

Applied to pci/controller/affinity for v6.11, thank you very much for
doing this work!

I pushed this branch, but it won't show up in linux-next until after
v6.12-rc1 is tagged.


      parent reply	other threads:[~2024-07-26 18:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23 13:27 [PATCH v4 00/15] genirq/msi: Silence set affinity failed warning Marek Vasut
2024-07-23 13:27 ` [PATCH v4 01/15] " Marek Vasut
2024-07-23 22:54   ` Damien Le Moal
2024-07-23 13:27 ` [PATCH v4 02/15] PCI: aardvark: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 03/15] PCI: altera-msi: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 04/15] PCI: brcmstb: " Marek Vasut
2024-07-24  0:00   ` Florian Fainelli
2024-07-23 13:27 ` [PATCH v4 05/15] PCI: dwc: " Marek Vasut
2024-07-23 22:53   ` Damien Le Moal
2024-07-24 13:47   ` Manivannan Sadhasivam
2024-07-23 13:27 ` [PATCH v4 06/15] PCI: mediatek-gen3: " Marek Vasut
2024-07-24  6:27   ` Jianjun Wang (王建军)
2024-07-23 13:27 ` [PATCH v4 07/15] PCI: mediatek: " Marek Vasut
2024-07-24  6:25   ` Jianjun Wang (王建军)
2024-07-23 13:27 ` [PATCH v4 08/15] PCI: mobiveil: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 09/15] PCI: plda: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 10/15] PCI: rcar-host: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 11/15] PCI: tegra: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 12/15] PCI: vmd: " Marek Vasut
2024-08-05 14:30   ` Nirmal Patel
2024-07-23 13:27 ` [PATCH v4 13/15] PCI: xilinx-nwl: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 14/15] PCI: xilinx-xdma: " Marek Vasut
2024-07-23 13:27 ` [PATCH v4 15/15] PCI: xilinx: " Marek Vasut
2024-07-24 13:50 ` [PATCH v4 00/15] genirq/msi: " Manivannan Sadhasivam
2024-07-24 15:43 ` Bjorn Helgaas
2024-07-26 12:10   ` Thomas Gleixner
2024-07-26 18:57 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726185709.GA915987@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Jisheng.Zhang@synaptics.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=amishin@t-argos.ru \
    --cc=anna-maria@linutronix.de \
    --cc=apatel@ventanamicro.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=daire.mcnamara@microchip.com \
    --cc=den@valinux.co.jp \
    --cc=dlemoal@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jianjun.wang@mediatek.com \
    --cc=jim2101024@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=jonathan.derrick@linux.dev \
    --cc=jonathanh@nvidia.com \
    --cc=joyce.ooi@intel.com \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.karthikeyan@mobiveil.co.in \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=maz@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=nipun.gupta@amd.com \
    --cc=nirmal.patel@linux.intel.com \
    --cc=nsaenz@kernel.org \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    --cc=ryder.lee@mediatek.com \
    --cc=s-vadapalli@ti.com \
    --cc=shivamurthy.shastri@linutronix.de \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).