From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A23DBC3DA63 for ; Fri, 26 Jul 2024 06:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XxlfIXn2TBWn9ddKcrzNSExYaZ0bt3SVhp7eR4ZPeAE=; b=DAVu1JlwUGQ2tLZHLPSZm6zmz8 /lpmgHScaFF1D7nyrDqLu42WyLi0nfoxUP+1NDzCGFrfyBme8WXU4OlCIAnnKnRm/sGTgBmDh6rKP ZxMwhIOMkPHD7ZpXSEbrXbZ5/cQsQgjAtJHj7UW7tBqz49Mp/+IP3Lc8nOjnGWro6QdFk4wGLLHkw cCpxFfna3wRf/zCc+6cljlPW9LxKL2DFGMRN4m/Ezoqj48uBPfNaNLLx3jHmCYoCA7M9QbCH3WknH uGpyz3fw/yFRqw2voFhftNHdKyEQpV7sPxL3UtG+y+0XApkGD6mH604tgRLGVwcm2sv1vf+1KFxHx trnM8zQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXEsH-0000000362E-0IiE; Fri, 26 Jul 2024 06:56:21 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXErr-000000035xU-0hnx for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 06:55:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4587ACE0EB3; Fri, 26 Jul 2024 06:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D35FBC32782; Fri, 26 Jul 2024 06:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721976952; bh=bdIwJ/4nu4+KCxJe0alUQUJf38MsA69moluw9BRz+lw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ldU7r6IxYyHdQvPgsui9cjPZ36y6gCclT7KzRjlOQan3mtNbRhCI7MsRbkQSCfsuh tHDGh8c3KiQ+NtGlGYVgT1cN6cnCr59Ilk0pSdCIl60LbCJlXgWsYKUX9hRSG+/5Op LqonJE9tNjbh7nBGaOBz1TB+QQgPPCRE3iPFe5OE= Date: Fri, 26 Jul 2024 08:55:49 +0200 From: Greg Kroah-Hartman To: Shenwei Wang Cc: Peter Chen , Pawel Laszczak , Shawn Guo , Sascha Hauer , Roger Quadros , Pengutronix Kernel Team , Fabio Estevam , Frank Li , linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: Re: [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume Message-ID: <2024072635-egging-suffix-92d5@gregkh> References: <20240725212811.296307-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240725212811.296307-1-shenwei.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240725_235555_405623_879BC6C8 X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 25, 2024 at 04:28:11PM -0500, Shenwei Wang wrote: > By utilizing _force_suspend and _force_resume, ensures a more consistent > and simple approach to handling system sleep states. It also aligns the > driver's PM behavior with the other drivers' common practices. > > Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid duplicated operations") > Reviewed-by: Frank Li > Signed-off-by: Shenwei Wang > --- > drivers/usb/cdns3/cdns3-imx.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c > index 281de47e2a3b..9051cbe9d68b 100644 > --- a/drivers/usb/cdns3/cdns3-imx.c > +++ b/drivers/usb/cdns3/cdns3-imx.c > @@ -360,7 +360,6 @@ static int cdns_imx_suspend(struct device *dev) > return 0; > } > > - > /* Indicate if the controller was power lost before */ > static inline bool cdns_imx_is_power_lost(struct cdns_imx *data) > { Unneeded change here?