[PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume

[PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume

[Shenwei Wang]

By utilizing _force_suspend and _force_resume, ensures a more consistent
and simple approach to handling system sleep states. It also aligns the
driver's PM behavior with the other drivers' common practices.

Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid duplicated operations")
Reviewed-by: Frank Li <frank.li@nxp.com>
Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
---
 drivers/usb/cdns3/cdns3-imx.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c
index 281de47e2a3b..9051cbe9d68b 100644
--- a/drivers/usb/cdns3/cdns3-imx.c
+++ b/drivers/usb/cdns3/cdns3-imx.c
@@ -360,7 +360,6 @@ static int cdns_imx_suspend(struct device *dev)
 	return 0;
 }
 
-
 /* Indicate if the controller was power lost before */
 static inline bool cdns_imx_is_power_lost(struct cdns_imx *data)
 {
@@ -373,22 +372,18 @@ static inline bool cdns_imx_is_power_lost(struct cdns_imx *data)
 		return false;
 }
 
-static int __maybe_unused cdns_imx_system_suspend(struct device *dev)
-{
-	pm_runtime_put_sync(dev);
-	return 0;
-}
-
 static int __maybe_unused cdns_imx_system_resume(struct device *dev)
 {
 	struct cdns_imx *data = dev_get_drvdata(dev);
 	int ret;
 
+	ret = pm_runtime_force_resume(dev);
+	if (ret)
+		return ret;
+
 	ret = pm_runtime_resume_and_get(dev);
-	if (ret < 0) {
-		dev_err(dev, "Could not get runtime PM.\n");
+	if (ret)
 		return ret;
-	}
 
 	if (cdns_imx_is_power_lost(data)) {
 		dev_dbg(dev, "resume from power lost\n");
@@ -397,6 +392,7 @@ static int __maybe_unused cdns_imx_system_resume(struct device *dev)
 			cdns_imx_suspend(dev);
 	}
 
+	pm_runtime_put_autosuspend(dev);
 	return ret;
 }
 
@@ -411,7 +407,7 @@ static int cdns_imx_platform_suspend(struct device *dev,
 
 static const struct dev_pm_ops cdns_imx_pm_ops = {
 	SET_RUNTIME_PM_OPS(cdns_imx_suspend, cdns_imx_resume, NULL)
-	SET_SYSTEM_SLEEP_PM_OPS(cdns_imx_system_suspend, cdns_imx_system_resume)
+	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, cdns_imx_system_resume)
 };
 
 static const struct of_device_id cdns_imx_of_match[] = {
-- 
2.34.1

Re: [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume

[Greg Kroah-Hartman]

On Thu, Jul 25, 2024 at 04:28:11PM -0500, Shenwei Wang wrote:
> By utilizing _force_suspend and _force_resume, ensures a more consistent
> and simple approach to handling system sleep states. It also aligns the
> driver's PM behavior with the other drivers' common practices.
> 
> Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid duplicated operations")
> Reviewed-by: Frank Li <frank.li@nxp.com>
> Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> ---
>  drivers/usb/cdns3/cdns3-imx.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c
> index 281de47e2a3b..9051cbe9d68b 100644
> --- a/drivers/usb/cdns3/cdns3-imx.c
> +++ b/drivers/usb/cdns3/cdns3-imx.c
> @@ -360,7 +360,6 @@ static int cdns_imx_suspend(struct device *dev)
>  	return 0;
>  }
>  
> -
>  /* Indicate if the controller was power lost before */
>  static inline bool cdns_imx_is_power_lost(struct cdns_imx *data)
>  {

Unneeded change here?

RE: [EXT] Re: [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume

[Shenwei Wang]

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Friday, July 26, 2024 1:56 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Peter Chen <peter.chen@kernel.org>; Pawel Laszczak
> <pawell@cadence.com>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> >
> > Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid
> > duplicated operations")
> > Reviewed-by: Frank Li <frank.li@nxp.com>
> > Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> > ---
> >  drivers/usb/cdns3/cdns3-imx.c | 18 +++++++-----------
> >  1 file changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/usb/cdns3/cdns3-imx.c
> > b/drivers/usb/cdns3/cdns3-imx.c index 281de47e2a3b..9051cbe9d68b
> > 100644
> > --- a/drivers/usb/cdns3/cdns3-imx.c
> > +++ b/drivers/usb/cdns3/cdns3-imx.c
> > @@ -360,7 +360,6 @@ static int cdns_imx_suspend(struct device *dev)
> >       return 0;
> >  }
> >
> > -
> >  /* Indicate if the controller was power lost before */  static inline
> > bool cdns_imx_is_power_lost(struct cdns_imx *data)  {
> 
> Unneeded change here?
> 

That is an extraneous blank line was introduced in last commit and has been removed as part of this correction. 
If you prefer to maintain the original formatting with the extra blank line, please let me know, and I can revert this change.

Thanks,
Shenwei

Re: [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume

[Greg Kroah-Hartman]

On Thu, Jul 25, 2024 at 04:28:11PM -0500, Shenwei Wang wrote:
> By utilizing _force_suspend and _force_resume, ensures a more consistent
> and simple approach to handling system sleep states. It also aligns the
> driver's PM behavior with the other drivers' common practices.
> 
> Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid duplicated operations")
> Reviewed-by: Frank Li <frank.li@nxp.com>
> Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> ---
>  drivers/usb/cdns3/cdns3-imx.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot