From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD7EDC3DA61 for ; Sat, 27 Jul 2024 15:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MdOvI8+rpLLefINCU7BbidGRHvBz0B3jFeo8bSnMAco=; b=SONofapDkaOXI/4M9LA6IiyS39 IJIoR+AzsU2Q5Q6NiYzbg2sNSF95b2A8c3pH0r7Ixordas2b2anlV9KafH3liPKmaI7q4WOrPirs9 ejSGXD7+Ii7FIIJdlbs7RMo0OQjTK3Djy8gePhOp8e2lxd4RHj8NzMvKni133BNTRoaHy6XjbYpUa +xC20G77asys8P/VzNJr5EGAWezPsTINwyxEOp7+LyyKPbjhm2t39i8igdFm5AqemSERUzd3atYsl PfmyAvatV++8/NQ8sDNGGzs1Q1bAJwbJTXwzu4vrdEIp3A1F9fLIzjiCJMFsa4ntYNeEuDt/U2fV3 zz3yEoww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXjC3-00000006spS-0HgF; Sat, 27 Jul 2024 15:18:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXjBc-00000006slz-49W6 for linux-arm-kernel@lists.infradead.org; Sat, 27 Jul 2024 15:18:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B11560E9D; Sat, 27 Jul 2024 15:18:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 020CEC32781; Sat, 27 Jul 2024 15:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722093495; bh=btTXuTbKagMwME/+aT4QIdnx1STO462E7hNfPKzYr9o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZwWb6IokZ6x+KiUdMLBFFzH5bTIgIUOhbHLYmgPtqKqSvjD++YbXyE3mKkTzo1UB0 qXHnYbbVQqDdlwwjjsOLDKBDDMbtdv6xVggktIKZumGVCnkrbdIHvIJTdHG6SFWPz9 +Z/IgS1ewdY6g4/LEBHXdVCr6LR+uKb0FNYs6yQDHb8OwgB/smDmlXhd6J78bY0a4U IjvRor3eXGNlVkfV0qlpLWkXQwm5AqTu+tlaMKfG6Cg6RBw1x6Fh36gFMe4AuNPs3R oXXm5KLqET20wOyznQeQ+H+2dXGq8k15OcO+b/B0ZN/lSun+IlomL9OA674jX6g9O6 ROa0ZiAtwpHJg== Date: Sat, 27 Jul 2024 16:18:06 +0100 From: Jonathan Cameron To: Olivier Moysan Cc: , Lars-Peter Clausen , Maxime Coquelin , Alexandre Torgue , , , , Subject: Re: [PATCH v5 7/9] iio: adc: stm32-dfsdm: adopt generic channels bindings Message-ID: <20240727161806.18286978@jic23-huawei> In-Reply-To: <20240724153639.803263-8-olivier.moysan@foss.st.com> References: <20240724153639.803263-1-olivier.moysan@foss.st.com> <20240724153639.803263-8-olivier.moysan@foss.st.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240727_081821_130253_5F5A484F X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 Jul 2024 17:36:35 +0200 Olivier Moysan wrote: > Move to generic channels binding to ease new backend framework adoption > and prepare the convergence with MDF IP support on STM32MP2 SoC family. > > Legacy binding: > DFSDM is an IIO channel consumer. > SD modulator is an IIO channels provider. > The channel phandles are provided in DT through io-channels property > and channel indexes through st,adc-channels property. > > New binding: > DFSDM is an IIO channel provider. > The channel indexes are given by reg property in channel child node. > > This new binding is intended to be used with SD modulator IIO backends. > It does not support SD modulator legacy IIO devices. > The st,adc-channels property presence is used to discriminate > between legacy and backend bindings. > > The support of the DFSDM legacy channels and SD modulator IIO devices > is kept for backward compatibility. > > Signed-off-by: Olivier Moysan Hi Olivier, At some point it would be good to use dev_err_probe() though out all the probe only paths. It might save you quite a few lines of code and print nicer error messages. Otherwise LGTM Thanks, Jonathan