From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AE09C3DA61 for ; Mon, 29 Jul 2024 13:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oL6Ei2KYeBDeJNbLf68ofb+Lx3i9/7UrWfP1UrSTo+I=; b=Jt9xNYg6xzsYgXU2ui0szx/iFu 4ALo7OHF4dmnBca85ANrlCUIixLkaiixd3wUYkHJ51xZMRDLyV7NDc7ErRyP3o4ZiX6eS4OZPJ9zy wsteNtznNWgHF3KG+uwfZ8G6zRPl0JfwGBpt6huZfsBSeOdJnbKwMS4tKZ57JLCWc7vKE9YDnyQRw Gu5jrDjyqZ6Q1Y1eWUNp5DpXjcA7SXaaehenp6lkTibyidta08JOeUmCKE0GRNI+Twaep05qJwWkb 3z4ZyK3u4/CFGemJp6NOeJaDegyA8sAsIS8wOyQIUVo3a57CWPafYxsOCgjRcQi1BvVKPzEmm6IV4 OD0l86Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYQ4i-0000000BKzl-0lKz; Mon, 29 Jul 2024 13:06:04 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYQ4G-0000000BKpJ-2Gwd for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2024 13:05:38 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5af6a1afa7bso3023324a12.1 for ; Mon, 29 Jul 2024 06:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722258334; x=1722863134; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oL6Ei2KYeBDeJNbLf68ofb+Lx3i9/7UrWfP1UrSTo+I=; b=HexqGFonWhffJvBxb70BOzjn2RLCQNVMNDUDlTmxIi2DbD+tKzXwBMr4PRDsrbPXH0 zDLwDCbx5HK45HM6BA7FW88/CJTKZxz2wYD61IC5J5RsBSwe4jfy3GUp6coC+N4DWUCV ovNUNYmDwwA6hqoEdZ3HB3+OIHdRODi7ucd36n5IHxzAzvGeOqjpT0QaacH0P4St/5M6 nBMqJh7r4vQDmmZyxeLOKfw/x6tJlZ/A/frOC7QE9u29UNtRjkPiJiBzaiU0mRp66hJQ HlkoOIPr1n1HDHaAosftv3EreT0EQwKwfqAxB+ic6/UKT3pn/Yw80ofcC06K2JuRZdLH h+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722258334; x=1722863134; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oL6Ei2KYeBDeJNbLf68ofb+Lx3i9/7UrWfP1UrSTo+I=; b=bEokjknk6i6WN88IhQeo35TW05PUwLxYkS+4Dxqp/Ic0heTkppUFzUkCJF7xvfDe2I 7+upx/UJmwOdthM0bkDmEEdhO3cVZZ0GCIuDP4j6dC5JOqVlXqydOwJ70nxVsv8KRsiH idhj2BqKzwkm/6GGa7SHEIhyF6KNsAkYczyNDh4Z3TH2pCv47v6QjsB6jcr3o7HNeHlJ 1UTKUjkAXux83j9vjLnowlMi2RboSFbqwvaKYCwuI6iacAXMPU7rXxlq+GjdyeNVYmKF wS1TZAmhAL391/fWYZ8dwApFyVzpownZWhQItIyvt0MphuDJe+ICYbIPbx0PgdizqC9g 00ng== X-Forwarded-Encrypted: i=1; AJvYcCV8isFGXxos3KuHwzsnJmMT5x0eYM464xZ+dT0s1RJ3hTaDUU/LIhKnUYfZYtej1tcynw6hUqRNod1yWweGVw/xK2PdLr+PyIgELo+w5rk8O+R+f0U= X-Gm-Message-State: AOJu0Yy7SKmsN5nV9VZILV8cM4nXH/vhgQtmCyq7f9f4sadKjz9p3WQc 1MLp+DtfzEcbrIikkbCceH16If/GayU6w3Ve4/LnHOOnDwQPD671ZMiLXz0KdTE= X-Google-Smtp-Source: AGHT+IF0LI+nFBLvWwrjgKxa86+5pT2h9JjZMBwNTkHKWP7qRNiQQsN51SlBoLwcS80o17x5Hl5UHQ== X-Received: by 2002:a05:6402:13ce:b0:59f:9fc7:1e70 with SMTP id 4fb4d7f45d1cf-5b02000c21amr5865160a12.6.1722258334038; Mon, 29 Jul 2024 06:05:34 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac63b5a7a0sm5773400a12.51.2024.07.29.06.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 06:05:33 -0700 (PDT) Date: Mon, 29 Jul 2024 15:05:32 +0200 From: Andrew Jones To: Haibo Xu Cc: sunilvl@ventanamicro.com, xiaobo55x@gmail.com, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Cameron , Gavin Shan , "Russell King (Oracle)" , James Morse , Hanjun Guo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Message-ID: <20240729-fdff8667bb22fcd63ea33ce3@orel> References: <20240729035958.1957185-1-haibo1.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729035958.1957185-1-haibo1.xu@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240729_060536_613648_71B66119 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 29, 2024 at 11:59:55AM GMT, Haibo Xu wrote: > Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE. > To ensure all the values were properly initialized, switch to initialize > all of them to NUMA_NO_NODE. > > Suggested-by: Andrew Jones Thanks, but I think Reported-by, or both Reported-by and Suggested-by, is more appropriate. Also, I agree with Sunil that we probably need to split this patch for arm64 and riscv in order to add appropriate Fixes tags. > Signed-off-by: Haibo Xu > --- > arch/arm64/kernel/acpi_numa.c | 2 +- > arch/riscv/kernel/acpi_numa.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c > index 0c036a9a3c33..2465f291c7e1 100644 > --- a/arch/arm64/kernel/acpi_numa.c > +++ b/arch/arm64/kernel/acpi_numa.c > @@ -27,7 +27,7 @@ > > #include > > -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE }; > +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE }; > > int __init acpi_numa_get_nid(unsigned int cpu) > { > diff --git a/arch/riscv/kernel/acpi_numa.c b/arch/riscv/kernel/acpi_numa.c > index 0231482d6946..ff95aeebee3e 100644 > --- a/arch/riscv/kernel/acpi_numa.c > +++ b/arch/riscv/kernel/acpi_numa.c > @@ -28,7 +28,7 @@ > > #include > > -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE }; > +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE }; > > int __init acpi_numa_get_nid(unsigned int cpu) > { > -- > 2.34.1 > With the tags additions, Reviewed-by: Andrew Jones Thanks, drew