* Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
2024-07-29 3:59 [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Haibo Xu
@ 2024-07-29 6:16 ` Anshuman Khandual
2024-07-29 6:28 ` Sunil V L
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Anshuman Khandual @ 2024-07-29 6:16 UTC (permalink / raw)
To: Haibo Xu, sunilvl
Cc: xiaobo55x, ajones, Catalin Marinas, Will Deacon, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jonathan Cameron, Gavin Shan,
Russell King (Oracle), James Morse, Hanjun Guo, linux-arm-kernel,
linux-kernel, linux-riscv
On 7/29/24 09:29, Haibo Xu wrote:
> Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE.
> To ensure all the values were properly initialized, switch to initialize
> all of them to NUMA_NO_NODE.
>
> Suggested-by: Andrew Jones <ajones@ventanamicro.com>
> Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> (arm64 platform)
> ---
> arch/arm64/kernel/acpi_numa.c | 2 +-
> arch/riscv/kernel/acpi_numa.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c
> index 0c036a9a3c33..2465f291c7e1 100644
> --- a/arch/arm64/kernel/acpi_numa.c
> +++ b/arch/arm64/kernel/acpi_numa.c
> @@ -27,7 +27,7 @@
>
> #include <asm/numa.h>
>
> -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE };
> +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE };
>
> int __init acpi_numa_get_nid(unsigned int cpu)
> {
> diff --git a/arch/riscv/kernel/acpi_numa.c b/arch/riscv/kernel/acpi_numa.c
> index 0231482d6946..ff95aeebee3e 100644
> --- a/arch/riscv/kernel/acpi_numa.c
> +++ b/arch/riscv/kernel/acpi_numa.c
> @@ -28,7 +28,7 @@
>
> #include <asm/numa.h>
>
> -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE };
> +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE };
>
> int __init acpi_numa_get_nid(unsigned int cpu)
> {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
2024-07-29 3:59 [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Haibo Xu
2024-07-29 6:16 ` Anshuman Khandual
@ 2024-07-29 6:28 ` Sunil V L
2024-07-29 13:05 ` Andrew Jones
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sunil V L @ 2024-07-29 6:28 UTC (permalink / raw)
To: Haibo Xu
Cc: xiaobo55x, ajones, Catalin Marinas, Will Deacon, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jonathan Cameron, Gavin Shan,
Russell King (Oracle), James Morse, Hanjun Guo, linux-arm-kernel,
linux-kernel, linux-riscv
On Mon, Jul 29, 2024 at 11:59:55AM +0800, Haibo Xu wrote:
> Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE.
> To ensure all the values were properly initialized, switch to initialize
> all of them to NUMA_NO_NODE.
>
> Suggested-by: Andrew Jones <ajones@ventanamicro.com>
> Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
> ---
> arch/arm64/kernel/acpi_numa.c | 2 +-
> arch/riscv/kernel/acpi_numa.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c
> index 0c036a9a3c33..2465f291c7e1 100644
> --- a/arch/arm64/kernel/acpi_numa.c
> +++ b/arch/arm64/kernel/acpi_numa.c
> @@ -27,7 +27,7 @@
>
> #include <asm/numa.h>
>
> -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE };
> +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE };
>
> int __init acpi_numa_get_nid(unsigned int cpu)
> {
> diff --git a/arch/riscv/kernel/acpi_numa.c b/arch/riscv/kernel/acpi_numa.c
> index 0231482d6946..ff95aeebee3e 100644
> --- a/arch/riscv/kernel/acpi_numa.c
> +++ b/arch/riscv/kernel/acpi_numa.c
> @@ -28,7 +28,7 @@
>
> #include <asm/numa.h>
>
> -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE };
> +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE };
>
The change looks good to me. However, I was wondering whether it needs
"Fixes" tag in which case I think you will have to split this patch into
two.
Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks!
Sunil
> int __init acpi_numa_get_nid(unsigned int cpu)
> {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
2024-07-29 3:59 [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Haibo Xu
2024-07-29 6:16 ` Anshuman Khandual
2024-07-29 6:28 ` Sunil V L
@ 2024-07-29 13:05 ` Andrew Jones
2024-08-16 15:15 ` Will Deacon
2024-09-24 6:40 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Jones @ 2024-07-29 13:05 UTC (permalink / raw)
To: Haibo Xu
Cc: sunilvl, xiaobo55x, Catalin Marinas, Will Deacon, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jonathan Cameron, Gavin Shan,
Russell King (Oracle), James Morse, Hanjun Guo, linux-arm-kernel,
linux-kernel, linux-riscv
On Mon, Jul 29, 2024 at 11:59:55AM GMT, Haibo Xu wrote:
> Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE.
> To ensure all the values were properly initialized, switch to initialize
> all of them to NUMA_NO_NODE.
>
> Suggested-by: Andrew Jones <ajones@ventanamicro.com>
Thanks, but I think Reported-by, or both Reported-by and Suggested-by,
is more appropriate. Also, I agree with Sunil that we probably need to
split this patch for arm64 and riscv in order to add appropriate Fixes
tags.
> Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
> ---
> arch/arm64/kernel/acpi_numa.c | 2 +-
> arch/riscv/kernel/acpi_numa.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c
> index 0c036a9a3c33..2465f291c7e1 100644
> --- a/arch/arm64/kernel/acpi_numa.c
> +++ b/arch/arm64/kernel/acpi_numa.c
> @@ -27,7 +27,7 @@
>
> #include <asm/numa.h>
>
> -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE };
> +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE };
>
> int __init acpi_numa_get_nid(unsigned int cpu)
> {
> diff --git a/arch/riscv/kernel/acpi_numa.c b/arch/riscv/kernel/acpi_numa.c
> index 0231482d6946..ff95aeebee3e 100644
> --- a/arch/riscv/kernel/acpi_numa.c
> +++ b/arch/riscv/kernel/acpi_numa.c
> @@ -28,7 +28,7 @@
>
> #include <asm/numa.h>
>
> -static int acpi_early_node_map[NR_CPUS] __initdata = { NUMA_NO_NODE };
> +static int acpi_early_node_map[NR_CPUS] __initdata = { [0 ... NR_CPUS - 1] = NUMA_NO_NODE };
>
> int __init acpi_numa_get_nid(unsigned int cpu)
> {
> --
> 2.34.1
>
With the tags additions,
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
2024-07-29 3:59 [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Haibo Xu
` (2 preceding siblings ...)
2024-07-29 13:05 ` Andrew Jones
@ 2024-08-16 15:15 ` Will Deacon
2024-09-24 6:40 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2024-08-16 15:15 UTC (permalink / raw)
To: sunilvl, Haibo Xu
Cc: catalin.marinas, kernel-team, Will Deacon, xiaobo55x, ajones,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jonathan Cameron,
Gavin Shan, Russell King (Oracle), James Morse, Hanjun Guo,
linux-arm-kernel, linux-kernel, linux-riscv
On Mon, 29 Jul 2024 11:59:55 +0800, Haibo Xu wrote:
> Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE.
> To ensure all the values were properly initialized, switch to initialize
> all of them to NUMA_NO_NODE.
>
>
Applied arm64 hunk to arm64 (for-next/acpi), thanks!
[1/1] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
https://git.kernel.org/arm64/c/8bb0376fe082
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
2024-07-29 3:59 [PATCH] ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE Haibo Xu
` (3 preceding siblings ...)
2024-08-16 15:15 ` Will Deacon
@ 2024-09-24 6:40 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-09-24 6:40 UTC (permalink / raw)
To: Xu, Haibo1
Cc: linux-riscv, sunilvl, xiaobo55x, ajones, catalin.marinas, will,
paul.walmsley, palmer, aou, Jonathan.Cameron, gshan, rmk+kernel,
james.morse, guohanjun, linux-arm-kernel, linux-kernel
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Mon, 29 Jul 2024 11:59:55 +0800 you wrote:
> Currently, only acpi_early_node_map[0] was initialized to NUMA_NO_NODE.
> To ensure all the values were properly initialized, switch to initialize
> all of them to NUMA_NO_NODE.
>
> Suggested-by: Andrew Jones <ajones@ventanamicro.com>
> Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
>
> [...]
Here is the summary with links:
- ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
https://git.kernel.org/riscv/c/732b177663e1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread