From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4DE2C3DA49 for ; Tue, 30 Jul 2024 09:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DIFv9XvfWxZXbyBpp5aeGPJ4p2JMdEMcToJfqL2IHAI=; b=wySSuppdONE5kU1Qn0nyuXtDvB P1E9PBLLPosTINQWixf3IawajRn0t9t/JH05NrBnUb+K3yu1kcm1c4sTNLuFpWLq1xx60K/Uox1RK u/pqTsB7B2hsAAYp1soFDtYDrpWxBauVnJFfFq1ZHxzk1GMuJI4BgOvTRhF0EqbVnGXdKApfvOnC0 AEvQiV3yjhwXb878hSqoqgVeUhReU/61N6+DHzZJqb/QD3Zi1VuirQ8ievYLJIecr4c6T+mjbjAdg lJnmyxLogKnpgvKyts6F8LFBvNwnRmVl2Ol4qoBdfxzeKq+he6sDQDBUM+jbFlPWhFQOxxyC0vfBi myRA54FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYjH5-0000000EYPh-1TfF; Tue, 30 Jul 2024 09:36:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYjF7-0000000EXke-0FcE for linux-arm-kernel@bombadil.infradead.org; Tue, 30 Jul 2024 09:34:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=DIFv9XvfWxZXbyBpp5aeGPJ4p2JMdEMcToJfqL2IHAI=; b=gM7U8BuwSrCLPh1braVN2prA1A Ageo+XQ2RCZ7uT/aLkO1LCDlrzYYDSTaJbbnqfYpA5yj34gpExqz+IKRoXxOX0UITPnd2tq4y662L Qolvh7j8S3RcfiXW7JyAlX8mmkw8cub13wUrLv+cqFNHfkMVKjUAt7fW/YHF7zsVY4GJx6e9wgR9B 1LL/gEli07OEJEDP7159kNu1QVXRpMIl0Tt16+1ksmPa7/XBqb2MgeKbHs6iamhQ7ogQ/RKGlFe+t nDNAkGW8vrLJEgRH1Iqynlp3UyoWPnDfPBasw8mJoeQL4qL3sj8dPzSf6ulBqlwrvKFzC6arRvEHw aJ4SJ+wQ==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYjF2-00000004xDe-47GU for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2024 09:34:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CEEAE153B; Tue, 30 Jul 2024 02:34:21 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B5AC3F5A1; Tue, 30 Jul 2024 02:33:55 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v4 4/5] firmware: arm_scmi: Create debugfs files for counts Date: Tue, 30 Jul 2024 10:33:41 +0100 Message-Id: <20240730093342.3558162-5-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240730093342.3558162-1-luke.parkin@arm.com> References: <20240730093342.3558162-1-luke.parkin@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_103401_536415_192CB293 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Create debugfs files for the metrics in the debug_counters array Signed-off-by: Luke Parkin --- v3->v4 Use new locations for debug array Use counter instead of stats v2->v3 Add extra statistics also added in v3 v1->v2 Only create stats pointer if stats are enabled Move stats debugfs creation into a seperate helper function --- drivers/firmware/arm_scmi/driver.c | 38 ++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 5acd3d324def..ec6434692d1a 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2847,6 +2847,41 @@ static int scmi_device_request_notifier(struct notifier_block *nb, return NOTIFY_OK; } +static void scmi_debugfs_counters_setup(struct scmi_debug_info *dbg, + struct dentry *trans) +{ + struct dentry *counters; + + counters = debugfs_create_dir("counters", trans); + + debugfs_create_atomic_t("sent_ok", 0400, counters, + &dbg->counters[SENT_OK]); + debugfs_create_atomic_t("sent_fail", 0400, counters, + &dbg->counters[SENT_FAIL]); + debugfs_create_atomic_t("sent_fail_polling_unsupported", 0400, counters, + &dbg->counters[SENT_FAIL_POLLING_UNSUPPORTED]); + debugfs_create_atomic_t("sent_fail_channel_not_found", 0400, counters, + &dbg->counters[SENT_FAIL_CHANNEL_NOT_FOUND]); + debugfs_create_atomic_t("response_ok", 0400, counters, + &dbg->counters[RESPONSE_OK]); + debugfs_create_atomic_t("notif_ok", 0400, counters, + &dbg->counters[NOTIF_OK]); + debugfs_create_atomic_t("dlyd_resp_ok", 0400, counters, + &dbg->counters[DLYD_RESPONSE_OK]); + debugfs_create_atomic_t("xfers_resp_timeout", 0400, counters, + &dbg->counters[XFERS_RESPONSE_TIMEOUT]); + debugfs_create_atomic_t("response_polled_ok", 0400, counters, + &dbg->counters[RESPONSE_POLLED_OK]); + debugfs_create_atomic_t("err_msg_unexpected", 0400, counters, + &dbg->counters[ERR_MSG_UNEXPECTED]); + debugfs_create_atomic_t("err_msg_invalid", 0400, counters, + &dbg->counters[ERR_MSG_INVALID]); + debugfs_create_atomic_t("err_msg_nomem", 0400, counters, + &dbg->counters[ERR_MSG_NOMEM]); + debugfs_create_atomic_t("err_protocol", 0400, counters, + &dbg->counters[ERR_PROTOCOL]); +} + static void scmi_debugfs_common_cleanup(void *d) { struct scmi_debug_info *dbg = d; @@ -2913,6 +2948,9 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) debugfs_create_u32("rx_max_msg", 0400, trans, (u32 *)&info->rx_minfo.max_msg); + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_COUNTERS)) + scmi_debugfs_counters_setup(dbg, trans); + dbg->top_dentry = top_dentry; if (devm_add_action_or_reset(info->dev, -- 2.34.1