From: Nishanth Menon <nm@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Vibhore Vardhan <vibhore@ti.com>,
Kevin Hilman <khilman@baylibre.com>, Dhruva Gole <d-gole@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] firmware: ti_sci: Partial-IO support
Date: Tue, 30 Jul 2024 10:22:17 -0500 [thread overview]
Message-ID: <20240730152217.ko4eoiwwfckmnmkh@grumpily> (raw)
In-Reply-To: <825ad211-e1c2-44e6-bfe9-c32273799f0d@ti.com>
On 10:12-20240730, Andrew Davis wrote:
[...]
> > + if (response_expected) {
>
> If a response is not expected why not simply return above and not add even more
> indention here? Also, in that case, is the call to mbox_client_txdone() needed?
Unless I am mistaken, if you ignore the actual shutdown usage, the
mbox_client_txdone will need to be invoked for the tx_tick to be
invoked for the next message in the queue to be submitted
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2024-07-30 15:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 8:00 [PATCH v2 0/6] firmware: ti_sci: Partial-IO support Markus Schneider-Pargmann
2024-07-29 8:00 ` [PATCH v2 1/6] dt-bindings: ti, sci: Add property for partial-io-wakeup-sources Markus Schneider-Pargmann
2024-08-06 6:18 ` Krzysztof Kozlowski
2024-08-06 7:11 ` Markus Schneider-Pargmann
2024-08-06 8:03 ` Krzysztof Kozlowski
2024-09-05 9:08 ` Markus Schneider-Pargmann
2024-09-05 9:15 ` Krzysztof Kozlowski
2024-09-05 9:25 ` Krzysztof Kozlowski
2024-09-05 9:49 ` Markus Schneider-Pargmann
2024-09-05 10:41 ` Krzysztof Kozlowski
2024-09-05 11:17 ` Markus Schneider-Pargmann
2024-09-05 11:41 ` Krzysztof Kozlowski
2024-09-27 9:35 ` Markus Schneider-Pargmann
2024-09-28 12:13 ` Krzysztof Kozlowski
2024-07-29 8:00 ` [PATCH v2 2/6] firmware: ti_sci: Partial-IO support Markus Schneider-Pargmann
2024-07-30 12:28 ` Nishanth Menon
2024-07-30 13:01 ` Markus Schneider-Pargmann
2024-07-30 15:07 ` Nishanth Menon
2024-07-31 12:36 ` Markus Schneider-Pargmann
2024-07-31 13:01 ` Nishanth Menon
2024-07-30 15:12 ` Andrew Davis
2024-07-30 15:22 ` Nishanth Menon [this message]
2024-08-06 6:26 ` Krzysztof Kozlowski
2024-08-06 7:19 ` Markus Schneider-Pargmann
2024-08-06 8:50 ` Krzysztof Kozlowski
2024-07-29 8:00 ` [PATCH v2 3/6] arm64: dts: ti: k3-pinctrl: Add WKUP_EN flag Markus Schneider-Pargmann
2024-07-30 12:09 ` Nishanth Menon
2024-07-30 12:32 ` Markus Schneider-Pargmann
2024-07-30 12:37 ` Nishanth Menon
2024-08-06 6:28 ` Krzysztof Kozlowski
2024-07-29 8:00 ` [PATCH v2 4/6] arm64: dts: ti: k3-am62: Add partial-io wakeup sources Markus Schneider-Pargmann
2024-07-29 8:01 ` [PATCH v2 5/6] arm64: dts: ti: k3-am62a: " Markus Schneider-Pargmann
2024-07-29 8:01 ` [PATCH v2 6/6] arm64: dts: ti: k3-am62p: " Markus Schneider-Pargmann
2024-08-06 6:18 ` [PATCH v2 0/6] firmware: ti_sci: Partial-IO support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730152217.ko4eoiwwfckmnmkh@grumpily \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox