From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F200C3DA49 for ; Tue, 30 Jul 2024 15:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uA8WAbDT3MgC22dNiVHn9hnelyg/kG8ABn/6h66j+f0=; b=jHuudTUOjmd6NA8dqB2J0QUEJG FhEL4lyflHZxPNgI7XKCevS4alnIFvqnPOfhoX74EHQXHxjDRWjm7FAutDwhpWCtMn0QJl1uUjJAW 39+6DEQVRxKA8N/xfU1HqN/zKyulPyikSI3U/CdQLecjDNqZr/D/zi2MdiSBG5buMBKzf3+JLh2NT 7/XZCUC7uMcIhYe2S+5iv2ghNPkKivrN6ldUqBCYbZB3Jj5ddAug3NkZNRYeZYk9x7i3uoWKzg1EM i96sn91BM/q7v8gT78wtKrAxhFM/y4um8Yj/Cjz9q3FUoYTrFcZjOBJWQ7KUFBVPwx3aueSHuw+e/ nRfjfDGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYogd-0000000FeaY-3ws0; Tue, 30 Jul 2024 15:22:52 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYogB-0000000FeVh-1l1B for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2024 15:22:24 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 46UFMIas097577; Tue, 30 Jul 2024 10:22:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1722352938; bh=uA8WAbDT3MgC22dNiVHn9hnelyg/kG8ABn/6h66j+f0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=A8x9nh7cs2zxoT+l5vFw+NTVxTB+2dQgoGlI8vSho9uiOwXDmbPPbi87kIjcLR4/o R8DUf7ymxDTB1hf0DgA6tYlSOEk5bhnZsVXLJv+D6/ulmfmUKHmVvIio3lY5tGoK6r MnepCz99qMHa1uMLeQ7AGMZzTaoQO863XdmW8uLs= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 46UFMIh0031254 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Jul 2024 10:22:18 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 30 Jul 2024 10:22:17 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 30 Jul 2024 10:22:17 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 46UFMHeo055910; Tue, 30 Jul 2024 10:22:17 -0500 Date: Tue, 30 Jul 2024 10:22:17 -0500 From: Nishanth Menon To: Andrew Davis CC: Markus Schneider-Pargmann , Tero Kristo , Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Vibhore Vardhan , Kevin Hilman , Dhruva Gole , , , Subject: Re: [PATCH v2 2/6] firmware: ti_sci: Partial-IO support Message-ID: <20240730152217.ko4eoiwwfckmnmkh@grumpily> References: <20240729080101.3859701-1-msp@baylibre.com> <20240729080101.3859701-3-msp@baylibre.com> <825ad211-e1c2-44e6-bfe9-c32273799f0d@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <825ad211-e1c2-44e6-bfe9-c32273799f0d@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_082223_575602_B72C06D0 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10:12-20240730, Andrew Davis wrote: [...] > > + if (response_expected) { > > If a response is not expected why not simply return above and not add even more > indention here? Also, in that case, is the call to mbox_client_txdone() needed? Unless I am mistaken, if you ignore the actual shutdown usage, the mbox_client_txdone will need to be invoked for the tx_tick to be invoked for the next message in the queue to be submitted -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D