From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63898C3DA70 for ; Tue, 30 Jul 2024 16:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q6Gg4mpetERKmnri01RinX1xv8fdQAZPyYJRFBE74SA=; b=q5ABIMmfoTdyCqrvE7f1bgyD9C Nd9tA/FMzlDWWgcKqPCXbkGnuiZIe56cOTAH/ayfEvNH7mkcLr5O/HOqUeaMPuFl9iVrFNNfTDAc7 LNWGe7xbYe1zboSnuUZLZkmbipQvq17q/CsMywJ6SWL+nr01td8OlpaoQ2PpIvp9iXnbRhkzIR0LQ bbhgVoG37VKS+bylGkImUFWMrTNjKms01c9XO3B+vFM2codRYlzapFDH63onU5A+xf5weXRON+Pis GqjV8+nwP5VpPe1ZpLxh2Qf/yI8t0g6DY/qT72Uqq2JqC+++s2QTwwhB8++m8jvjxQ1KoBG1Wu8Cp MktF41Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYprT-0000000FtdB-3nqv; Tue, 30 Jul 2024 16:38:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYpqz-0000000FtVH-0EAH; Tue, 30 Jul 2024 16:37:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5BAA461FA5; Tue, 30 Jul 2024 16:37:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 403A6C32782; Tue, 30 Jul 2024 16:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722357456; bh=IZnrgju2UE3ttoRGRDJsGzu6kxTRyR3poGUPLXgoINI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYx05w+lggKad+7kxiOgbr3aKEnJcYXVTcXpmJO1psJ0eXGxezWdzPfeQ7m7yfbnj Odo7L/ufXiILOqVGaWgqQL57V/HWqSWUA1vEbTzj9YpeQyPNshVNDfvayjAhGeCFsn ND2RFfavrtRypdFsjgj4KkbBGhryQi7ZXF2MpNVaAtoXXbkTubysnkO55Q0X6zAd+r 8kkWTaz4YmZzEAf2dAjeLq6ZylejpAeUaWIktYWkceR5d3H/+4X4E2PpSLeEZS8dIS xrzwTH9EqndBn6IAMN+lH5U5+p+VF/ex0sngo2SoQ3nCrjkmjp8STkDkmWC9QwTwMR 2RaO6Vn/jjc0Q== Date: Tue, 30 Jul 2024 17:37:30 +0100 From: Simon Horman To: Marc Kleine-Budde Cc: kernel@pengutronix.de, Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Elaine Zhang , David Jander , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal Message-ID: <20240730163730.GC1967603@kernel.org> References: <20240729-rockchip-canfd-v1-0-fa1250fd6be3@pengutronix.de> <20240729-rockchip-canfd-v1-11-fa1250fd6be3@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729-rockchip-canfd-v1-11-fa1250fd6be3@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_093737_179365_F9746D9B X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 29, 2024 at 03:05:42PM +0200, Marc Kleine-Budde wrote: > Add a pair new functions to check if 2 struct canfd_frame are equal. > The 1st checks if the header of the CAN frames are equal, the 2nd > checks if the data portion are equal: > > - rkcanfd_can_frame_header_equal() > - rkcanfd_can_frame_data_equal() > > This functionality is needed in the next patch. nit: I would squash this into the next patch as rkcanfd_can_frame_header_equal() is defined but unused in this patch, which is flagged by allmodconfig W=1 builds. ...