From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A92BC3DA64 for ; Wed, 31 Jul 2024 08:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=bHUf3ZMJfSW5yZBcOhnlRUxFvA qP4gev67kguySDI7TMO2zl0X0QpZTinEHC5EwRy5eN0b49NAyEV8C9ugrjv0ESFbZ+qJ/8Ai5IL7m n7pYVKzAfgrp5PHhDrWn3rhge4kDihKMzRwiVRufW8gbC6a38/qkxb8DmbiIN2eFaL9E6tZTh+tR+ eihlIT2JXgG7nM+68h4LagApOYLkfKhfLV+XgCZhLcdNctc3ZFQFU4slHmcN9l6KYFfjgKmsoTdKw zvoTiAd9mIaSI52klvbpb9QO1jAYP58dpuWXw3dSRJZUG57ZGTNG7LLyVsWTFJU9xGE7Wt32hloa/ j2e+I4Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ4SH-00000000Gyr-3ijT; Wed, 31 Jul 2024 08:13:05 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ4Rm-00000000GjJ-1pcG for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 08:12:36 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5a15c2dc569so4762095a12.3 for ; Wed, 31 Jul 2024 01:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722413552; x=1723018352; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=VMEenS+ckueFiLrUs6Ho76Ib3brjcJodwfm99HnBlqfYvmUMGWyRx1XglGNR8n+7bB HQiBrOX+z3o7wl2V5ojwY+30IOIbFlGJZbH0lPPOGdwmnPC6/0q1ndgCDnKGCqUJSltz 4zoghlQ9Pu+29Jgo3kZA/elQh4AEfP8U2CjlPm7kjAJtuM6agyccZ6F5Z41623jraCu/ /dOQxuAAp2k5QSUUTQ2XHaYpBiziGz1PFIzGWqtrTwPanbvzlqnR6n/QqHS8CgW+WtwR 9PGPSsRij9mEJ4VFV0tv1RaY8uFbtPB4HiLVun9ZKk+6WOgG0TY755RGP3HrgR3ajno2 qUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722413552; x=1723018352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bPhqvXPcxjB8hmfad49hCHGbmNQ9dpteVou05ijuxXo=; b=Tt3wDqolNyyovXT+3wfyo+MHrvOcInDg2Y9gbNVZA2t9nS78pdSvGXPTrZ8quxVrEe aa1Zjhzc6o2uVnSEKvDRhjtcY4qy2XTH58Eedzoxf8UVbRR9URef9LOZtteCfk9RC4nQ r1CSHHCvwuE+58sGkAd/IOHxV4ocRF8gosB9//Rv2FjJLNRyuat6ZDeRNzd1OC+TXdMe YYh11amkBZAx2l6Nknh/tOS7VKPDWwVdgwQUtMTugvHlpfs1HEu8pYqvyIdgyxcXqG0P agOL+cWCH32ygHTKDHYaXsZTX7R9UqNrDrD/ye6a2MnpXd1HIcXU4YINHBSoD43WcSGL m2AA== X-Forwarded-Encrypted: i=1; AJvYcCU+RkZIXMXp6d14iW+G923nAPj5B8nwc6HeQsrm+7PYpov0nSDZjEeiDyTvC8BmbBpBgkPOmv0RP7x5hGMMpHjZKREhvA4MVAIkZpLhhDUT6xI+sOg= X-Gm-Message-State: AOJu0Yx2ChGL2K4itpZTQeQMC6DgMNsyEem3IECXGXbU4btfAHsQOmfw nMZTkOOLEhE78Gqea2rylrl0xA7gmGp2K2+ByLwb6+yxTy/xIBtgs5L4P/nGedE= X-Google-Smtp-Source: AGHT+IGxlRCnb+W6DiXG7nTnr6lyiGJnx0i1YWV+5ADomMCnBj37OyG82iPSl5g4jXJI8y3klQMjSg== X-Received: by 2002:a50:d7c1:0:b0:57d:3df:f881 with SMTP id 4fb4d7f45d1cf-5b021190495mr11744615a12.3.1722413552263; Wed, 31 Jul 2024 01:12:32 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac60918cb4sm8394451a12.0.2024.07.31.01.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 01:12:31 -0700 (PDT) Date: Wed, 31 Jul 2024 10:12:31 +0200 From: Andrew Jones To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 57/84] KVM: RISC-V: Mark "struct page" pfns accessed before dropping mmu_lock Message-ID: <20240731-f034f3516f0fffede877c68d@orel> References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-58-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726235234.228822-58-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_011234_576535_99D0B307 X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2024 at 04:52:06PM GMT, Sean Christopherson wrote: > Mark pages accessed before dropping mmu_lock when faulting in guest memory > so that RISC-V can convert to kvm_release_faultin_page() without tripping > its lockdep assertion on mmu_lock being held. Marking pages accessed > outside of mmu_lock is ok (not great, but safe), but marking pages _dirty_ > outside of mmu_lock can make filesystems unhappy. > > Signed-off-by: Sean Christopherson > --- > arch/riscv/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c > index 06aa5a0d056d..806f68e70642 100644 > --- a/arch/riscv/kvm/mmu.c > +++ b/arch/riscv/kvm/mmu.c > @@ -683,10 +683,10 @@ int kvm_riscv_gstage_map(struct kvm_vcpu *vcpu, > out_unlock: > if ((!ret || ret == -EEXIST) && writable) > kvm_set_pfn_dirty(hfn); > + else > + kvm_release_pfn_clean(hfn); > > spin_unlock(&kvm->mmu_lock); > - kvm_set_pfn_accessed(hfn); > - kvm_release_pfn_clean(hfn); > return ret; > } > > -- > 2.46.0.rc1.232.g9752f9e123-goog > Reviewed-by: Andrew Jones