From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80EA0C3DA7F for ; Wed, 31 Jul 2024 09:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6AWeUt/cGKlHOLNdj8lsNBKwG+ptLHvqVfZjBC/FBjA=; b=vMDUsFn6ycLMYyUJgRfxsPpp3u iMF05L2EjfuZrQB5CZeXhvxYVI4xe+6aWe7QJI17YNIvPs7r4f3Nb/kaLzW18DEY3wkbJsF/5REIz DgWcW7n9KiQfUlt8mDU2sQOW6b15B/DzY+ludj4bPwVEKjy/eIfQvAbT5gch9FYYw6CH/iE1n6vSs rI2xuh7KsQ41kbMt8KLUs19YZTyBU3VjcvbcLr/1iriZBOHvNcAP4MemPU3QOudfNXOxiaLLJRnoJ +3EC2m9omd0TDkMYZRXZmR7nVxL79lCo0jd62o2HeEYpSIDCEnXM0r0Y+PKIjQrGpvzIN4UWfSXhg KZXFfl5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ5GQ-00000000QEE-0Vjc; Wed, 31 Jul 2024 09:04:54 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ5Fx-00000000Q7T-0m6K; Wed, 31 Jul 2024 09:04:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8B252CE134A; Wed, 31 Jul 2024 09:04:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAE1DC116B1; Wed, 31 Jul 2024 09:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722416662; bh=qlrQ42mj9B9KmeAFuisuUfxEP8kY222/qGxSpLmiHus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E8GUH++nX2ioiBIyXoWexRei+cHlXC+HGvVQhlJmKWE1D9UB9RYvYL1qMHT3hyLkT ksQWHP6uEK9lr57oAbUnwErdnwVmglT9XJGCX30mY46klT+F8TywrC7RNqnYpTg4SZ vmVyNFoV3Z/3wLWPPpI+kYNrBiH/j+tZPT5jM9i7IGFoiDs85TNwxsfxiHQ+v+B/0l Z9+rVFiSw1CI3IQa4Uz8pGx2OX/9KrsP3z2Dug8RPGilF+hsfJ4ZErdlD29sijy+lu 6BAT5ZtQ/MnWCAhLX1lb3vpjdG4z4wcp8IoNxP5wJHwM7R/UyvrfXun9gDaLlblFu4 0oljdVzE6jI0w== Date: Wed, 31 Jul 2024 10:04:16 +0100 From: Simon Horman To: Marc Kleine-Budde Cc: kernel@pengutronix.de, Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Elaine Zhang , David Jander , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH can-next 19/21] can: rockchip_canfd: add hardware timestamping support Message-ID: <20240731090416.GP1967603@kernel.org> References: <20240729-rockchip-canfd-v1-0-fa1250fd6be3@pengutronix.de> <20240729-rockchip-canfd-v1-19-fa1250fd6be3@pengutronix.de> <20240730163014.GC1781874@kernel.org> <20240731-powerful-scarlet-bullfrog-6ccccd-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731-powerful-scarlet-bullfrog-6ccccd-mkl@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_020425_421203_8D1D4480 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 10:00:41AM +0200, Marc Kleine-Budde wrote: > On 30.07.2024 17:30:14, Simon Horman wrote: > > On Mon, Jul 29, 2024 at 03:05:50PM +0200, Marc Kleine-Budde wrote: > > > Add support for hardware based timestamping. > > > > > > Signed-off-by: Marc Kleine-Budde > > > > Hi Marc, > > > > This patch seems to break allmodconfig builds on (at least) x86_64 > > when applied to net-next. > > > > In file included from drivers/net/can/rockchip/rockchip_canfd-ethtool.c:9: > > drivers/net/can/rockchip/rockchip_canfd.h:471:29: error: field 'cc' has incomplete type > > 471 | struct cyclecounter cc; > > The required header gets somehow pulled in on arm64, but it even fails > on arm. Fixed. Interesting times :) Thanks for addressing this, and likewise my feedback on other patches in this series.