From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13602C3DA64 for ; Wed, 31 Jul 2024 11:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sD6Gjm9intqNxvtkmvWoqH3mQKI1C0bFkBqLXlQoiwU=; b=XOPjo5Ydfmt5EA2yfL+rNiyMze p64Fx08lX+1VpLLtqtPoHgk05sjHGwrCPt/OIAph40uat9MD7cTrYaBmnyTpOSmL1pnFx1YXNzYov DbDNlNemeHujX8gYSyU2+rDzuQsXCJbNhnfpVYxCvRuggpbBi3lsj9CNjtHZmGX6LxkedtNndkPKt LPkCQAINZHTpzVq0rCSSB6zfZr7Ss9Ew/giZDdWv89/1c94k4t3OgI441jcpr4Ausse7wldezzQMw luAAGbuaIYSkLib+V4dy6WDmP980Rawfmm8yK3qBrrMOoAbXYFfA57JDzeE1wWAeN1RlOhhqV7aNN k/SP7cvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ7AS-00000000pqY-1BOd; Wed, 31 Jul 2024 11:06:52 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ79w-00000000pb8-3CDp for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 11:06:22 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 46VB68qC003152; Wed, 31 Jul 2024 06:06:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1722423968; bh=sD6Gjm9intqNxvtkmvWoqH3mQKI1C0bFkBqLXlQoiwU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=n2svMXA2ZKvooYScysFjujLAigj8+Fj2SdKJ0tpMReUL98UZF3LjKtzNGA+Qv0hIK UKU9J0X36JZGfFAntWTLNAMTGYK+MavG+gMYu0gCoFB7OxItV1xNT4/ybB6A36KCmq /aHfFefvYDflhGxQPAnH9JfPZxphtsRDq7kI3YE0= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 46VB68es020021 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Jul 2024 06:06:08 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 31 Jul 2024 06:06:07 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 31 Jul 2024 06:06:07 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 46VB67Uk115008; Wed, 31 Jul 2024 06:06:07 -0500 Date: Wed, 31 Jul 2024 06:06:07 -0500 From: Nishanth Menon To: Manorit Chawdhry CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Udit Kumar , Neha Malcom Francis , Aniket Limaye Subject: Re: [PATCH v2 2/3] arm64: dts: ti: Introduce J742S2 SoC family Message-ID: <20240731110607.7fb42mgcsf2apodv@unshaven> References: <20240730-b4-upstream-j742s2-v2-0-6aedf892156c@ti.com> <20240730-b4-upstream-j742s2-v2-2-6aedf892156c@ti.com> <20240730123343.mqafgpj4zcnd5vs4@plaything> <20240731041916.stcbvkr6ovd7t5vk@uda0497581> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240731041916.stcbvkr6ovd7t5vk@uda0497581> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_040620_981361_86C6CD5D X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09:49-20240731, Manorit Chawdhry wrote: > > > + */ > > > + > > > +#include "k3-j784s4.dtsi" > > > + > > > +/ { > > > + model = "Texas Instruments K3 J742S2 SoC"; > > > + compatible = "ti,j742s2"; > > > + > > > + cpus { > > > + cpu-map { > > > + /delete-node/ cluster1; > > > + }; > > > + }; > > > + > > > + /delete-node/ cpu4; > > > + /delete-node/ cpu5; > > > + /delete-node/ cpu6; > > > + /delete-node/ cpu7; > > > > I suggest refactoring by renaming the dtsi files as common and split out > > j784s4 similar to j722s/am62p rather than using /delete-node/ > > > > I don't mind the suggestion Nishanth if there is a reason behind it. > Could you tell why we should not be using /delete-node/? > Maintenance, readability and sustenance are the reasons. This is a optimized die. It will end up having it's own changes in property and integration details. While reuse is necessary, modifying the properties with overrides and /delete-nodes/ creates maintenance challenges down the road. We already went down this road with am62p reuse with j722s, and eventually determined split and reuse is the best option. See [1] for additional guidance. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n189 -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D