From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD213C3DA64 for ; Wed, 31 Jul 2024 08:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rx22VinvbNEHs/PQQ6Wuk0yJa0qB6p58I2KJaIYfEHw=; b=saSaD+dZGo4QCtwts58sltAhEv 0oI1zEL1vtJOUCfTfHF6MBhb4te8yTUFcjdiN6HXiJepIfleZEV7BZNUh+DpuInsxjU4YT8AEvzZC i+M0xNTjzeiIsclR8837kuFDCrPboiw1lKjtmSiDye323pOnOTcENE354tdvKm+uX3Xzzf1iyvuFd Keoxppv38ENxiqMFT8OWRBHcoy5umk4qtoyZuDM/p0JCPZejK4vvkY/8jU/BNyYi/u1r+ID7gNkV1 xhm3imDdRsQQ8xd6hQw5bKu5EIEhm3/2xuIv463flUgpcsp1nVdIaBVm+eei37vFnYJU9klFEMIAs kfMR0EFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ4aM-00000000IWl-17ix; Wed, 31 Jul 2024 08:21:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ4Zf-00000000IKJ-4C2a for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 08:20:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 36088CE12D7; Wed, 31 Jul 2024 08:20:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F6AC116B1; Wed, 31 Jul 2024 08:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1722414040; bh=om43aKASU793K0N4gd1w31XPTjATtLQ+XdXzAviVw4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AYAdf0GtaEDcmj73MNbltRiU3NGm2GhJYyBIgimyfmzOYfeBtrzrNyB7NntCBfJo9 HFReU8ZZwvE/muKa9fkVRvV852lSyqwBs3mimpMguKToIK/7SPi84+OFI6WXuC2WR6 rO0E8r33UMBRGqgG34TdG/LR9umC3Mc2MxUEcaUo= Date: Wed, 31 Jul 2024 10:20:37 +0200 From: Greg Kroah-Hartman To: Shenwei Wang Cc: Peter Chen , Pawel Laszczak , Shawn Guo , Sascha Hauer , Roger Quadros , Pengutronix Kernel Team , Fabio Estevam , Frank Li , linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: Re: [PATCH v2] usb: cdns3: imx: simplify system pm using _force_suspend/_resume Message-ID: <2024073113-overstep-credit-57fc@gregkh> References: <20240726150731.297443-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726150731.297443-1-shenwei.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_012044_241008_E3D21689 X-CRM114-Status: UNSURE ( 7.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2024 at 10:07:31AM -0500, Shenwei Wang wrote: > By utilizing _force_suspend and _force_resume, ensures a more consistent > and simple approach to handling system sleep states. It also aligns the > driver's PM behavior with the other drivers' common practices. > > Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid duplicated operations") This is not really a "fix" but rather a cleanup, right? Please don't add Fix tags that are not actually fixing things. thanks, greg k-h