From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E14FC3DA7F for ; Wed, 31 Jul 2024 17:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vEMM7SgZ6wraHzWF5zEN2rW8ls6Wr2VKfJmgGXu1icU=; b=vyLTnK06jt2Ybh7oiis6HMIy6v b/fPozMmD13om0YN+MZtQVmK0rcpGekCb7hS2GcdjkrOJnHjAzL+HRdZTnqEXowqfBGO7BEfCfbtJ tgaRMTqp47GpixhPQEaeRul6IqKFNmvkeU8pJhzxhLWN6FHb8tdUbS9snA9eHYO8BeUnCZtjMG2vL /VNNptQ7GGSyVVeS/kWfkwybg3KrLMiznTwcAFwIerNfgzYegQset2An9gnmoSbpYwGLvWyvJ0RSj 0yYHazqppBbfMejT7q+0QTXO4nx3mWq6PrFFMmv5CCZpZT8SHOM8qKGDmSuwdgTt8QW4JquR1Bz+C IQkMwACw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZD6h-000000021CW-2bqe; Wed, 31 Jul 2024 17:27:23 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZD5p-0000000212c-43I9 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 17:26:31 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1ff4568676eso7458595ad.0 for ; Wed, 31 Jul 2024 10:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722446788; x=1723051588; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=vEMM7SgZ6wraHzWF5zEN2rW8ls6Wr2VKfJmgGXu1icU=; b=WdOaL/KGOZ1fGgo5k1xZypwmNEi6043IOlPR19U+4IkRWUrZwWERziOxif2dUPz+cx vy4u6HFdmbgRLa/P2NiNAS+R7oA4HcOWaBqoVA/pBMx3yyDqmqgki9AEMLEMro/qNF7m PhjSCnZAm6Ghc18okzJ/8QI6OQemAnJlVDETnLZuscCocS4vO7RVs5JiKq9HRkiKoWDw RFeyQWvpMAQX16SXBNmRz48Xogc44CRNk1dzur1rtBAfpQZqtGwT+jWsph1FAamor4Gx ++sFPr8CDjU8cVXyUApAFdARFBE6MpWXk0cYyZwHZaWrlIgbirGWZc1qO0WIutdO4L/A Vo/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722446788; x=1723051588; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEMM7SgZ6wraHzWF5zEN2rW8ls6Wr2VKfJmgGXu1icU=; b=m6YEy0QlRO0HWY9BR3s/urgYh0rqJK+4keNiJh4t01o2lg3XU76txHrOc6HyMTxxcH pS/2sKoxkGiBBk8w/m8WlZlyK0ZqUncbSm65SgGjZ9o96JrdK5zL5HduobvZHyy3anva +U7pZskwyDu+/r7xISPGIut+CFT655a74nnuEVmlGfgTjEhh0eoQpQ3j+1qskmv9fsiJ 0SUfY0cmy05ZSsM5+CdG8JIrFKlSS7kMUb5RgWzCPNj2uLxEeeeGcNiwRIo0LqdfVTPt WUfDDXJG09L58z0VNz+oB98Pz4OrQPIMhmBLBaLOoRR3pKvCy8Ru0zYOpRuU3pD9Ty6x MK1A== X-Forwarded-Encrypted: i=1; AJvYcCUwbeqJ+Z+G/mJ4/144ZVJaSHh32pWMPn/J3r42f2VJIR8ZFDAYUJLVaStB/QOkaDWiIElFrQKsGqdPgaWZJT1v2Mwp7Veh/ScSCKkaKgVYQAsHNJ4= X-Gm-Message-State: AOJu0YyaP4Dn83cDNeXxGyYjI6fVZIJXnLS0MxM9jRvGrV8gYDYmkxOi MTCaepc1pJ/xTUYuynucsGPCdgNNexLL8GBK/wyOZHNsEhlw5qOt2I113A25uA== X-Google-Smtp-Source: AGHT+IHh7J+plk/ZeBbKoubQPybF86l1i9/WVmkAlxLUoLz7b4LW6DNPKQz1FsXfyAQPGw0VU7j9UA== X-Received: by 2002:a17:90b:380f:b0:2c8:e43b:4015 with SMTP id 98e67ed59e1d1-2cfe775542bmr3109a91.6.1722446788491; Wed, 31 Jul 2024 10:26:28 -0700 (PDT) Received: from thinkpad ([120.60.66.23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfdc4064d9sm1644762a91.8.2024.07.31.10.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 10:26:27 -0700 (PDT) Date: Wed, 31 Jul 2024 22:56:19 +0530 From: Manivannan Sadhasivam To: Mayank Rana Cc: will@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, cassel@kernel.org, yoshihiro.shimoda.uh@renesas.com, s-vadapalli@ti.com, u.kleine-koenig@pengutronix.de, dlemoal@kernel.org, amishin@t-argos.ru, thierry.reding@gmail.com, jonathanh@nvidia.com, Frank.Li@nxp.com, ilpo.jarvinen@linux.intel.com, vidyas@nvidia.com, marek.vasut+renesas@gmail.com, krzk+dt@kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, quic_ramkri@quicinc.com, quic_nkela@quicinc.com, quic_shazhuss@quicinc.com, quic_msarkar@quicinc.com, quic_nitegupt@quicinc.com Subject: Re: [PATCH V226/7] dt-bindings: PCI: host-generic-pci: Add snps,dw-pcie-ecam-msi binding Message-ID: <20240731172619.GD2983@thinkpad> References: <1721067215-5832-1-git-send-email-quic_mrana@quicinc.com> <1721067215-5832-7-git-send-email-quic_mrana@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1721067215-5832-7-git-send-email-quic_mrana@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_102630_035997_D4EFF2DB X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024 at 11:13:34AM -0700, Mayank Rana wrote: > To support MSI functionality using Synopsys DesignWare PCIe controller > based MSI controller with ECAM driver, add "snps,dw-pcie-ecam-msi > compatible binding which uses provided SPIs to support MSI functionality. > > Signed-off-by: Mayank Rana > --- > .../devicetree/bindings/pci/host-generic-pci.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > index 9c714fa..9e860d5 100644 > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > @@ -81,6 +81,12 @@ properties: > - marvell,armada8k-pcie-ecam > - socionext,synquacer-pcie-ecam > - const: snps,dw-pcie-ecam > + - description: | > + Firmware is configuring Synopsys DesignWare PCIe controller in RC mode with > + ECAM compatible fashion. To use MSI controller of Synopsys DesignWare PCIe > + controller for MSI functionality, this compatible is used. > + items: > + - const: snps,dw-pcie-ecam-msi There is no MSI ECAM. You can have Qcom specific ECAM implementation. Even generalising this as DWC ECAM is wrong, since it won't work on DWC based systems (especially with SCMI power domain). - Mani > - description: > CAM or ECAM compliant PCI host controllers without any quirks > enum: > @@ -116,6 +122,20 @@ properties: > A phandle to the node that controls power or/and system resource or interface to firmware > to enable ECAM compliant PCIe root complex. > > + interrupts: > + description: > + DWC PCIe Root Port/Complex specific MSI interrupt/IRQs. > + minItems: 1 > + maxItems: 8 > + > + interrupt-names: > + description: > + MSI interrupt names > + minItems: 1 > + maxItems: 8 > + items: > + pattern: '^msi[0-9]+$' > + > required: > - compatible > - reg > @@ -146,11 +166,22 @@ allOf: > reg: > maxItems: 1 > > + - if: > + properties: > + compatible: > + contains: > + const: snps,dw-pcie-ecam-msi > + then: > + required: > + - interrupts > + - interrupt-names > + > unevaluatedProperties: false > > examples: > - | > > + #include > bus { > #address-cells = <2>; > #size-cells = <2>; > @@ -180,5 +211,31 @@ examples: > interrupt-map-mask = <0xf800 0x0 0x0 0x7>; > power-domains = <&scmi5_pd 0>; > }; > + > + pcie0: pci@1c00000 { > + compatible = "snps,dw-pcie-ecam-msi"; > + reg = <0x4 0x00000000 0 0x10000000>; > + device_type = "pci"; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges = <0x02000000 0x0 0x40100000 0x0 0x40100000 0x0 0x1ff00000>, > + <0x43000000 0x4 0x10100000 0x4 0x10100000 0x0 0x40000000>; > + bus-range = <0x00 0xff>; > + dma-coherent; > + linux,pci-domain = <0>; > + power-domains = <&scmi5_pd 0>; > + iommu-map = <0x0 &pcie_smmu 0x0000 0x1>, > + <0x100 &pcie_smmu 0x0001 0x1>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "msi0", "msi1", "msi2", "msi3", "msi4", "msi5", "msi6", "msi7"; > + }; > }; > ... > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம்