* [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update @ 2024-07-31 21:47 Ninad Palsule 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm) 0 siblings, 2 replies; 4+ messages in thread From: Ninad Palsule @ 2024-07-31 21:47 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, eajames Cc: Ninad Palsule Hello, This patch only applies to openbmc/linux. The max31785 pmbus driver changes are not available in the upstream yet. I will try to send those changes upstream. Ninad Palsule (1): ARM: dts: aspeed: system1: IBM System1 BMC update .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ 1 file changed, 96 insertions(+) -- 2.43.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-07-31 21:47 [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update Ninad Palsule @ 2024-07-31 21:47 ` Ninad Palsule 2024-07-31 21:57 ` Eddie James 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm) 1 sibling, 1 reply; 4+ messages in thread From: Ninad Palsule @ 2024-07-31 21:47 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, eajames Cc: Ninad Palsule Updated MAX31785a pmbus based fans in the device tree. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts index f3efecc7eb8d0..f96b299d743ba 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts @@ -764,17 +764,113 @@ regulator@43 { }; }; + &i2c6 { status = "okay"; fan-controller@52 { compatible = "maxim,max31785a"; reg = <0x52>; + #address-cells = <1>; + #size-cells = <0>; + + fan0: fan@0 { + compatible = "pmbus-fan"; + reg = <0>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan1: fan@1 { + compatible = "pmbus-fan"; + reg = <1>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan2: fan@2 { + compatible = "pmbus-fan"; + reg = <2>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan3: fan@3 { + compatible = "pmbus-fan"; + reg = <3>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan4: fan@4 { + compatible = "pmbus-fan"; + reg = <4>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; }; fan-controller@54 { compatible = "maxim,max31785a"; reg = <0x54>; + #address-cells = <1>; + #size-cells = <0>; + + fan5: fan@0 { + compatible = "pmbus-fan"; + reg = <0>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan6: fan@1 { + compatible = "pmbus-fan"; + reg = <1>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; }; eeprom@55 { -- 2.43.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule @ 2024-07-31 21:57 ` Eddie James 0 siblings, 0 replies; 4+ messages in thread From: Eddie James @ 2024-07-31 21:57 UTC (permalink / raw) To: Ninad Palsule, robh+dt, krzysztof.kozlowski+dt, conor+dt, joel, andrew, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 7/31/24 16:47, Ninad Palsule wrote: > Updated MAX31785a pmbus based fans in the device tree. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > index f3efecc7eb8d0..f96b299d743ba 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > @@ -764,17 +764,113 @@ regulator@43 { > }; > }; > > + Don't really need the white space here, but no worries. Reviewed-by: Eddie James <eajames@linux.ibm.com> > &i2c6 { > status = "okay"; > > fan-controller@52 { > compatible = "maxim,max31785a"; > reg = <0x52>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan0: fan@0 { > + compatible = "pmbus-fan"; > + reg = <0>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan1: fan@1 { > + compatible = "pmbus-fan"; > + reg = <1>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan2: fan@2 { > + compatible = "pmbus-fan"; > + reg = <2>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan3: fan@3 { > + compatible = "pmbus-fan"; > + reg = <3>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan4: fan@4 { > + compatible = "pmbus-fan"; > + reg = <4>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > }; > > fan-controller@54 { > compatible = "maxim,max31785a"; > reg = <0x54>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + fan5: fan@0 { > + compatible = "pmbus-fan"; > + reg = <0>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > + > + fan6: fan@1 { > + compatible = "pmbus-fan"; > + reg = <1>; > + tach-pulses = <2>; > + maxim,fan-rotor-input = "tach"; > + maxim,fan-pwm-freq = <25000>; > + maxim,fan-dual-tach; > + maxim,fan-no-watchdog; > + maxim,fan-no-fault-ramp; > + maxim,fan-ramp = <2>; > + maxim,fan-fault-pin-mon; > + }; > }; > > eeprom@55 { ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update 2024-07-31 21:47 [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update Ninad Palsule 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule @ 2024-08-01 15:29 ` Rob Herring (Arm) 1 sibling, 0 replies; 4+ messages in thread From: Rob Herring (Arm) @ 2024-08-01 15:29 UTC (permalink / raw) To: Ninad Palsule Cc: andrew, conor+dt, eajames, robh+dt, linux-kernel, krzysztof.kozlowski+dt, linux-arm-kernel, joel, devicetree, linux-aspeed On Wed, 31 Jul 2024 16:47:28 -0500, Ninad Palsule wrote: > Hello, > > This patch only applies to openbmc/linux. The max31785 pmbus driver > changes are not available in the upstream yet. I will try to send those > changes upstream. > > Ninad Palsule (1): > ARM: dts: aspeed: system1: IBM System1 BMC update > > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 96 +++++++++++++++++++ > 1 file changed, 96 insertions(+) > > -- > 2.43.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20240731214737.986010-1-ninad@linux.ibm.com: arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@0: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@1: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@2: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@3: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@52/fan@4: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@0: failed to match any schema with compatible: ['pmbus-fan'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb/bus@1e78a000/i2c@380/fan-controller@54/fan@1: failed to match any schema with compatible: ['pmbus-fan'] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-01 15:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-31 21:47 [PATCH v1 0/1] ARM: dts: aspeed: system1: IBM System1 BMC update Ninad Palsule 2024-07-31 21:47 ` [PATCH v1 1/1] " Ninad Palsule 2024-07-31 21:57 ` Eddie James 2024-08-01 15:29 ` [PATCH v1 0/1] " Rob Herring (Arm)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).