linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
	 Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@linaro.org>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	 Michael Hennerich <Michael.Hennerich@analog.com>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	Jonathan Cameron <jic23@kernel.org>,
	 Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
	 Michal Simek <michal.simek@amd.com>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	Pavel Machek <pavel@ucw.cz>,  Lee Jones <lee@kernel.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	 linux-leds@vger.kernel.org,
	 Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH 3/4] iio: adc: xilinx-ams: use device_* to iterate over device child nodes
Date: Thu, 01 Aug 2024 08:13:52 +0200	[thread overview]
Message-ID: <20240801-device_child_node_access-v1-3-ddfa21bef6f2@gmail.com> (raw)
In-Reply-To: <20240801-device_child_node_access-v1-0-ddfa21bef6f2@gmail.com>

Use `device_for_each_child_node_scoped()` in `ams_parse_firmware()`
to explicitly state device child node access, and simplify the child
node handling as it is not required outside the loop.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/iio/adc/xilinx-ams.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
index f051358d6b50..27d5e4a6f9d6 100644
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -1275,7 +1275,6 @@ static int ams_parse_firmware(struct iio_dev *indio_dev)
 	struct ams *ams = iio_priv(indio_dev);
 	struct iio_chan_spec *ams_channels, *dev_channels;
 	struct device *dev = indio_dev->dev.parent;
-	struct fwnode_handle *child = NULL;
 	struct fwnode_handle *fwnode = dev_fwnode(dev);
 	size_t ams_size;
 	int ret, ch_cnt = 0, i, rising_off, falling_off;
@@ -1297,13 +1296,11 @@ static int ams_parse_firmware(struct iio_dev *indio_dev)
 		num_channels += ret;
 	}
 
-	fwnode_for_each_child_node(fwnode, child) {
+	device_for_each_child_node_scoped(dev, child) {
 		if (fwnode_device_is_available(child)) {
 			ret = ams_init_module(indio_dev, child, ams_channels + num_channels);
-			if (ret < 0) {
-				fwnode_handle_put(child);
+			if (ret < 0)
 				return ret;
-			}
 
 			num_channels += ret;
 		}

-- 
2.43.0



  parent reply	other threads:[~2024-08-01  6:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01  6:13 [PATCH 0/4] use device_for_each_child_node_scoped to access device child nodes Javier Carrasco
2024-08-01  6:13 ` [PATCH 1/4] coresight: cti: use device_* to iterate over " Javier Carrasco
2024-08-01  9:20   ` Suzuki K Poulose
2024-08-01 10:37     ` Javier Carrasco
2024-08-02  7:50       ` Suzuki K Poulose
2024-08-01  6:13 ` [PATCH 2/4] iio: adc: ad7768-1: " Javier Carrasco
2024-08-01  7:31   ` Nuno Sá
2024-08-03 11:17     ` Jonathan Cameron
2024-08-01  6:13 ` Javier Carrasco [this message]
2024-08-03 11:17   ` [PATCH 3/4] iio: adc: xilinx-ams: " Jonathan Cameron
2024-08-01  6:13 ` [PATCH 4/4] leds: as3645a: " Javier Carrasco
2024-08-05 20:58   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240801-device_child_node_access-v1-3-ddfa21bef6f2@gmail.com \
    --to=javier.carrasco.cruz@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anand.ashok.dumbre@xilinx.com \
    --cc=coresight@lists.linaro.org \
    --cc=james.clark@linaro.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=mike.leach@linaro.org \
    --cc=pavel@ucw.cz \
    --cc=sakari.ailus@linux.intel.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).