From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04305C3DA64 for ; Thu, 1 Aug 2024 06:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CNuDB4bLwR4acprYzX2JMVmPgj/lKzcikki7sLZSJG0=; b=ypVZDX9hXcFKN1lQQIXhcuaNL2 MH46e9FLnOD2q2CpmRGZ9Axw5pdMzCzgulG4DCUiiOBo83oLSLYZOjf+ntj13DLmM3fLyJeqA4d4A H9349dQ3axCykVlG+xSbPRSEqxyRV956HGjv6ZClGwmJQy6HO63t3eqqMXfmTW55oPXyH7y6jKYNF 0ozztX+tUz0FI0hcKKUcpPxvThJeUXj8FWUpCm8seHmZYETyySvlHgQkJWA7+dd+xHzRrUiIXXYX5 3No8bVBEyMNMJpKsXZA0cRW0TMfxX3uqAS3r7GUrqq1GaFGULDySffO4gzAnPeG562uQHXOGXY7EC WVAT+Q7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZPFM-00000003zQg-32kF; Thu, 01 Aug 2024 06:25:08 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZP4d-00000003uR8-2zg5 for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 06:14:06 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3687ea0521cso4266589f8f.1 for ; Wed, 31 Jul 2024 23:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722492842; x=1723097642; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CNuDB4bLwR4acprYzX2JMVmPgj/lKzcikki7sLZSJG0=; b=bMoAFJpdDNlY5/8GX2EXj6HIcCkEctj5TbOX+lsnrU+nLDhuBRwf9zen1vpT4XarpR OEQ+lXcJ2G32eMgSo0wfSUFl3vJl5ItD+bBb4WOmkUpuixxZAcJRJGfPAjG6/hDfQJF7 0qgL+r3lfdzj21p8cPHaS3pHYtWpy1JMIhON2IPl7PyCed+q+6KCioV/jCLnN6KiaLmL 9FJx8U0p0ygQF5IW+wgUz+fTXgsthmAeVH9zzNOJ7DeOXq/bEJTXdwOYt8/skWMHEkkN +pBSbCkn9SA+j1CXHS7gBW+nkYBkcl9GliANaDa7X7o2EYrcNl4SkknFi8LtO2rYfuOz jW6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722492842; x=1723097642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CNuDB4bLwR4acprYzX2JMVmPgj/lKzcikki7sLZSJG0=; b=MHAabc0edkQoKNNauIh98lPawo6xtgygRLHH68v9rzPhTgmndNqTz6WKWZG87d/cD0 QRfKm3Y0M0gqa2yTpA2eneAotKf3S7TzE3E4GPkj2YWat3OuHWCkjx2e7uHz5DPtXSTn 41MrJCRyYkMfxVqmEC4HBp3fGG2gf34DQ8wdnx2nrGTyHTYpoDQCWJAmBKMvo61pVLMw 4agkDbe9npSx8QrNBwyBDxKbJwfCCJWNwFPCJg2x0Ts6dYAZyubwJXnY4kD2RYgZf4JP qa94qoHxm20g2LfbFKT9Vvk6phqiGkp7fJflxL0kvQZEGDeFbxXjqMH5zRN3KNofZItP 7Hqg== X-Forwarded-Encrypted: i=1; AJvYcCXhl8igRayj5StrmYzExdc0gnv7I6QofPSRPzvn59hTmGV5P4lyzD++WTKIsUF2iY0UZ+xbDUbGHJV6qt9x4PvkqdsrGM7/c07cE60ltZlSi3z/ib4= X-Gm-Message-State: AOJu0YxHszNshrDs0Pf3MXjCfRAGSfspgdkd2KCK2weyXwmL9idFZPEm yri042fPkFeMTA965ZXqedcDYa3puJGhmG0hoOECqdzgMQpMJKMP X-Google-Smtp-Source: AGHT+IEvftdwznEgDkq633cEgtwng1mS7I9fQC5OIBPjDd3jttKupLDcxY7G5Nlc3ySfC//AjuL7Gw== X-Received: by 2002:a05:6000:1445:b0:368:4b9d:ee2c with SMTP id ffacd0b85a97d-36baace1998mr1455919f8f.19.1722492841664; Wed, 31 Jul 2024 23:14:01 -0700 (PDT) Received: from [127.0.1.1] ([213.208.157.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c032bsm18696455f8f.12.2024.07.31.23.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 23:14:01 -0700 (PDT) From: Javier Carrasco Date: Thu, 01 Aug 2024 08:13:52 +0200 Subject: [PATCH 3/4] iio: adc: xilinx-ams: use device_* to iterate over device child nodes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240801-device_child_node_access-v1-3-ddfa21bef6f2@gmail.com> References: <20240801-device_child_node_access-v1-0-ddfa21bef6f2@gmail.com> In-Reply-To: <20240801-device_child_node_access-v1-0-ddfa21bef6f2@gmail.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Anand Ashok Dumbre , Michal Simek , Sakari Ailus , Pavel Machek , Lee Jones Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1722492833; l=1411; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=i0sBRG11zXAIKwjcoVFnL1Y8Swho6X1BW3kA0cfdhTg=; b=7m5HHkACNNgu/mKXKiw3ayPLFGCDzWUt0OJixovqW9e6tKnbUu5tW6DIs8OjCzuCw1sjzjPGM 1aSWHyGe+yAAbReOXBk5pMYYe2cBhrBvsU4VvOuvv1pEID9ysZtlWuo X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_231404_184756_305E1C1D X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use `device_for_each_child_node_scoped()` in `ams_parse_firmware()` to explicitly state device child node access, and simplify the child node handling as it is not required outside the loop. Signed-off-by: Javier Carrasco --- drivers/iio/adc/xilinx-ams.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index f051358d6b50..27d5e4a6f9d6 100644 --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -1275,7 +1275,6 @@ static int ams_parse_firmware(struct iio_dev *indio_dev) struct ams *ams = iio_priv(indio_dev); struct iio_chan_spec *ams_channels, *dev_channels; struct device *dev = indio_dev->dev.parent; - struct fwnode_handle *child = NULL; struct fwnode_handle *fwnode = dev_fwnode(dev); size_t ams_size; int ret, ch_cnt = 0, i, rising_off, falling_off; @@ -1297,13 +1296,11 @@ static int ams_parse_firmware(struct iio_dev *indio_dev) num_channels += ret; } - fwnode_for_each_child_node(fwnode, child) { + device_for_each_child_node_scoped(dev, child) { if (fwnode_device_is_available(child)) { ret = ams_init_module(indio_dev, child, ams_channels + num_channels); - if (ret < 0) { - fwnode_handle_put(child); + if (ret < 0) return ret; - } num_channels += ret; } -- 2.43.0