From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C43B9C3DA64 for ; Thu, 1 Aug 2024 06:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+L8YiRjBiJi2NiFbZ6hVKOuXnOLL1u0RNfoOt4ZnPSw=; b=1XhWSAmIXE/Gi//nVRzoKQZDFG QCaL88Z2QXcMuaiMJ72ilbCS4sAg5S/BB43+sA2xqAchVAXrtMxqh751ceJTB2EWNeLByUsFjQLDS wrmIH+JSAflwmPg8Jo9MAIRArpicSrICNVqdfodVAsHlM27LLVoDqB/8Q8QL9lHcBsnSPO4YMHn0j +ucfxRX0wGBNHaea1tcy3hNHtzwqQ/YLvuKCAIPjbxP5FxXDrrDwEC4crsuerjidLe646LALtyW3v YkjUp0u4zVRv4OWFC9RiCfyOW37CXz2wmVspnt/bgG+eyZlDLlJ+1lnsL56GQ9SFb+TR1Ka2ZYvwA 2wReJBTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZPFo-00000003zYw-2Wh5; Thu, 01 Aug 2024 06:25:36 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZP4n-00000003uXb-0Hix for linux-arm-kernel@bombadil.infradead.org; Thu, 01 Aug 2024 06:14:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=+L8YiRjBiJi2NiFbZ6hVKOuXnOLL1u0RNfoOt4ZnPSw=; b=etZY++6h57dJkTurIe4SdIi4A3 46tBGGfIFr0BhgVphDnnrWwvHjBRfSkP+yXf7GAVUSq3mWD0ow0xEr0u3Hm0uYm31sxGSKTz3ZSxk vhY//uP7IEOmxpFLj+LRhn3PPIX9tUe5ZcTCZBTl7yzovjEAMRD4k+VIm6U60GyxvoKA1Nt8UgZ8R hKOIl/gmC/Kpa7EbIWDS9iUnTda/9pFK6XxKhICU3Vqeo8rG+amoGMRCYFsQiC4NMIV/iGHoa5TzX pg5IJqkRsdT2wRNcf8Yr56/KGSYEoW4jDgHVN/ay1hsYyy6SGcq7tNELnA9OO7KCLNWWuc/YWeODA Kz8E+Lbg==; Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZP4j-00000005NVX-0W6t for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 06:14:11 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4266dc7591fso40651155e9.0 for ; Wed, 31 Jul 2024 23:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722492844; x=1723097644; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+L8YiRjBiJi2NiFbZ6hVKOuXnOLL1u0RNfoOt4ZnPSw=; b=joqgz3OzzUGySSY3rNsSU9AQr3RHHprRni3W20yVaIf6Cbid9IunDOyuXcKUTutwFA F8TqXy3PD07iujPaeOMds9yjEqPNSWckokXLy4Cb/nsDW/Jcwb0BOcGwSz6D2hCqFJR4 AtZDQnELMF8LJ2wIcV5QZ9IS0EUId5q76a9xHv7UZ84iSU8DRezG51kAohCy92Vlv9am GicxlRwW22tpnzVViUNz/o4pB4SCPz47DdsHqY9sjUN7MUoeYr9pZjEfHvxl/DiOF/WB tZsDj/UIFnUtbriNWHcMTudpuMKjxGCYvRJTCEadCB+tuU0fkj1q7qhVHFZdfwsbMBHZ dBeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722492844; x=1723097644; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+L8YiRjBiJi2NiFbZ6hVKOuXnOLL1u0RNfoOt4ZnPSw=; b=KFoGHVTMlNUBUhTrkygvYsgjbQYFRs4WMsAQjJbHC2ksRm/4xbgPtNXvvA188gnStN 25rk9mwd7J+V7jg/tL/lT7+A1P6TocF2pRzYqGlqhpieS1wphQfeV+Ot6jqtwovumlkT HMmZ3DVps2cHx48iMT1F0TnKgLtw+xD6uE2TaKuTp91V2yzXAMN8mn/euqqPzbFciyB8 kqP9psZ/npnQyqAkgvbuocmVUlAK6+k746W9nVqlpCFkWZp51CFbtjXs9y7DauVX8Bv1 w4pYAvprwIrnvvWRvpvLD3ewVJznnOyXVZf1yPLw+suOLwrvpTDJ+7GWKk/GmASruxeO ZHoA== X-Forwarded-Encrypted: i=1; AJvYcCXdtrhq+FsyDrnhNSz8n8a80v4B4M7lGbUrdqpDAaFHXASejdA63o831yN4LtORTxRaiU14Ki58WJZk2ZBWUFM3Zg0PRalJY/bFkZP8mEzOG34Se+U= X-Gm-Message-State: AOJu0YxUiknl11qDhViFYlnD7P7XqdWHFugR9aGbpag/jolC5K6G45/b v6kyJBLO/p9vcx5YmP3IJSOOSvJOGZccCNjyrql1e0GEhyDL4jTm X-Google-Smtp-Source: AGHT+IG6tOf0ZuCj66jBUdpJ75hyTaGQvDe8snbMCEnWWBBmA6qrhcWqvsDkB9zYFI73n7i+mB+l3Q== X-Received: by 2002:a05:600c:46c6:b0:425:7c95:75d0 with SMTP id 5b1f17b1804b1-428afa57c17mr11596585e9.18.1722492843548; Wed, 31 Jul 2024 23:14:03 -0700 (PDT) Received: from [127.0.1.1] ([213.208.157.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c032bsm18696455f8f.12.2024.07.31.23.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 23:14:03 -0700 (PDT) From: Javier Carrasco Date: Thu, 01 Aug 2024 08:13:53 +0200 Subject: [PATCH 4/4] leds: as3645a: use device_* to iterate over device child nodes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240801-device_child_node_access-v1-4-ddfa21bef6f2@gmail.com> References: <20240801-device_child_node_access-v1-0-ddfa21bef6f2@gmail.com> In-Reply-To: <20240801-device_child_node_access-v1-0-ddfa21bef6f2@gmail.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Anand Ashok Dumbre , Michal Simek , Sakari Ailus , Pavel Machek , Lee Jones Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1722492833; l=1626; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=n9RPwA0mKwp8E3yrA5e5bskfywWjPvxynbcgRtP66H4=; b=KKQapzC7/u9Jck7tT1Y5QlkimkoXnQapCJf6536uEU1HbJu0a4w+37OvHj4efHxY128VYMVz3 D/ifXMyfdkhChw8FAcWBd4j29NwiDIeLsBB2IVdOHzin6zUKRqB2DRV X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_071409_618515_63662E9C X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop the manual access to the fwnode of the device to iterate over its child nodes. `device_for_each_child_node` macro provides direct access to the child nodes, and given that the `child` variable is only required within the loop, the scoped variant of the macro can be used. Use the `device_for_each_child_node_scoped` macro to iterate over the direct child nodes of the device. Signed-off-by: Javier Carrasco --- drivers/leds/flash/leds-as3645a.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/leds/flash/leds-as3645a.c b/drivers/leds/flash/leds-as3645a.c index 2c6ef321b7c8..8e6abedf6e00 100644 --- a/drivers/leds/flash/leds-as3645a.c +++ b/drivers/leds/flash/leds-as3645a.c @@ -478,14 +478,12 @@ static int as3645a_detect(struct as3645a *flash) return as3645a_write(flash, AS_BOOST_REG, AS_BOOST_CURRENT_DISABLE); } -static int as3645a_parse_node(struct as3645a *flash, - struct fwnode_handle *fwnode) +static int as3645a_parse_node(struct as3645a *flash, struct device *dev) { struct as3645a_config *cfg = &flash->cfg; - struct fwnode_handle *child; int rval; - fwnode_for_each_child_node(fwnode, child) { + device_for_each_child_node_scoped(dev, child) { u32 id = 0; fwnode_property_read_u32(child, "reg", &id); @@ -686,7 +684,7 @@ static int as3645a_probe(struct i2c_client *client) flash->client = client; - rval = as3645a_parse_node(flash, dev_fwnode(&client->dev)); + rval = as3645a_parse_node(flash, &client->dev); if (rval < 0) return rval; -- 2.43.0