From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26FFBC3DA64 for ; Thu, 1 Aug 2024 00:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A4tJrLIpI0sa4F9PV7VfZIs2EW4/mW+DbHF9QkterxY=; b=UyS6mdU9TDHzsMOfgBmmc7JQ34 +ZOLs2imiEnF62bmdJ3DAi6TGkJMglOh25Fkjsdhjq7m8jxnKnFb7iyMYgKpHfIvsr4i85jrenngb lpg4o1JCvDdic7R2rTrnXOHlQCXtHJWsxwJBSYyiKsNRYpv8NPXZz/QMwv/HyPb/uAGhNCNCdAfXL h2WqIxzWpyht7NyKMj4/RniyOC+9Ea/PPzObuk1LtrCVvqKc71aZbLxbstnabf1iZogCGZdx3LWLe BijXmaChsoMuLi8ngvcvQFHfq7ReiZeP1CsQp2FiY1kgcmwl05AugBZI9CEG1rnxmIzUmda6Zfe6D ZQTAtDcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZJiM-000000031DP-3FEh; Thu, 01 Aug 2024 00:30:42 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZJht-0000000313s-0anO for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 00:30:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8259ECE1764; Thu, 1 Aug 2024 00:30:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9350AC116B1; Thu, 1 Aug 2024 00:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472210; bh=odM96JhS4fDeDEnXY4eab7LZPhFYf/3AFpfz4YJLqgU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WU0mzxxjYQLCnpkvrGXhzXlOygngo3btVYlBbB5y7CwvFQcGfynPBbc8XXYdD/Y7G Yom9TfjFPlGLYY0m7kvpU3h1jgWDLBQ0bKAIwaZ3KznMy/u9hLH6kdXXkOOMv8Tv2s UPhBevNkcLaWEbmW6WavWDhm892yN6ozlsNBZ1Hwxj80puNkpvzdlxFw+xaQq5e33n 4LiD6vB11/hycvKvCEVsfdbPor/3SJnKS1wGcPdNWSjtA98xWmsKTKJEfc3ZKa6qj9 1K/FR8nft9ER6stdh0TXZTlLT4NH9/JI9aty5ZrjwwTqOci3IxpdPMPK3Jda5BsPGe iE2gF+oYuP/ug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jagadeesh Kona , Viresh Kumar , Sasha Levin , sudeep.holla@arm.com, rafael@kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 28/61] cpufreq: scmi: Avoid overflow of target_freq in fast switch Date: Wed, 31 Jul 2024 20:25:46 -0400 Message-ID: <20240801002803.3935985-28-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801002803.3935985-1-sashal@kernel.org> References: <20240801002803.3935985-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.102 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_173013_361765_1A576D50 X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Jagadeesh Kona [ Upstream commit 074cffb5020ddcaa5fafcc55655e5da6ebe8c831 ] Conversion of target_freq to HZ in scmi_cpufreq_fast_switch() can lead to overflow if the multiplied result is greater than UINT_MAX, since type of target_freq is unsigned int. Avoid this overflow by assigning target_freq to unsigned long variable for converting it to HZ. Signed-off-by: Jagadeesh Kona Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin --- drivers/cpufreq/scmi-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 028df8a5f537a..079940c69ee0b 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -62,9 +62,9 @@ static unsigned int scmi_cpufreq_fast_switch(struct cpufreq_policy *policy, unsigned int target_freq) { struct scmi_data *priv = policy->driver_data; + unsigned long freq = target_freq; - if (!perf_ops->freq_set(ph, priv->domain_id, - target_freq * 1000, true)) + if (!perf_ops->freq_set(ph, priv->domain_id, freq * 1000, true)) return target_freq; return 0; -- 2.43.0