From: Jinjie Ruan <ruanjinjie@huawei.com>
To: <linux@armlinux.org.uk>, <dianders@chromium.org>,
<mhocko@suse.com>, <akpm@linux-foundation.org>, <maz@kernel.org>,
<vschneid@redhat.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH] ARM: smp: Fix missing backtrace IPI statics
Date: Thu, 1 Aug 2024 17:40:22 +0800 [thread overview]
Message-ID: <20240801094022.1402616-1-ruanjinjie@huawei.com> (raw)
It is similar to ARM64 commit 916b93f4e865 ("arm64: smp: Fix missing IPI
statistics"), commit 56afcd3dbd19 ("ARM: Allow IPIs to be handled as normal
interrupts") set CPU_BACKTRACE IPI "IRQ_HIDDEN" flag but not show it in
show_ipi_list(), which cause the interrupt kstat_irqs accounting
is missing in display.
Before this patch, CPU_BACKTRACE IPI is missing (QEMU vexpress-a9):
# cat /proc/interrupts
CPU0
24: 6 GIC-0 34 Level timer
25: 455 GIC-0 29 Level twd
26: 42 GIC-0 75 Edge virtio0
29: 8 GIC-0 44 Level kmi-pl050
30: 118 GIC-0 45 Level kmi-pl050
31: 0 GIC-0 36 Level rtc-pl031
32: 0 GIC-0 41 Level mmci-pl18x (cmd)
33: 0 GIC-0 42 Level mmci-pl18x (pio)
34: 0 GIC-0 92 Level arm-pmu
35: 0 GIC-0 93 Level arm-pmu
36: 0 GIC-0 94 Level arm-pmu
37: 0 GIC-0 95 Level arm-pmu
39: 15 GIC-0 37 Level uart-pl011
IPI0: 0 CPU wakeup interrupts
IPI1: 0 Timer broadcast interrupts
IPI2: 0 Rescheduling interrupts
IPI3: 0 Function call interrupts
IPI4: 0 CPU stop interrupts
IPI5: 0 IRQ work interrupts
IPI6: 0 completion interrupts
Err: 0
After this pacth, CPU_BACKTRACE IPI is displayed:
# cat /proc/interrupts
CPU0
24: 6 GIC-0 34 Level timer
25: 687 GIC-0 29 Level twd
26: 42 GIC-0 75 Edge virtio0
29: 8 GIC-0 44 Level kmi-pl050
30: 134 GIC-0 45 Level kmi-pl050
31: 0 GIC-0 36 Level rtc-pl031
32: 0 GIC-0 41 Level mmci-pl18x (cmd)
33: 0 GIC-0 42 Level mmci-pl18x (pio)
34: 0 GIC-0 92 Level arm-pmu
35: 0 GIC-0 93 Level arm-pmu
36: 0 GIC-0 94 Level arm-pmu
37: 0 GIC-0 95 Level arm-pmu
39: 29 GIC-0 37 Level uart-pl011
IPI0: 0 CPU wakeup interrupts
IPI1: 0 Timer broadcast interrupts
IPI2: 0 Rescheduling interrupts
IPI3: 0 Function call interrupts
IPI4: 0 CPU stop interrupts
IPI5: 0 IRQ work interrupts
IPI6: 0 completion interrupts
IPI7: 0 CPU backtrace interrupts
Err: 0
Fixes: 56afcd3dbd19 ("ARM: Allow IPIs to be handled as normal interrupts")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
arch/arm/kernel/smp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 3431c0553f45..be15cca7f8d7 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -531,7 +531,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
}
}
-static const char *ipi_types[NR_IPI] __tracepoint_string = {
+static const char *ipi_types[MAX_IPI] __tracepoint_string = {
[IPI_WAKEUP] = "CPU wakeup interrupts",
[IPI_TIMER] = "Timer broadcast interrupts",
[IPI_RESCHEDULE] = "Rescheduling interrupts",
@@ -539,6 +539,7 @@ static const char *ipi_types[NR_IPI] __tracepoint_string = {
[IPI_CPU_STOP] = "CPU stop interrupts",
[IPI_IRQ_WORK] = "IRQ work interrupts",
[IPI_COMPLETION] = "completion interrupts",
+ [IPI_CPU_BACKTRACE] = "CPU backtrace interrupts"
};
static void smp_cross_call(const struct cpumask *target, unsigned int ipinr);
@@ -547,7 +548,7 @@ void show_ipi_list(struct seq_file *p, int prec)
{
unsigned int cpu, i;
- for (i = 0; i < NR_IPI; i++) {
+ for (i = 0; i < MAX_IPI; i++) {
if (!ipi_desc[i])
continue;
--
2.34.1
next reply other threads:[~2024-08-01 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 9:40 Jinjie Ruan [this message]
2024-08-01 16:36 ` [PATCH] ARM: smp: Fix missing backtrace IPI statics Russell King (Oracle)
2024-08-02 1:39 ` Jinjie Ruan
2024-08-02 1:44 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801094022.1402616-1-ruanjinjie@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mhocko@suse.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox